From patchwork Mon May 30 22:58:47 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Javier Martinez Canillas X-Patchwork-Id: 9143005 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 6071160761 for ; Mon, 30 May 2016 22:59:00 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 530AD27D17 for ; Mon, 30 May 2016 22:59:00 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 475B62810E; Mon, 30 May 2016 22:59:00 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7920827D17 for ; Mon, 30 May 2016 22:58:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161712AbcE3W66 (ORCPT ); Mon, 30 May 2016 18:58:58 -0400 Received: from lists.s-osg.org ([54.187.51.154]:46413 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161690AbcE3W66 (ORCPT ); Mon, 30 May 2016 18:58:58 -0400 Received: from [10.0.0.104] (host-177.58.217.201.copaco.com.py [201.217.58.177]) by lists.s-osg.org (Postfix) with ESMTPSA id C8569E2749; Mon, 30 May 2016 15:59:33 -0700 (PDT) Subject: Re: [PATCH 2/3] drm/exynos: fimd: add HW trigger support To: Inki Dae , dri-devel@lists.freedesktop.org References: <1459844864-12065-1-git-send-email-inki.dae@samsung.com> <1459844864-12065-3-git-send-email-inki.dae@samsung.com> From: Javier Martinez Canillas Cc: airlied@linux.ie, linux-samsung-soc@vger.kernel.org Message-ID: Date: Mon, 30 May 2016 18:58:47 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <1459844864-12065-3-git-send-email-inki.dae@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hello Inki, On 04/05/2016 04:27 AM, Inki Dae wrote: > This patch adds HW trigger support on i80 mode. > > Until now, Exynos DRM only supported SW trigger which was set > SWTRGCMD bit of TRIGCON register by CPU to transfer scanout > buffer to Display bus device or panel. > > With this patch, the transmission to Display bus device or > panel will be initiated by FIMD controller. > > Signed-off-by: Inki Dae > --- There is a regression for the Exynos5800 Peach Pi Chromebook display due this patch. The display is blank and I noticed that it only happens when HW start trigger is enabled, but works with SW trigger (as it was before). So for example with the following diff on top of v4.7-rc1, display works again. Do you have any hints about what could be the issue? Best regards, diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c index 0444d7fc400d..8c62830e9514 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c @@ -171,7 +171,7 @@ static struct fimd_driver_data exynos5420_fimd_driver_data = { .lcdblk_vt_shift = 24, .lcdblk_bypass_shift = 15, .lcdblk_mic_bypass_shift = 11, - .trg_type = I80_HW_TRG, .has_shadowcon = 1, .has_vidoutcon = 1, .has_vtsel = 1,