| Message ID | acaeee6c3c1f99900614baf99ab31e6e5b515970.1459918214.git.amsfield22@gmail.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
Hi Alison, On 6 April 2016 at 07:18, Alison Schofield <amsfield22@gmail.com> wrote: > Driver includes struct regmap and struct device in its global data. > Remove the struct device and use regmap API to retrieve device info. > > Patch created using Coccinelle plus manual edits. > > Signed-off-by: Alison Schofield <amsfield22@gmail.com> > --- > drivers/iio/accel/mma7455_core.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/iio/accel/mma7455_core.c b/drivers/iio/accel/mma7455_core.c > index c633cc2..c902f54 100644 > --- a/drivers/iio/accel/mma7455_core.c > +++ b/drivers/iio/accel/mma7455_core.c > @@ -55,11 +55,11 @@ > > struct mma7455_data { > struct regmap *regmap; > - struct device *dev; > }; > > static int mma7455_drdy(struct mma7455_data *mma7455) > { > + struct device *dev = regmap_get_device(mma7455->regmap); ah, nice! Acked-by: Joachim Eastwood <manabian@gmail.com> regards, Joachim Eastwood -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 06/04/16 08:35, Joachim Eastwood wrote: > Hi Alison, > > On 6 April 2016 at 07:18, Alison Schofield <amsfield22@gmail.com> wrote: >> Driver includes struct regmap and struct device in its global data. >> Remove the struct device and use regmap API to retrieve device info. >> >> Patch created using Coccinelle plus manual edits. >> >> Signed-off-by: Alison Schofield <amsfield22@gmail.com> >> --- >> drivers/iio/accel/mma7455_core.c | 5 ++--- >> 1 file changed, 2 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/iio/accel/mma7455_core.c b/drivers/iio/accel/mma7455_core.c >> index c633cc2..c902f54 100644 >> --- a/drivers/iio/accel/mma7455_core.c >> +++ b/drivers/iio/accel/mma7455_core.c >> @@ -55,11 +55,11 @@ >> >> struct mma7455_data { >> struct regmap *regmap; >> - struct device *dev; >> }; >> >> static int mma7455_drdy(struct mma7455_data *mma7455) >> { >> + struct device *dev = regmap_get_device(mma7455->regmap); > > ah, nice! > > Acked-by: Joachim Eastwood <manabian@gmail.com> Applied to the togreg branch of iio.git - initially pushed out as testing for the autobuilders to play with it. This one is a fairly standard case and can be easily chased through to see that the device pointer is the same one either way. I'm going to let the rest sit a little longer to see if we get more feedback on them Jonathan > > > regards, > Joachim Eastwood > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/iio/accel/mma7455_core.c b/drivers/iio/accel/mma7455_core.c index c633cc2..c902f54 100644 --- a/drivers/iio/accel/mma7455_core.c +++ b/drivers/iio/accel/mma7455_core.c @@ -55,11 +55,11 @@ struct mma7455_data { struct regmap *regmap; - struct device *dev; }; static int mma7455_drdy(struct mma7455_data *mma7455) { + struct device *dev = regmap_get_device(mma7455->regmap); unsigned int reg; int tries = 3; int ret; @@ -75,7 +75,7 @@ static int mma7455_drdy(struct mma7455_data *mma7455) msleep(20); } - dev_warn(mma7455->dev, "data not ready\n"); + dev_warn(dev, "data not ready\n"); return -EIO; } @@ -260,7 +260,6 @@ int mma7455_core_probe(struct device *dev, struct regmap *regmap, dev_set_drvdata(dev, indio_dev); mma7455 = iio_priv(indio_dev); mma7455->regmap = regmap; - mma7455->dev = dev; indio_dev->info = &mma7455_info; indio_dev->name = name;
Driver includes struct regmap and struct device in its global data. Remove the struct device and use regmap API to retrieve device info. Patch created using Coccinelle plus manual edits. Signed-off-by: Alison Schofield <amsfield22@gmail.com> --- drivers/iio/accel/mma7455_core.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)