From patchwork Fri Feb 8 22:09:29 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marc Gonzalez X-Patchwork-Id: 10803835 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4F5F51390 for ; Fri, 8 Feb 2019 22:23:25 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 40C282EEA2 for ; Fri, 8 Feb 2019 22:23:25 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 33DCD2EEA1; Fri, 8 Feb 2019 22:23:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,FREEMAIL_FROM, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D49A92EEA1 for ; Fri, 8 Feb 2019 22:23:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727083AbfBHWXU (ORCPT ); Fri, 8 Feb 2019 17:23:20 -0500 Received: from smtp4-g21.free.fr ([212.27.42.4]:34280 "EHLO smtp4-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726788AbfBHWXT (ORCPT ); Fri, 8 Feb 2019 17:23:19 -0500 Received: from [192.168.1.42] (unknown [77.207.133.132]) (Authenticated sender: marc.w.gonzalez) by smtp4-g21.free.fr (Postfix) with ESMTPSA id 914C019F54D; Fri, 8 Feb 2019 23:22:40 +0100 (CET) From: Marc Gonzalez Subject: [PATCH v4 0/7] UFS on APQ8098/MSM8998 To: MSM , SCSI Cc: Jeffrey Hugo , Bjorn Andersson , Andy Gross , David Brown , Evan Green , Douglas Anderson , Alim Akhtar , Avri Altman , Pedro Sousa , Rob Herring , Kishon Vijay Abraham , Liam Girdwood , Mark Brown , Martin Petersen , LKML Message-ID: <09ce9c20-c47b-f936-a8a9-6c8ec8f0f867@free.fr> Date: Fri, 8 Feb 2019 23:09:29 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0 SeaMonkey/2.49.4 MIME-Version: 1.0 Content-Language: en-US Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hello, This series adds support for the UFS host controller on APQ8098/MSM8998-based boards. I CCed the regulator maintainers to discuss the revert in patch 6. Basically, the original patch added a quirk which forcefully disables vccq when the UFSHC is connected to a Samsung or Hynix Flash chip. Problem is, this disabling breaks init on my board, and Jeffrey's board as well. Hence the revert, for which I don't see any adverse consequences? Differences between v3 and v4: - Rebase on top of -next - Pick up Douglas Anderson's UFSHC doc fix - Document 8998 UFSHC binding - Improve UFS PHY binding doc - Put the UFS DT patch at the end of the series Difference between v2 and v3: - Add qcom,msm8998-qmp-ufs-phy compat string and match it in the PHY driver - Drop vdd-hba-fixed-regulator - Write the reg addresses with full 32-bit width - Set regulator-allow-set-load only on the 3 rails used by UFS. - Revert the patch introducing ufshcd_set_vccq_rail_unused Difference between v1 and v2: - New patch to add 'regulator-allow-set-load' prop to all vreg nodes - Rename rpmcc node to 'clock-controller' + Add Review tags - Drop UFS pinctrl gymnastics (not required, probably left enabled in bootloader) - Delete GCC_UFS_ICE_CORE_CLK (ICE not used upstream, I think) - Fix sizes of ufsphy register areas based on Jeffrey's feedback - Hack ufshcd_set_vccq_rail_unused into a NOP to work around lock up + reboot Douglas Anderson (1): dt-bindings: ufs: Fix the compatible string definition Marc Gonzalez (6): dt-bindings: ufs: Add msm8998 compatible string dt-bindings: phy-qcom-qmp: Add qcom,msm8998-qmp-ufs-phy phy: qcom-qmp: Add QMP UFS PHY support for msm8998 arm64: dts: qcom: msm8998: Allow drivers to set-load Revert "scsi: ufs: disable vccq if it's not needed by UFS device" arm64: dts: qcom: msm8998: Add UFS nodes .../devicetree/bindings/phy/qcom-qmp-phy.txt | 4 ++ .../devicetree/bindings/ufs/ufshcd-pltfrm.txt | 14 +++-- arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi | 22 +++++++ arch/arm64/boot/dts/qcom/msm8998.dtsi | 62 +++++++++++++++++++ drivers/phy/qualcomm/phy-qcom-qmp.c | 3 + drivers/scsi/ufs/ufs.h | 1 - drivers/scsi/ufs/ufshcd.c | 59 ++---------------- 7 files changed, 104 insertions(+), 61 deletions(-)