| Message ID | 1585214742-5466-1-git-send-email-cang@codeaurora.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | UFS driver general fixes bundle 2 | expand |
> Fixes: a3cd5ec55f6c ("scsi: ufs: add load based scaling of UFS gear") > Signed-off-by: Subhash Jadavani <subhashj@codeaurora.org> > Signed-off-by: Can Guo <cang@codeaurora.org> Reviewed-by: Bean Huo <beanhuo@micron.com>
Can, > We were setting bActiveICCLevel attribute for UFS device only once but > type of this attribute has changed from persistent to volatile since > UFS device specification v2.1. This attribute is set to the default > value after power cycle or hardware reset event. It isn't safe to rely > on prefetched data (only used for bActiveICCLevel attribute > now). Hence this change removes the code related to data prefetching > and set this parameter on every attempt to probe the UFS device. Applied patch #2 to 5.7/scsi-queue. Awaiting Avri's feedback on patch #1. Thanks!
> > Can, > > > We were setting bActiveICCLevel attribute for UFS device only once but > > type of this attribute has changed from persistent to volatile since > > UFS device specification v2.1. This attribute is set to the default > > value after power cycle or hardware reset event. It isn't safe to rely > > on prefetched data (only used for bActiveICCLevel attribute > > now). Hence this change removes the code related to data prefetching > > and set this parameter on every attempt to probe the UFS device. > > Applied patch #2 to 5.7/scsi-queue. Awaiting Avri's feedback on patch > #1. Thanks! It looks fine. Thanks, Avri > > -- > Martin K. Petersen Oracle Linux Engineering
This bundle includes 2 general fixes for UFS driver. Changes since v5: - Fixed a compilation error Changes since v4: - Incoperated comments from Avri. - Added trace back to func ufshcd_scale_clks() - Removed scale_up_gear goto - Added "Fixes" tag to commit messages Changes since v3: - Removed trivial spaces in comments Changes since v2: - Rebased on 5.7/scsi-queue and fixed minor conflicts Changes since v1: - Fixed minor typo Can Guo (1): scsi: ufs: Do not rely on prefetched data Subhash Jadavani (1): scsi: ufs: Clean up ufshcd_scale_clks() and clock scaling error out path drivers/scsi/ufs/ufshcd.c | 91 ++++++++++++++++++++++++++++++----------------- drivers/scsi/ufs/ufshcd.h | 11 ------ 2 files changed, 59 insertions(+), 43 deletions(-)