From patchwork Tue Jul 28 05:00:51 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Can Guo X-Patchwork-Id: 11688131 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 32969913 for ; Tue, 28 Jul 2020 05:02:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 242B222B49 for ; Tue, 28 Jul 2020 05:02:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726865AbgG1FCk (ORCPT ); Tue, 28 Jul 2020 01:02:40 -0400 Received: from labrats.qualcomm.com ([199.106.110.90]:36697 "EHLO labrats.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726821AbgG1FB5 (ORCPT ); Tue, 28 Jul 2020 01:01:57 -0400 IronPort-SDR: zeNSKk4R/edHjWT8+VkC8K7FDfiM1YQXP8XK241Ajfc/gKkv+xjJW4vqcahuEQv52Z36eTc7Lo F75uDger7Q5N+5P6vGjQXG5+8WvVbDB6IaWk4B/YjRxItEZW6mDUd6aqc2tGvMbJlJMLQ7122x zZm0vg3zzQ7xdNIrDDdNjH3ynxKA4dLzq31vnGMu+MYkFmKxU986gjZfO9LnXSGM+5iZLJXZjv WFrqi7+JXc42IPQQJHYv6QIVavB8FemqQD48Eb9V6Q8+AOz3YY2DkniKxnuAInZsguJlqDpYiF uW0= X-IronPort-AV: E=Sophos;i="5.75,405,1589266800"; d="scan'208";a="29056440" Received: from unknown (HELO ironmsg05-sd.qualcomm.com) ([10.53.140.145]) by labrats.qualcomm.com with ESMTP; 27 Jul 2020 22:01:04 -0700 Received: from pacamara-linux.qualcomm.com ([192.168.140.135]) by ironmsg05-sd.qualcomm.com with ESMTP; 27 Jul 2020 22:01:03 -0700 Received: by pacamara-linux.qualcomm.com (Postfix, from userid 359480) id 2589822DA6; Mon, 27 Jul 2020 22:01:03 -0700 (PDT) From: Can Guo To: asutoshd@codeaurora.org, nguyenb@codeaurora.org, hongwus@codeaurora.org, rnayak@codeaurora.org, sh425.lee@samsung.com, linux-scsi@vger.kernel.org, kernel-team@android.com, saravanak@google.com, salyzyn@google.com, cang@codeaurora.org Subject: [PATCH v7 0/8] Fix up and simplify error recovery mechanism Date: Mon, 27 Jul 2020 22:00:51 -0700 Message-Id: <1595912460-8860-1-git-send-email-cang@codeaurora.org> X-Mailer: git-send-email 2.7.4 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org The changes have been tested with error injections of multiple error types (and all kinds of mixture of them) during runtime, e.g. hibern8 enter/ exit error, power mode change error and fatal/non-fatal error from IRQ context. During the test, error injections happen randomly across all contexts, e.g. clk scaling, clk gate/ungate, runtime suspend/resume and IRQ. There are a few more fixes to resolve other minor problems based on the main change, such as LINERESET handling and racing btw error handler and system suspend/resume/shutdown, but they will be pushed after this series is taken, due to there are already too many lines in these changes. Change since v6: - Modified change "scsi: ufs-qcom: Fix schedule while atomic error in ufs_qcom_dump_dbg_regs" to "scsi: ufs-qcom: Remove testbus dump in ufs_qcom_dump_dbg_regs" Change since v5: - Dropped change "scsi: ufs: Fix imbalanced scsi_block_reqs_cnt caused by ufshcd_hold()" as it is not quite related with this series - Refined func ufshcd_err_handling_prepare in change "scsi: ufs: Recover hba runtime PM error in error handler" Change since v4: - Split the original change "ufs: ufs-qcom: Fix a few BUGs in func ufs_qcom_dump_dbg_regs()" to 2 small changes Change since v3: - Split the original change "scsi: ufs: Fix up and simplify error recovery mechanism" into 5 changes Change since v2: - Incorporate Bart's comment to change "scsi: ufs: Add checks before setting clk-gating states" - Revised the commit msg of change "scsi: ufs: Fix up and simplify error recovery mechanism" Change since v1: - Fixed a compilation error in case that CONFIG_PM is N Can Guo (8): scsi: ufs: Add checks before setting clk-gating states ufs: ufs-qcom: Fix race conditions caused by func ufs_qcom_testbus_config scsi: ufs-qcom: Remove testbus dump in ufs_qcom_dump_dbg_regs scsi: ufs: Add some debug infos to ufshcd_print_host_state scsi: ufs: Fix concurrency of error handler and other error recovery paths scsi: ufs: Recover hba runtime PM error in error handler scsi: ufs: Move dumps in IRQ handler to error handler scsi: ufs: Fix a racing problem btw error handler and runtime PM ops drivers/scsi/ufs/ufs-qcom.c | 37 ---- drivers/scsi/ufs/ufs-sysfs.c | 1 + drivers/scsi/ufs/ufshcd.c | 494 +++++++++++++++++++++++++++---------------- drivers/scsi/ufs/ufshcd.h | 15 ++ 4 files changed, 324 insertions(+), 223 deletions(-) Reviewed-by: Bean Huo