mbox series

[V1,0/4] Add per-cpu PM QoS support for QCOM UFS

Message ID 1696952947-18062-1-git-send-email-quic_mnaresh@quicinc.com (mailing list archive)
Headers show
Series Add per-cpu PM QoS support for QCOM UFS | expand

Message

Maramaina Naresh Oct. 10, 2023, 3:49 p.m. UTC 
Add per-cpu PM QoS support for ufs. This improves random io performance
by 20% for ufs.

tiotest benchmark tool io performance results on sm8550 platform:

1. Without PM QoS support
	Type (Speed in)    | Average of 6 iterations
	Random Write(IPOS) | 32201
	Random Read(IPOS)  | 32201

2. With PM QoS support
	Type (Speed in)    | Average of 6 iterations
	Random Write(IPOS) | 40833.5
	Random Read(IPOS)  | 40833.5
(Improvement % with PM QoS = ~20%).

Maramaina Naresh (4):
  dt-bindings: ufs: qcom: Add qos property
  ufs: ufs-qcom: Add per-cpu PM QoS support for ufs
  ufs: ufs-qcom: Add per-cpu PM QoS vote support for ufs
  arm64: dts: qcom: sm8550: Add per-cpu PM QoS support for ufs

 .../devicetree/bindings/ufs/qcom,ufs.yaml          |  16 +
 arch/arm64/boot/dts/qcom/sm8550.dtsi               |   9 +
 drivers/ufs/host/ufs-qcom.c                        | 340 ++++++++++++++++++++-
 drivers/ufs/host/ufs-qcom.h                        |  37 +++
 4 files changed, 401 insertions(+), 1 deletion(-)

Comments

Bart Van Assche Oct. 11, 2023, 8:56 p.m. UTC | #1 
On 10/10/23 08:49, Maramaina Naresh wrote:
> Add per-cpu PM QoS support for ufs. This improves random io performance
> by 20% for ufs.

What in this patch series (other than the DT-bindings) is specific to
the Qualcomm driver? If the answer is not much: please move this
functionality into the UFS driver core.

Thanks,

Bart.
Maramaina Naresh Oct. 20, 2023, 6:45 a.m. UTC | #2 
Hi Bart,

Thank you for reviewing the patch.  This is not specific to the Qualcomm 
driver.

We will move this feature to core UFS.

Thanks,

Naresh.

On 10/12/2023 2:26 AM, Bart Van Assche wrote:
> On 10/10/23 08:49, Maramaina Naresh wrote:
>> Add per-cpu PM QoS support for ufs. This improves random io performance
>> by 20% for ufs.
>
> What in this patch series (other than the DT-bindings) is specific to
> the Qualcomm driver? If the answer is not much: please move this
> functionality into the UFS driver core.
>
> Thanks,
>
> Bart.
>