mbox series

[0/8] qla2xxx: Bug fixes for the driver

Message ID 20180927050518.7147-1-himanshu.madhani@cavium.com (mailing list archive)
Headers show
Series qla2xxx: Bug fixes for the driver | expand

Message

Madhani, Himanshu Sept. 27, 2018, 5:05 a.m. UTC
Hi Martin, 

This series fixes issues found during out last test cycle. 

Patch 1,2 and 5 fixes misc NVMe discovery and unload hang in the driver. 

Patch 3 fixes issue discovered during BFS test setup resulting into
installation failure and hand because driver could not discover BFS Luns.

Patch 4 fixes case where driver was not clearing up Loop ID resulting into
PLOGI failure.

Patch 6 was corner case which could lead to recursive mailbox timeout.

Patch 7 and 8 are fixes for SRB double free. 

These patches were made against 4.19/fixes branch. Please consider this
for next rc inclusion. 

Thanks,
Himanshu
 

Giridhar Malavali (2):
  qla2xxx: Fix for double free of SRB structure used in Async switch
    query commands
  qla2xxx: Move log messages before issuing command to firmware

Himanshu Madhani (1):
  qla2xxx: Fix driver hang when FC-NVMe LUNs are configured

Quinn Tran (5):
  qla2xxx: fix nvme session hang on unload
  qla2xxx: Fix NVMe Target discovery
  qla2xxx: Fix duplicate switch database entries
  qla2xxx: Fix re-using LoopID when handle is in use
  qla2xxx: Fix recursive mailbox timeout

 drivers/scsi/qla2xxx/qla_gs.c     | 24 +++++++-----
 drivers/scsi/qla2xxx/qla_init.c   | 81 ++++++++++++++++++++-------------------
 drivers/scsi/qla2xxx/qla_mbx.c    |  2 +-
 drivers/scsi/qla2xxx/qla_nvme.c   |  5 +--
 drivers/scsi/qla2xxx/qla_os.c     |  4 +-
 drivers/scsi/qla2xxx/qla_target.c |  3 +-
 6 files changed, 62 insertions(+), 57 deletions(-)

Comments

Ewan Milne Sept. 27, 2018, 9:06 p.m. UTC | #1
On Wed, 2018-09-26 at 22:05 -0700, Himanshu Madhani wrote:
> Hi Martin, 
> 
> This series fixes issues found during out last test cycle. 
> 
> Patch 1,2 and 5 fixes misc NVMe discovery and unload hang in the driver. 
> 
> Patch 3 fixes issue discovered during BFS test setup resulting into
> installation failure and hand because driver could not discover BFS Luns.
> 
> Patch 4 fixes case where driver was not clearing up Loop ID resulting into
> PLOGI failure.
> 
> Patch 6 was corner case which could lead to recursive mailbox timeout.
> 
> Patch 7 and 8 are fixes for SRB double free. 
> 
> These patches were made against 4.19/fixes branch. Please consider this
> for next rc inclusion. 
> 
> Thanks,
> Himanshu
>  
> 
> Giridhar Malavali (2):
>   qla2xxx: Fix for double free of SRB structure used in Async switch
>     query commands
>   qla2xxx: Move log messages before issuing command to firmware
> 
> Himanshu Madhani (1):
>   qla2xxx: Fix driver hang when FC-NVMe LUNs are configured
> 
> Quinn Tran (5):
>   qla2xxx: fix nvme session hang on unload
>   qla2xxx: Fix NVMe Target discovery
>   qla2xxx: Fix duplicate switch database entries
>   qla2xxx: Fix re-using LoopID when handle is in use
>   qla2xxx: Fix recursive mailbox timeout
> 
>  drivers/scsi/qla2xxx/qla_gs.c     | 24 +++++++-----
>  drivers/scsi/qla2xxx/qla_init.c   | 81 ++++++++++++++++++++-------------------
>  drivers/scsi/qla2xxx/qla_mbx.c    |  2 +-
>  drivers/scsi/qla2xxx/qla_nvme.c   |  5 +--
>  drivers/scsi/qla2xxx/qla_os.c     |  4 +-
>  drivers/scsi/qla2xxx/qla_target.c |  3 +-
>  6 files changed, 62 insertions(+), 57 deletions(-)
> 

All patches in series Reviewed-by: Ewan D. Milne <emilne@redhat.com>
Martin K. Petersen Sept. 28, 2018, 6:30 a.m. UTC | #2
Himanshu,

> This series fixes issues found during out last test cycle.
>
> Patch 1,2 and 5 fixes misc NVMe discovery and unload hang in the driver. 
>
> Patch 3 fixes issue discovered during BFS test setup resulting into
> installation failure and hand because driver could not discover BFS Luns.
>
> Patch 4 fixes case where driver was not clearing up Loop ID resulting into
> PLOGI failure.
>
> Patch 6 was corner case which could lead to recursive mailbox timeout.
>
> Patch 7 and 8 are fixes for SRB double free. 
>
> These patches were made against 4.19/fixes branch. Please consider this
> for next rc inclusion. 

Even though the changes were individually pretty trivial, it was a big
amount of churn this late in the cycle. So I applied the series to
4.20/scsi-queue. Thanks!