mbox series

[PATCHv5,0/3] Deprecate DAC960 driver

Message ID 20181012071548.129113-1-hare@suse.de (mailing list archive)
Headers show
Series Deprecate DAC960 driver | expand

Message

Hannes Reinecke Oct. 12, 2018, 7:15 a.m. UTC 
Hi all,

as we're trying to get rid of the remaining request_fn drivers here's
a patchset to move the DAC960 driver to the SCSI stack.
As per request from hch I've split up the driver into two new SCSI
drivers called 'myrb' and 'myrs'.

The 'myrb' driver only supports the earlier (V1) firmware interface, which
doesn't have a SCSI interface for the logical drives; for those I've added
a (pretty rudimentary, admittedly) SCSI translation for them.

The 'myrs' driver supports the newer (V2) firmware interface, which is
SCSI based and doesn't need the translation layer.

And the weird proc interface from DAC960 has been converted to sysfs attributes.

Tested with eXtremeRAID 1100 (for V1 Firmware) and Mylex AcceleRAID 170
(for V2 Firmware).

Changes to v4:
- checkpatch fixes
- Remove remaining camel case naming
- Include reviews from Christoph
- More codingstyle fixes

Changes to v3:
- Rename structures to match the general codingstyle
- Replace typedefs

Changes to v2:
- Move to dma_pool API
- Fixup 0-day build issues
- Add myrb_biosparam
- Dropped patch merged with upstream

Changes to v1:
- Split into two drivers
- Improve scanning for V1 firmware interface

Hannes Reinecke (3):
  myrb: Add Mylex RAID controller (block interface)
  myrs: Add Mylex RAID controller (SCSI interface)
  drivers/block: Remove DAC960 driver

 Documentation/blockdev/README.DAC960 |  756 ----
 MAINTAINERS                          |    7 +
 drivers/block/DAC960.c               | 7229 ----------------------------------
 drivers/block/DAC960.h               | 4414 ---------------------
 drivers/block/Kconfig                |   12 -
 drivers/block/Makefile               |    1 -
 drivers/scsi/Kconfig                 |   30 +
 drivers/scsi/Makefile                |    2 +
 drivers/scsi/myrb.c                  | 3656 +++++++++++++++++
 drivers/scsi/myrb.h                  |  958 +++++
 drivers/scsi/myrs.c                  | 3267 +++++++++++++++
 drivers/scsi/myrs.h                  | 1134 ++++++
 include/linux/pci_ids.h              |    2 +
 13 files changed, 9056 insertions(+), 12412 deletions(-)
 delete mode 100644 Documentation/blockdev/README.DAC960
 delete mode 100644 drivers/block/DAC960.c
 delete mode 100644 drivers/block/DAC960.h
 create mode 100644 drivers/scsi/myrb.c
 create mode 100644 drivers/scsi/myrb.h
 create mode 100644 drivers/scsi/myrs.c
 create mode 100644 drivers/scsi/myrs.h

Comments

Bart Van Assche Oct. 12, 2018, 1:38 p.m. UTC | #1 
On 10/12/18 12:15 AM, Hannes Reinecke wrote:
> Hi all,
> 
> as we're trying to get rid of the remaining request_fn drivers here's
> a patchset to move the DAC960 driver to the SCSI stack.
> As per request from hch I've split up the driver into two new SCSI
> drivers called 'myrb' and 'myrs'.

Hi Hannes,

Apparently only patches 1/3 and 2/3 made it to the linux-scsi mailing 
list but patch 3/3 not. See also 
https://marc.info/?l=linux-scsi&r=3&b=201810&w=2.

Bart.
Jens Axboe Oct. 12, 2018, 4:39 p.m. UTC | #2 
On 10/12/18 7:38 AM, Bart Van Assche wrote:
> On 10/12/18 12:15 AM, Hannes Reinecke wrote:
>> Hi all,
>>
>> as we're trying to get rid of the remaining request_fn drivers here's
>> a patchset to move the DAC960 driver to the SCSI stack.
>> As per request from hch I've split up the driver into two new SCSI
>> drivers called 'myrb' and 'myrs'.
> 
> Hi Hannes,
> 
> Apparently only patches 1/3 and 2/3 made it to the linux-scsi mailing 
> list but patch 3/3 not. See also 
> https://marc.info/?l=linux-scsi&r=3&b=201810&w=2.

I'm guessing it's just too big. I got it, but probably due to the CC.
Christoph Hellwig Oct. 17, 2018, 7:28 a.m. UTC | #3 
On Fri, Oct 12, 2018 at 09:15:48AM +0200, Hannes Reinecke wrote:
> The DAC960 driver has been obsoleted by the myrb/myrs drivers,
> so it can be dropped.

Looks fine,

Reviewed-by: Christoph Hellwig <hch@lst.de>
Jens Axboe Oct. 17, 2018, 2:19 p.m. UTC | #4 
On 10/12/18 1:15 AM, Hannes Reinecke wrote:
> Hi all,
> 
> as we're trying to get rid of the remaining request_fn drivers here's
> a patchset to move the DAC960 driver to the SCSI stack.
> As per request from hch I've split up the driver into two new SCSI
> drivers called 'myrb' and 'myrs'.
> 
> The 'myrb' driver only supports the earlier (V1) firmware interface, which
> doesn't have a SCSI interface for the logical drives; for those I've added
> a (pretty rudimentary, admittedly) SCSI translation for them.
> 
> The 'myrs' driver supports the newer (V2) firmware interface, which is
> SCSI based and doesn't need the translation layer.
> 
> And the weird proc interface from DAC960 has been converted to sysfs attributes.
> 
> Tested with eXtremeRAID 1100 (for V1 Firmware) and Mylex AcceleRAID 170
> (for V2 Firmware).

Martin, are you taking the two new drivers? Then I'll queue up the
old driver removal.
Martin K. Petersen Oct. 17, 2018, 10:49 p.m. UTC | #5 
Jens,

> Martin, are you taking the two new drivers? Then I'll queue up the
> old driver removal.

Yep!