mbox series

[v10,00/10] exynos-ufs: Add support for UFS HCI

Message ID 20200528011658.71590-1-alim.akhtar@samsung.com (mailing list archive)
Headers show
Series exynos-ufs: Add support for UFS HCI | expand

Message

Alim Akhtar May 28, 2020, 1:16 a.m. UTC
This patch-set introduces UFS (Universal Flash Storage) host controller support
for Samsung family SoC. Mostly, it consists of UFS PHY and host specific driver.

- Changes since v9
* fixed the review comments by Rob on ufs dt bindings
* Addeded Rob's reviwed-by tag on 08/10 patch

- Changes since v8
* fixed make dt_binding_check error as pointed by Rob
* Addressed review comments from Randy Dunlap

- Changes since v7:
* fixed review comments from Rob and Kishon
* Addeded reviwed-by tags
* rebased on top of v5.7-rc4
 
- Changes since v6:
* Addressed review comments from Avri and Christoph
* Added Reviewed-by tags of Avri and Can on various patches

- Changes since v5:
* re-introduce various quicks which was removed because of no driver
* consumer of those quirks, initial 4 patches does the same.
* Added Reviewed-by tags
* rebased on top of v5.7-rc1
* included Kiwoong's patch in this series, which this driver needs

- Changes since v4:
* Addressed review comments from Avir and Rob 
* Minor improvment on the ufs phy and ufshc drivers
* Added Tested-by from Pawel
* Change UFS binding to DT schema format


- Changes since v3:
* Addressed Kishon's and Avir's review comments
* fixed make dt_binding_check error as pointed by Rob 

- Changes since v2:
* fixed build warning by kbuild test robot 
* Added Reported-by tags

- Changes since v1:
* fixed make dt_binding_check error as pointed by Rob
* Addressed Krzysztof's review comments
* Added Reviewed-by tags

Note: This series is based on Linux-5.7-rc4 (commit: 0e698dfa2822)

Alim Akhtar (9):
  scsi: ufs: add quirk to fix mishandling utrlclr/utmrlclr
  scsi: ufs: add quirk to disallow reset of interrupt aggregation
  scsi: ufs: add quirk to enable host controller without hce
  scsi: ufs: introduce UFSHCD_QUIRK_PRDT_BYTE_GRAN quirk
  dt-bindings: phy: Document Samsung UFS PHY bindings
  phy: samsung-ufs: add UFS PHY driver for samsung SoC
  dt-bindings: ufs: Add bindings for Samsung ufs host
  scsi: ufs-exynos: add UFS host support for Exynos SoCs
  arm64: dts: Add node for ufs exynos7

Kiwoong Kim (1):
  scsi: ufs: add quirk to fix abnormal ocs fatal error

 .../bindings/phy/samsung,ufs-phy.yaml         |   75 +
 .../bindings/ufs/samsung,exynos-ufs.yaml      |   89 ++
 .../boot/dts/exynos/exynos7-espresso.dts      |    4 +
 arch/arm64/boot/dts/exynos/exynos7.dtsi       |   43 +-
 drivers/phy/samsung/Kconfig                   |    9 +
 drivers/phy/samsung/Makefile                  |    1 +
 drivers/phy/samsung/phy-exynos7-ufs.h         |   86 ++
 drivers/phy/samsung/phy-samsung-ufs.c         |  380 +++++
 drivers/phy/samsung/phy-samsung-ufs.h         |  143 ++
 drivers/scsi/ufs/Kconfig                      |   12 +
 drivers/scsi/ufs/Makefile                     |    1 +
 drivers/scsi/ufs/ufs-exynos.c                 | 1292 +++++++++++++++++
 drivers/scsi/ufs/ufs-exynos.h                 |  287 ++++
 drivers/scsi/ufs/ufshcd.c                     |  126 +-
 drivers/scsi/ufs/ufshcd.h                     |   29 +
 drivers/scsi/ufs/unipro.h                     |   33 +
 16 files changed, 2596 insertions(+), 14 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml
 create mode 100644 Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml
 create mode 100644 drivers/phy/samsung/phy-exynos7-ufs.h
 create mode 100644 drivers/phy/samsung/phy-samsung-ufs.c
 create mode 100644 drivers/phy/samsung/phy-samsung-ufs.h
 create mode 100644 drivers/scsi/ufs/ufs-exynos.c
 create mode 100644 drivers/scsi/ufs/ufs-exynos.h


base-commit: 0e698dfa282211e414076f9dc7e83c1c288314fd

Comments

Alim Akhtar June 1, 2020, 1:40 a.m. UTC | #1
> -----Original Message-----
> From: Alim Akhtar <alim.akhtar@samsung.com>
> Sent: 28 May 2020 06:47
> To: robh@kernel.org
> Cc: devicetree@vger.kernel.org; linux-scsi@vger.kernel.org; krzk@kernel.org;
> avri.altman@wdc.com; martin.petersen@oracle.com;
> kwmad.kim@samsung.com; stanley.chu@mediatek.com;
> cang@codeaurora.org; linux-samsung-soc@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; linux-kernel@vger.kernel.org; Alim Akhtar
> <alim.akhtar@samsung.com>
> Subject: [PATCH v10 00/10] exynos-ufs: Add support for UFS HCI
> 
> This patch-set introduces UFS (Universal Flash Storage) host controller support
> for Samsung family SoC. Mostly, it consists of UFS PHY and host specific driver.
> 
.
.
.
> Alim Akhtar (9):
>   scsi: ufs: add quirk to fix mishandling utrlclr/utmrlclr
>   scsi: ufs: add quirk to disallow reset of interrupt aggregation
>   scsi: ufs: add quirk to enable host controller without hce
>   scsi: ufs: introduce UFSHCD_QUIRK_PRDT_BYTE_GRAN quirk
>   dt-bindings: phy: Document Samsung UFS PHY bindings
>   phy: samsung-ufs: add UFS PHY driver for samsung SoC
>   dt-bindings: ufs: Add bindings for Samsung ufs host
>   scsi: ufs-exynos: add UFS host support for Exynos SoCs
>   arm64: dts: Add node for ufs exynos7
> 
> Kiwoong Kim (1):
>   scsi: ufs: add quirk to fix abnormal ocs fatal error
> 
>  .../bindings/phy/samsung,ufs-phy.yaml         |   75 +
>  .../bindings/ufs/samsung,exynos-ufs.yaml      |   89 ++
>  .../boot/dts/exynos/exynos7-espresso.dts      |    4 +
>  arch/arm64/boot/dts/exynos/exynos7.dtsi       |   43 +-
>  drivers/phy/samsung/Kconfig                   |    9 +
>  drivers/phy/samsung/Makefile                  |    1 +
>  drivers/phy/samsung/phy-exynos7-ufs.h         |   86 ++
>  drivers/phy/samsung/phy-samsung-ufs.c         |  380 +++++
>  drivers/phy/samsung/phy-samsung-ufs.h         |  143 ++
>  drivers/scsi/ufs/Kconfig                      |   12 +
>  drivers/scsi/ufs/Makefile                     |    1 +
>  drivers/scsi/ufs/ufs-exynos.c                 | 1292 +++++++++++++++++
>  drivers/scsi/ufs/ufs-exynos.h                 |  287 ++++
>  drivers/scsi/ufs/ufshcd.c                     |  126 +-
>  drivers/scsi/ufs/ufshcd.h                     |   29 +
>  drivers/scsi/ufs/unipro.h                     |   33 +
>  16 files changed, 2596 insertions(+), 14 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/phy/samsung,ufs-
> phy.yaml
>  create mode 100644 Documentation/devicetree/bindings/ufs/samsung,exynos-
> ufs.yaml
>  create mode 100644 drivers/phy/samsung/phy-exynos7-ufs.h
>  create mode 100644 drivers/phy/samsung/phy-samsung-ufs.c
>  create mode 100644 drivers/phy/samsung/phy-samsung-ufs.h
>  create mode 100644 drivers/scsi/ufs/ufs-exynos.c
>  create mode 100644 drivers/scsi/ufs/ufs-exynos.h
> 
Hi Martin and Kishon,
Can you please take the patches into your respective trees?
Thanks,

> 
> base-commit: 0e698dfa282211e414076f9dc7e83c1c288314fd
> --
> 2.17.1
Martin K. Petersen June 3, 2020, 2:31 a.m. UTC | #2
On Thu, 28 May 2020 06:46:48 +0530, Alim Akhtar wrote:

> This patch-set introduces UFS (Universal Flash Storage) host
> controller support for Samsung family SoC. Mostly, it consists of
> UFS PHY and host specific driver.
> [...]

Applied [1,2,3,4,5,9] to 5.9/scsi-queue. The series won't show up in
my public tree until shortly after -rc1 is released.

Thanks!
Alim Akhtar June 8, 2020, 2:45 a.m. UTC | #3
> -----Original Message-----
> From: Martin K. Petersen <martin.petersen@oracle.com>
> Sent: 03 June 2020 08:02
> To: robh@kernel.org; Alim Akhtar <alim.akhtar@samsung.com>
> Cc: Martin K . Petersen <martin.petersen@oracle.com>; krzk@kernel.org;
linux-
> samsung-soc@vger.kernel.org; avri.altman@wdc.com;
> stanley.chu@mediatek.com; linux-scsi@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; cang@codeaurora.org;
devicetree@vger.kernel.org;
> kwmad.kim@samsung.com; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v10 00/10] exynos-ufs: Add support for UFS HCI
> 
> On Thu, 28 May 2020 06:46:48 +0530, Alim Akhtar wrote:
> 
> > This patch-set introduces UFS (Universal Flash Storage) host
> > controller support for Samsung family SoC. Mostly, it consists of UFS
> > PHY and host specific driver.
> > [...]
> 
> Applied [1,2,3,4,5,9] to 5.9/scsi-queue. The series won't show up in my
public
> tree until shortly after -rc1 is released.
> 
Thanks Martin,
Hi Rob and Kishon/Vinod
Can you please pickup dt-bindings and PHY driver respectively?

> Thanks!
> 
> --
> Martin K. Petersen	Oracle Linux Engineering
Kishon Vijay Abraham I June 8, 2020, 2:52 a.m. UTC | #4
Hi Alim,

On 6/8/2020 8:15 AM, Alim Akhtar wrote:
> 
> 
>> -----Original Message-----
>> From: Martin K. Petersen <martin.petersen@oracle.com>
>> Sent: 03 June 2020 08:02
>> To: robh@kernel.org; Alim Akhtar <alim.akhtar@samsung.com>
>> Cc: Martin K . Petersen <martin.petersen@oracle.com>; krzk@kernel.org;
> linux-
>> samsung-soc@vger.kernel.org; avri.altman@wdc.com;
>> stanley.chu@mediatek.com; linux-scsi@vger.kernel.org; linux-arm-
>> kernel@lists.infradead.org; cang@codeaurora.org;
> devicetree@vger.kernel.org;
>> kwmad.kim@samsung.com; linux-kernel@vger.kernel.org
>> Subject: Re: [PATCH v10 00/10] exynos-ufs: Add support for UFS HCI
>>
>> On Thu, 28 May 2020 06:46:48 +0530, Alim Akhtar wrote:
>>
>>> This patch-set introduces UFS (Universal Flash Storage) host
>>> controller support for Samsung family SoC. Mostly, it consists of UFS
>>> PHY and host specific driver.
>>> [...]
>>
>> Applied [1,2,3,4,5,9] to 5.9/scsi-queue. The series won't show up in my
> public
>> tree until shortly after -rc1 is released.
>>
> Thanks Martin,
> Hi Rob and Kishon/Vinod
> Can you please pickup dt-bindings and PHY driver respectively?

You might have CC'ed me only for the PHY patch. I don't have the dt-bindings in
my inbox. Care to re-send what's missing again? This will be merged after -rc1
is tagged.

Thanks
Kishon

> 
>> Thanks!
>>
>> --
>> Martin K. Petersen	Oracle Linux Engineering
>
Alim Akhtar June 11, 2020, 3:18 p.m. UTC | #5
Hi Kishon

> -----Original Message-----
> From: Kishon Vijay Abraham I <kishon@ti.com>
> Sent: 08 June 2020 08:23
> To: Alim Akhtar <alim.akhtar@samsung.com>; 'Martin K. Petersen'
> <martin.petersen@oracle.com>; robh@kernel.org
> Cc: krzk@kernel.org; linux-samsung-soc@vger.kernel.org;
> avri.altman@wdc.com; stanley.chu@mediatek.com; linux-scsi@vger.kernel.org;
> linux-arm-kernel@lists.infradead.org; cang@codeaurora.org;
> devicetree@vger.kernel.org; kwmad.kim@samsung.com; linux-
> kernel@vger.kernel.org; 'Vinod Koul' <vkoul@kernel.org>
> Subject: Re: [PATCH v10 00/10] exynos-ufs: Add support for UFS HCI
> 
> Hi Alim,
> 
> On 6/8/2020 8:15 AM, Alim Akhtar wrote:
> >
> >
> >> -----Original Message-----
> >> From: Martin K. Petersen <martin.petersen@oracle.com>
> >> Sent: 03 June 2020 08:02
> >> To: robh@kernel.org; Alim Akhtar <alim.akhtar@samsung.com>
> >> Cc: Martin K . Petersen <martin.petersen@oracle.com>;
> >> krzk@kernel.org;
> > linux-
> >> samsung-soc@vger.kernel.org; avri.altman@wdc.com;
> >> stanley.chu@mediatek.com; linux-scsi@vger.kernel.org; linux-arm-
> >> kernel@lists.infradead.org; cang@codeaurora.org;
> > devicetree@vger.kernel.org;
> >> kwmad.kim@samsung.com; linux-kernel@vger.kernel.org
> >> Subject: Re: [PATCH v10 00/10] exynos-ufs: Add support for UFS HCI
> >>
> >> On Thu, 28 May 2020 06:46:48 +0530, Alim Akhtar wrote:
> >>
> >>> This patch-set introduces UFS (Universal Flash Storage) host
> >>> controller support for Samsung family SoC. Mostly, it consists of
> >>> UFS PHY and host specific driver.
> >>> [...]
> >>
> >> Applied [1,2,3,4,5,9] to 5.9/scsi-queue. The series won't show up in
> >> my
> > public
> >> tree until shortly after -rc1 is released.
> >>
> > Thanks Martin,
> > Hi Rob and Kishon/Vinod
> > Can you please pickup dt-bindings and PHY driver respectively?
> 
> You might have CC'ed me only for the PHY patch. I don't have the dt-bindings in
> my inbox. Care to re-send what's missing again? This will be merged after -rc1 is
> tagged.
> 
Sure, will re-send this series. 

> Thanks
> Kishon
> 
> >
> >> Thanks!
> >>
> >> --
> >> Martin K. Petersen	Oracle Linux Engineering
> >
Alim Akhtar June 20, 2020, 1:59 a.m. UTC | #6
Hi Kishon,

> -----Original Message-----
> From: Alim Akhtar <alim.akhtar@samsung.com>
> Sent: 11 June 2020 20:49
> To: 'Kishon Vijay Abraham I' <kishon@ti.com>; 'Martin K. Petersen'
> > >>
> > >> Applied [1,2,3,4,5,9] to 5.9/scsi-queue. The series won't show up
> > >> in my
> > > public
> > >> tree until shortly after -rc1 is released.
> > >>
> > > Thanks Martin,
> > > Hi Rob and Kishon/Vinod
> > > Can you please pickup dt-bindings and PHY driver respectively?
> >
> > You might have CC'ed me only for the PHY patch. I don't have the
> > dt-bindings in my inbox. Care to re-send what's missing again? This
> > will be merged after -rc1 is tagged.
> >

-rc1 is out, I do not see phy driver patch in your tree[1] yet, let me know if I am looking into right tree.
[1] -> git://git.kernel.org/pub/scm/linux/kernel/git/phy/linux-phy.git

Thanks! 

> Sure, will re-send this series.
> 
> > Thanks
> > Kishon
Vinod Koul June 24, 2020, 10:21 a.m. UTC | #7
On 20-06-20, 07:29, Alim Akhtar wrote:
> Hi Kishon,
> 
> > -----Original Message-----
> > From: Alim Akhtar <alim.akhtar@samsung.com>
> > Sent: 11 June 2020 20:49
> > To: 'Kishon Vijay Abraham I' <kishon@ti.com>; 'Martin K. Petersen'
> > > >>
> > > >> Applied [1,2,3,4,5,9] to 5.9/scsi-queue. The series won't show up
> > > >> in my
> > > > public
> > > >> tree until shortly after -rc1 is released.
> > > >>
> > > > Thanks Martin,
> > > > Hi Rob and Kishon/Vinod
> > > > Can you please pickup dt-bindings and PHY driver respectively?
> > >
> > > You might have CC'ed me only for the PHY patch. I don't have the
> > > dt-bindings in my inbox. Care to re-send what's missing again? This
> > > will be merged after -rc1 is tagged.
> > >
> 
> -rc1 is out, I do not see phy driver patch in your tree[1] yet, let me know if I am looking into right tree.
> [1] -> git://git.kernel.org/pub/scm/linux/kernel/git/phy/linux-phy.git

Right tree
> 
> Thanks! 
> 
> > Sure, will re-send this series.

But patches have not been sent right, pls send and me/Kishon will review

Thanks
Alim Akhtar June 24, 2020, 4:57 p.m. UTC | #8
Hi Vinod

> -----Original Message-----
> From: Vinod Koul <vkoul@kernel.org>
> Sent: 24 June 2020 15:51
> To: Alim Akhtar <alim.akhtar@samsung.com>
> Cc: 'Kishon Vijay Abraham I' <kishon@ti.com>; robh@kernel.org;
> krzk@kernel.org; linux-samsung-soc@vger.kernel.org; avri.altman@wdc.com;
> stanley.chu@mediatek.com; linux-scsi@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; cang@codeaurora.org;
devicetree@vger.kernel.org;
> kwmad.kim@samsung.com; linux-kernel@vger.kernel.org; 'Martin K. Petersen'
> <martin.petersen@oracle.com>
> Subject: Re: [PATCH v10 00/10] exynos-ufs: Add support for UFS HCI
> 
> On 20-06-20, 07:29, Alim Akhtar wrote:
> > Hi Kishon,
> >
> > > -----Original Message-----
> > > From: Alim Akhtar <alim.akhtar@samsung.com>
> > > Sent: 11 June 2020 20:49
> > > To: 'Kishon Vijay Abraham I' <kishon@ti.com>; 'Martin K. Petersen'
> > > > >>
> > > > >> Applied [1,2,3,4,5,9] to 5.9/scsi-queue. The series won't show
> > > > >> up in my
> > > > > public
> > > > >> tree until shortly after -rc1 is released.
> > > > >>
> > > > > Thanks Martin,
> > > > > Hi Rob and Kishon/Vinod
> > > > > Can you please pickup dt-bindings and PHY driver respectively?
> > > >
> > > > You might have CC'ed me only for the PHY patch. I don't have the
> > > > dt-bindings in my inbox. Care to re-send what's missing again?
> > > > This will be merged after -rc1 is tagged.
> > > >
> >
> > -rc1 is out, I do not see phy driver patch in your tree[1] yet, let me
know if I am
> looking into right tree.
> > [1] -> git://git.kernel.org/pub/scm/linux/kernel/git/phy/linux-phy.git
> 
> Right tree
> >
> > Thanks!
> >
> > > Sure, will re-send this series.
> 
> But patches have not been sent right, pls send and me/Kishon will review
> 
Thanks for your kind attention on this series. As per [0] comment from
Kishon, patch 7/10 [1] and probably 6/10 [2] should have been Applied after
5.8-rc1 was tagged.
I have already send and re-send V10 of this series. Kishon has already
reviewed and provided comments and I have addressed them as well. These
patches already have and Reviewed-by, Tested-by tags.
Let me know if something more needs to be done from my side.
[0] https://lkml.org/lkml/2020/6/7/410
[1] https://lkml.org/lkml/2020/5/27/1705
[2] https://lkml.org/lkml/2020/5/27/1701

Thanks!

> Thanks
> --
> ~Vinod
Vinod Koul June 24, 2020, 5:30 p.m. UTC | #9
Hi Alim,

On 24-06-20, 22:27, Alim Akhtar wrote:
> > > > Sure, will re-send this series.
> > 
> > But patches have not been sent right, pls send and me/Kishon will review
> > 
> Thanks for your kind attention on this series. As per [0] comment from
> Kishon, patch 7/10 [1] and probably 6/10 [2] should have been Applied after
> 5.8-rc1 was tagged.

And that is something I am trying atm, but I dont have patches in my
mailbox, so would you be kind enough to resend me these patches after
rebasing to phy-next, also do add acks/reviews collected in previous
posts.

I dont think I have seen resend, or maybe I wasnt cced

> I have already send and re-send V10 of this series. Kishon has already
> reviewed and provided comments and I have addressed them as well. These
> patches already have and Reviewed-by, Tested-by tags.
> Let me know if something more needs to be done from my side.
> [0] https://lkml.org/lkml/2020/6/7/410
> [1] https://lkml.org/lkml/2020/5/27/1705
> [2] https://lkml.org/lkml/2020/5/27/1701
Alim Akhtar June 25, 2020, 12:21 a.m. UTC | #10
Hi Vinod,

> -----Original Message-----
> From: Vinod Koul <vkoul@kernel.org>
> Sent: 24 June 2020 23:00
> To: Alim Akhtar <alim.akhtar@samsung.com>
> Cc: 'Kishon Vijay Abraham I' <kishon@ti.com>; robh@kernel.org;
> krzk@kernel.org; linux-samsung-soc@vger.kernel.org; avri.altman@wdc.com;
> stanley.chu@mediatek.com; linux-scsi@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; cang@codeaurora.org;
devicetree@vger.kernel.org;
> kwmad.kim@samsung.com; linux-kernel@vger.kernel.org; 'Martin K. Petersen'
> <martin.petersen@oracle.com>
> Subject: Re: [PATCH v10 00/10] exynos-ufs: Add support for UFS HCI
> 
> Hi Alim,
> 
> On 24-06-20, 22:27, Alim Akhtar wrote:
> > > > > Sure, will re-send this series.
> > >
> > > But patches have not been sent right, pls send and me/Kishon will
> > > review
> > >
> > Thanks for your kind attention on this series. As per [0] comment from
> > Kishon, patch 7/10 [1] and probably 6/10 [2] should have been Applied
> > after
> > 5.8-rc1 was tagged.
> 
> And that is something I am trying atm, but I dont have patches in my
mailbox, so
> would you be kind enough to resend me these patches after rebasing to phy-
> next, also do add acks/reviews collected in previous posts.
> 
> I dont think I have seen resend, or maybe I wasnt cced
> 
Just noticed you were not CCed.
I have sent those two patches.
https://patchwork.kernel.org/patch/11624571/
https://patchwork.kernel.org/patch/11624569/

PTAL,

Thanks,

> 
> --
> ~Vinod