[v7,0/6] Introduce sendpage_ok() to detect misused sendpage in network related drivers

Message

Coly Li Aug. 18, 2020, 1:12 p.m. UTC

This series was original by a bug fix in nvme-over-tcp driver which only
checked whether a page was allocated from slab allcoator, but forgot to
check its page_count: The page handled by sendpage should be neither a
Slab page nor 0 page_count page.

As Sagi Grimberg suggested, the original fix is refind to a more common
inline routine:
    static inline bool sendpage_ok(struct page *page)
    {
        return  (!PageSlab(page) && page_count(page) >= 1);
    }
If sendpage_ok() returns true, the checking page can be handled by the
zero copy sendpage method in network layer.

The first patch in this series introduces sendpage_ok() in header file
include/linux/net.h, the second patch fixes the page checking issue in
nvme-over-tcp driver, the third patch adds page_count check by using
sendpage_ok() in do_tcp_sendpages() as Eric Dumazet suggested, and all
rested patches just replace existing open coded checks with the inline
sendpage_ok() routine.

Coly Li

Cc: Chaitanya Kulkarni <[e-mail]>
Cc: Chris Leech <[e-mail]>
Cc: Christoph Hellwig <[e-mail]>
Cc: Cong Wang <[e-mail]>
Cc: David S. Miller <[e-mail]>
Cc: Eric Dumazet <[e-mail]>
Cc: Hannes Reinecke <[e-mail]>
Cc: Ilya Dryomov <[e-mail]>
Cc: Jan Kara <[e-mail]>
Cc: Jeff Layton <[e-mail]>
Cc: Jens Axboe <[e-mail]>
Cc: Lee Duncan <[e-mail]>
Cc: Mike Christie <[e-mail]>
Cc: Mikhail Skorzhinskii <[e-mail]>
Cc: Philipp Reisner <[e-mail]>
Cc: Sagi Grimberg <[e-mail]>
Cc: Vasily Averin <[e-mail]>
Cc: Vlastimil Babka <[e-mail]>
---
Changelog:
v7: remove outer brackets from the return line of sendpage_ok() as
    Eric Dumazet suggested.
v6: fix page check in do_tcp_sendpages(), as Eric Dumazet suggested.
    replace other open coded checks with sendpage_ok() in libceph,
    iscsi drivers.
v5, include linux/mm.h in include/linux/net.h
v4, change sendpage_ok() as an inline helper, and post it as
    separate patch, as Christoph Hellwig suggested.
v3, introduce a more common sendpage_ok() as Sagi Grimberg suggested.
v2, fix typo in patch subject
v1, the initial version. 


Coly Li (6):
  net: introduce helper sendpage_ok() in include/linux/net.h
  nvme-tcp: check page by sendpage_ok() before calling kernel_sendpage()
  tcp: use sendpage_ok() to detect misused .sendpage
  drbd: code cleanup by using sendpage_ok() to check page for
    kernel_sendpage()
  scsi: libiscsi: use sendpage_ok() in iscsi_tcp_segment_map()
  libceph: use sendpage_ok() in ceph_tcp_sendpage()

 drivers/block/drbd/drbd_main.c |  2 +-
 drivers/nvme/host/tcp.c        |  7 +++----
 drivers/scsi/libiscsi_tcp.c    |  2 +-
 include/linux/net.h            | 16 ++++++++++++++++
 net/ceph/messenger.c           |  2 +-
 net/ipv4/tcp.c                 |  3 ++-
 6 files changed, 24 insertions(+), 8 deletions(-)