[RESEND,00/19] Rid W=1 warnings in SCSI

Message

Lee Jones Nov. 2, 2020, 2:23 p.m. UTC

[Resending to include the SCSI ML as per Martin's request]

This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.

Lee Jones (19):
  scsi: aic7xxx: aic79xx_osm: Remove unused variable 'saved_scsiid'
  scsi: mpt3sas: mpt3sas_scsih: Fix function documentation formatting
  scsi: lpfc: lpfc_scsi: Fix a whole host of kernel-doc issues
  scsi: lpfc: lpfc_attr: Demote kernel-doc format for redefined
    functions
  scsi: lpfc: lpfc_attr: Fix-up a bunch of kernel-doc misdemeanours
  scsi: lpfc: lpfc_debugfs: Fix a couple of function documentation
    issues
  scsi: lpfc: lpfc_bsg: Provide correct documentation for a bunch of
    functions
  scsi: esas2r: esas2r_disc: Place brackets around a potentially empty
    if()
  scsi: esas2r: esas2r_init: Place brackets around a potentially empty
    if()
  scsi: lpfc: lpfc_nvme: Remove unused variable 'phba'
  scsi: ufs: ufshcd: Fix some function doc-rot
  scsi: lpfc: lpfc_nvme: Fix some kernel-doc related issues
  scsi: esas2r: esas2r_int: Add brackets around potentially empty if()s
  scsi: lpfc: lpfc_nvmet: Fix-up some formatting and doc-rot issues
  scsi: esas2r: esas2r_main: Demote non-conformant kernel-doc header
  scsi: advansys: Relocate or remove unused variables
  scsi: dc395x: Remove a few unused variables
  scsi: dc395x: Mark 's_stat2' as __maybe_unused
  scsi: hpsa: Strip out a bunch of set but unused variables

 drivers/scsi/advansys.c              | 16 ++------
 drivers/scsi/aic7xxx/aic79xx_osm.c   |  3 +-
 drivers/scsi/dc395x.c                | 15 +++-----
 drivers/scsi/esas2r/esas2r_disc.c    |  3 +-
 drivers/scsi/esas2r/esas2r_init.c    |  5 ++-
 drivers/scsi/esas2r/esas2r_int.c     |  8 ++--
 drivers/scsi/esas2r/esas2r_main.c    |  8 +---
 drivers/scsi/hpsa.c                  | 25 ++++---------
 drivers/scsi/lpfc/lpfc_attr.c        | 56 +++++++++++++++++-----------
 drivers/scsi/lpfc/lpfc_bsg.c         | 34 ++++++++---------
 drivers/scsi/lpfc/lpfc_debugfs.c     |  3 +-
 drivers/scsi/lpfc/lpfc_nvme.c        | 37 ++++++++----------
 drivers/scsi/lpfc/lpfc_nvmet.c       | 17 ++++-----
 drivers/scsi/lpfc/lpfc_scsi.c        | 48 +++++++++++++++---------
 drivers/scsi/mpt3sas/mpt3sas_scsih.c |  8 ++--
 drivers/scsi/ufs/ufshcd.c            |  3 +-
 16 files changed, 141 insertions(+), 148 deletions(-)

Comments

Martin K. Petersen Nov. 11, 2020, 3:30 a.m. UTC | #1

Lee,

> This set is part of a larger effort attempting to clean-up W=1
> kernel builds, which are currently overwhelmingly riddled with
> niggly little warnings.

Applied 1-18 to 5.11/scsi-staging, thanks! Patch 19 didn't build.