[RFC,00/24] target: code cleanup

Message

Chaitanya Kulkarni Feb. 20, 2021, 9:36 p.m. UTC

Hi,

This removes unused macros, various memsets, extra variable
in the target/iblock for bio get and fixes some type mismatch for the
same with fix for smatch warnings.

Marking it as RFC as I don't know if these cleanups are acceptable or
not.

I've geterated this on the linux-block, we decided to move forward wicth
this then I'll send series based on right repo.

-ck

Chaitanya Kulkarni (24):
  target/iblock: remove an extra argument
  target/iblock: trim down line longer than 80 char
  target/iblock: fix the type of the logs_per_phys
  targe/pscsi: fix the warning in pscsi_complete_cmd
  target/sbc: get rid of the warning in cmp & write
  target/pscsi: remove unsed macro ISPRINT
  target/stat: remove unsed macro ISPRINT
  target/stat: remove unsed macro NONE
  target/stat: remove unsed macro
  target/iscsi: remove unsed macro TEXT_LEN
  target/iscsi: remove unsed macro PRINT_BUF
  target/iscsi: remove the memset with declare-init
  target/configfs: remove the memset with declare-init
  target/configfs: remove the memset with declare-init
  target/configfs: remove the memset with declare-init
  target/configfs: remove the memset with declare-init
  target/configfs: remove the memset with declare-init
  target/configfs: remove the memset with declare-init
  target/configfs: remove the memset with declare-init
  target/pr: remove the memset with declare-init
  target/pr: remove the memset with declare-init
  target/pr: remove the memset with declare-init
  target/core: don't duplicate memset 0xff
  target: mark __rcu to avoid warning

 drivers/target/iscsi/iscsi_target_configfs.c |  3 +-
 drivers/target/iscsi/iscsi_target_nego.c     |  1 -
 drivers/target/iscsi/iscsi_target_stat.c     |  1 -
 drivers/target/iscsi/iscsi_target_util.c     | 17 ---------
 drivers/target/target_core_configfs.c        | 25 ++++---------
 drivers/target/target_core_file.c            |  3 +-
 drivers/target/target_core_iblock.c          | 37 ++++++++++----------
 drivers/target/target_core_pr.c              | 36 +++++++------------
 drivers/target/target_core_pscsi.c           |  5 ++-
 drivers/target/target_core_sbc.c             |  4 +--
 drivers/target/target_core_stat.c            |  3 --
 include/scsi/libfc.h                         |  2 +-
 12 files changed, 46 insertions(+), 91 deletions(-)

Comments

Bart Van Assche Feb. 20, 2021, 11:38 p.m. UTC | #1

On 2/20/21 1:36 PM, Chaitanya Kulkarni wrote:
> This removes unused macros, various memsets, extra variable
> in the target/iblock for bio get and fixes some type mismatch for the
> same with fix for smatch warnings.
> 
> Marking it as RFC as I don't know if these cleanups are acceptable or
> not.
> 
> I've geterated this on the linux-block, we decided to move forward wicth
> this then I'll send series based on right repo.

Please mention in the cover letter how these issues have been
discovered. Have these issues been discovered by inspecting the code
manually or perhaps by a tool (e.g. checkpatch)?

>   target/pscsi: remove unsed macro ISPRINT

Please fix the spelling in the patch subjects and also in the cover letter.

Thanks,

Bart.