| Message ID | 20210628133412.1172068-1-martin.kepplinger@puri.sm (mailing list archive) |
|---|---|
| Headers | show
Return-Path: <linux-scsi-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level:
X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,
HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,
SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
by smtp.lore.kernel.org (Postfix) with ESMTP id B2D11C49EA3
for <linux-scsi@archiver.kernel.org>; Mon, 28 Jun 2021 13:35:48 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
by mail.kernel.org (Postfix) with ESMTP id 948626145F
for <linux-scsi@archiver.kernel.org>; Mon, 28 Jun 2021 13:35:48 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S232491AbhF1NiL (ORCPT <rfc822;linux-scsi@archiver.kernel.org>);
Mon, 28 Jun 2021 09:38:11 -0400
Received: from comms.puri.sm ([159.203.221.185]:47418 "EHLO comms.puri.sm"
rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
id S232248AbhF1Nh0 (ORCPT <rfc822;linux-scsi@vger.kernel.org>);
Mon, 28 Jun 2021 09:37:26 -0400
Received: from localhost (localhost [127.0.0.1])
by comms.puri.sm (Postfix) with ESMTP id 71537E01B9;
Mon, 28 Jun 2021 06:34:31 -0700 (PDT)
Received: from comms.puri.sm ([127.0.0.1])
by localhost (comms.puri.sm [127.0.0.1]) (amavisd-new, port 10024)
with ESMTP id tRBK4TkhrQzn; Mon, 28 Jun 2021 06:34:29 -0700 (PDT)
From: Martin Kepplinger <martin.kepplinger@puri.sm>
To: martin.kepplinger@puri.sm
Cc: bvanassche@acm.org, jejb@linux.ibm.com,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
linux-scsi@vger.kernel.org, martin.petersen@oracle.com,
stern@rowland.harvard.edu
Subject: [PATCH v4 0/3] fix runtime PM for SD card readers
Date: Mon, 28 Jun 2021 15:34:09 +0200
Message-Id: <20210628133412.1172068-1-martin.kepplinger@puri.sm>
Content-Transfer-Encoding: 8bit
Precedence: bulk
List-ID: <linux-scsi.vger.kernel.org>
X-Mailing-List: linux-scsi@vger.kernel.org
|
| Series | fix runtime PM for SD card readers | expand |
hi, (According to Alan Stern, "as far as I know, all") SD card readers send MEDIA_CHANGED unit attention notification on (runtime) resume. We cannot use runtime PM with these devices as I/O always fails in that case. This fixes runtime PM for SD cardreaders. I'd appreciate any feedback. To enable runtime PM for an SD cardreader number 0:0:0:0, do: echo 0 > /sys/module/block/parameters/events_dfl_poll_msecs echo 1000 > /sys/bus/scsi/devices/0:0:0:0/power/autosuspend_delay_ms echo auto > /sys/bus/scsi/devices/0:0:0:0/power/control thank you, martin revision history ---------------- v4: (thank you Bart and Alan) * send SENSE REQUEST in sd instead of adding a global scsi error flag. v3: (thank you Bart) * create a new BLIST entry to mark affected devices instead of the sysfs module parameter for sd only. still, only sd implements handling the flag for now. * cc linux-pm list https://lore.kernel.org/linux-scsi/20210328102531.1114535-1-martin.kepplinger@puri.sm/ v2: https://lore.kernel.org/linux-scsi/20210112093329.3639-1-martin.kepplinger@puri.sm/ * move module parameter to sd * add Documentation v1: https://lore.kernel.org/linux-scsi/20210111152029.28426-1-martin.kepplinger@puri.sm/T/ For the full background, the discussion started in June 2020 here: https://lore.kernel.org/linux-scsi/20200623111018.31954-1-martin.kepplinger@puri.sm/ Martin Kepplinger (3): scsi: devinfo: add new flag BLIST_MEDIA_CHANGE scsi: sd: send REQUEST SENSE for BLIST_MEDIA_CHANGE devices in runtime_resume() scsi: devinfo: add BLIST_MEDIA_CHANGE for Ultra HS-SD/MMC usb cardreaders drivers/scsi/scsi_devinfo.c | 1 + drivers/scsi/sd.c | 37 ++++++++++++++++++++++++++++++++++++- include/scsi/scsi_devinfo.h | 6 +++--- 3 files changed, 40 insertions(+), 4 deletions(-)