[V4,0/2] scsi: ufs: Fix runtime PM messages never-ending cycle

Message

Adrian Hunter Feb. 28, 2022, 11:36 a.m. UTC

Hi

Here is V4 to address comments by Martin.  See patches for version history.

Summary:

Kernel messages produced during runtime PM can cause a never-ending
cycle because user space utilities (e.g. journald or rsyslog) write the
messages back to storage, causing runtime resume, more messages, and so
on.

Messages that tell of things that are expected to happen, are arguably
unnecessary, so make changes to suppress them for the UFS driver.


Adrian Hunter (2):
      scsi: Add quiet_suspend flag for SCSI devices to suppress some PM messages
      scsi: ufs: Fix runtime PM messages never-ending cycle

 drivers/scsi/scsi_error.c  |  9 +++++++--
 drivers/scsi/sd.c          |  6 ++++--
 drivers/scsi/ufs/ufshcd.c  | 21 +++++++++++++++++++--
 include/scsi/scsi_device.h |  6 ++++++
 4 files changed, 36 insertions(+), 6 deletions(-)


Regards
Adrian

Comments

Martin K. Petersen March 2, 2022, 4:54 a.m. UTC | #1

Adrian,

> Kernel messages produced during runtime PM can cause a never-ending
> cycle because user space utilities (e.g. journald or rsyslog) write
> the messages back to storage, causing runtime resume, more messages,
> and so on.
>
> Messages that tell of things that are expected to happen, are arguably
> unnecessary, so make changes to suppress them for the UFS driver.

Applied to 5.18/scsi-staging, thanks!

Martin K. Petersen March 9, 2022, 4:15 a.m. UTC | #2

On Mon, 28 Feb 2022 13:36:50 +0200, Adrian Hunter wrote:

> Here is V4 to address comments by Martin.  See patches for version history.
> 
> Summary:
> 
> Kernel messages produced during runtime PM can cause a never-ending
> cycle because user space utilities (e.g. journald or rsyslog) write the
> messages back to storage, causing runtime resume, more messages, and so
> on.
> 
> [...]

Applied to 5.18/scsi-queue, thanks!

[1/2] scsi: Add quiet_suspend flag for SCSI devices to suppress some PM messages
      https://git.kernel.org/mkp/scsi/c/af4edb1d50c6
[2/2] scsi: ufs: Fix runtime PM messages never-ending cycle
      https://git.kernel.org/mkp/scsi/c/71bb9ab6e351