mbox series

[v2,0/2] target: core: fix race during ACL removal

Message ID 20220727214125.19647-1-d.bogdanov@yadro.com (mailing list archive)
Headers show
Series target: core: fix race during ACL removal | expand

Message

Dmitry Bogdanov July 27, 2022, 9:41 p.m. UTC 
This patchset fixes a race condition due to incorrect usage of RCU
for se_dev_entry.se_lun variable when ACL is being removed.

Based on 5.20/scsi-queue.

v2:
  add more details in commit message
  fix misformatting

Dmitry Bogdanov (2):
  target: core: fix race during ACL removal
  target: core: de-RCU of se_lun and se_lun acl

 drivers/target/target_core_alua.c   |  3 +--
 drivers/target/target_core_device.c | 32 ++++++++++-------------------
 drivers/target/target_core_pr.c     | 28 ++++++++-----------------
 drivers/target/target_core_stat.c   | 10 ++++-----
 drivers/target/target_core_xcopy.c  |  2 +-
 include/target/target_core_base.h   |  4 ++--
 6 files changed, 27 insertions(+), 52 deletions(-)

Comments

Mike Christie July 28, 2022, 6:42 p.m. UTC | #1 
On 7/27/22 4:41 PM, Dmitry Bogdanov wrote:
> This patchset fixes a race condition due to incorrect usage of RCU
> for se_dev_entry.se_lun variable when ACL is being removed.
> 
> Based on 5.20/scsi-queue.
> 
> v2:
>   add more details in commit message
>   fix misformatting
> 
> Dmitry Bogdanov (2):
>   target: core: fix race during ACL removal
>   target: core: de-RCU of se_lun and se_lun acl
> 
>  drivers/target/target_core_alua.c   |  3 +--
>  drivers/target/target_core_device.c | 32 ++++++++++-------------------
>  drivers/target/target_core_pr.c     | 28 ++++++++-----------------
>  drivers/target/target_core_stat.c   | 10 ++++-----
>  drivers/target/target_core_xcopy.c  |  2 +-
>  include/target/target_core_base.h   |  4 ++--
>  6 files changed, 27 insertions(+), 52 deletions(-)
> 

Reviewed-by: Mike Christie <michael.christie@oracle.com>
Martin K. Petersen Aug. 1, 2022, 11:36 p.m. UTC | #2 
Dmitry,

> This patchset fixes a race condition due to incorrect usage of RCU for
> se_dev_entry.se_lun variable when ACL is being removed.

Applied to 5.20/scsi-staging, thanks!