[0/2] Check and update the device link rate during discovery

Message

Yihang Li Oct. 20, 2022, 2:16 p.m. UTC

SATA devices attached to an expander maybe generate incorrect IOs when
physical link re-establish at a lower link rate. This is due to the
expander PHY attached to a SATA PHY is using link rate greater than the
physical PHY link rate which is re-established.

This patchset fixes the issue.

Yihang Li (2):
  scsi: libsas: Add sas_update_linkrate()
  scsi: libsas: Add sas_check_port_linkrate()

 drivers/scsi/libsas/sas_discover.c | 18 +++++++++++++-
 drivers/scsi/libsas/sas_expander.c | 40 ++++++++++++++++++++++++++++++
 drivers/scsi/libsas/sas_internal.h |  1 +
 3 files changed, 58 insertions(+), 1 deletion(-)

Comments

John Garry Oct. 21, 2022, 8:17 a.m. UTC | #1

On 20/10/2022 15:16, Yihang Li wrote:
> SATA devices attached to an expander maybe generate incorrect IOs when
> physical link re-establish at a lower link rate. This is due to the
> expander PHY attached to a SATA PHY is using link rate greater than the
> physical PHY link rate which is re-established.
> 

How do you create this scenario? I thought that I added min pathway 
support for root phy, such that we have min pathway support for root phy 
through 1x expander to a sata disk for initial discovery. I can't 
remember exactly the scenario I added support for....

BTW, did you mean the send this to mainline scsi mailng list? You did 
not cc maintainers Martin and James.

> This patchset fixes the issue.
> 
> Yihang Li (2):
>    scsi: libsas: Add sas_update_linkrate()
>    scsi: libsas: Add sas_check_port_linkrate()
> 
>   drivers/scsi/libsas/sas_discover.c | 18 +++++++++++++-
>   drivers/scsi/libsas/sas_expander.c | 40 ++++++++++++++++++++++++++++++
>   drivers/scsi/libsas/sas_internal.h |  1 +
>   3 files changed, 58 insertions(+), 1 deletion(-)
>

Yihang Li Oct. 23, 2022, 7:07 a.m. UTC | #2

Hi,

Sorry, I sent the wrong email address, please ignore this series.

Yihang

On 2022/10/20 22:16, Yihang Li wrote:
> SATA devices attached to an expander maybe generate incorrect IOs when
> physical link re-establish at a lower link rate. This is due to the
> expander PHY attached to a SATA PHY is using link rate greater than the
> physical PHY link rate which is re-established.
> 
> This patchset fixes the issue.
> 
> Yihang Li (2):
>   scsi: libsas: Add sas_update_linkrate()
>   scsi: libsas: Add sas_check_port_linkrate()
> 
>  drivers/scsi/libsas/sas_discover.c | 18 +++++++++++++-
>  drivers/scsi/libsas/sas_expander.c | 40 ++++++++++++++++++++++++++++++
>  drivers/scsi/libsas/sas_internal.h |  1 +
>  3 files changed, 58 insertions(+), 1 deletion(-)
>