From patchwork Wed Nov 23 12:21:35 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wenchao Hao X-Patchwork-Id: 13053595 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BA80C433FE for ; Wed, 23 Nov 2022 12:22:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235880AbiKWMWF (ORCPT ); Wed, 23 Nov 2022 07:22:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236063AbiKWMVx (ORCPT ); Wed, 23 Nov 2022 07:21:53 -0500 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 58AA73F04B; Wed, 23 Nov 2022 04:21:52 -0800 (PST) Received: from dggpemm500024.china.huawei.com (unknown [172.30.72.54]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4NHKsk3zX9zJns8; Wed, 23 Nov 2022 20:18:34 +0800 (CST) Received: from dggpemm500017.china.huawei.com (7.185.36.178) by dggpemm500024.china.huawei.com (7.185.36.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 23 Nov 2022 20:21:50 +0800 Received: from build.huawei.com (10.175.101.6) by dggpemm500017.china.huawei.com (7.185.36.178) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 23 Nov 2022 20:21:50 +0800 From: Wenchao Hao To: Lee Duncan , Chris Leech , "Mike Christie" , "James E . J . Bottomley" , "Martin K . Petersen" , , CC: , , , Wenchao Hao Subject: [PATCH v3 0/2] Fix scsi device's iodone_cnt mismatch with iorequest_cnt Date: Wed, 23 Nov 2022 20:21:35 +0800 Message-ID: <20221123122137.150776-1-haowenchao@huawei.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 X-Originating-IP: [10.175.101.6] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpemm500017.china.huawei.com (7.185.36.178) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Following scenario would make scsi_device's iodone_cnt mismatch with iorequest_cnt even if there is no request on this device any more. 1. request timeout happened. If we do not retry the timeouted command, this command would be finished in scsi_finish_command() which would not increase the iodone_cnt; if the timeouted command is retried, another increasement for iorequest_cnt would be performed, the command might add iorequest_cnt for multiple times but iodone_cnt only once. Increase iodone_cnt in scsi_timeout() can handle this scenario. 2. scsi_dispatch_cmd() failed, while the iorequest_cnt has already been increased. If scsi_dispatch_cmd() failed, the request would be requeued, then another iorequest_cnt would be added. So we should not increase iorequest_cnt if dispatch command failed V3: - Rebase to solve conflicts caused by context when apply patch V2: - Add description about why we can add iodone_cnt in scsi_timeout() - Do not increase iorequest_cnt if dispatch command failed Wenchao Hao (2): scsi: increase scsi device's iodone_cnt in scsi_timeout() scsi: donot increase scsi_device's iorequest_cnt if dispatch failed drivers/scsi/scsi_error.c | 1 + drivers/scsi/scsi_lib.c | 3 +-- 2 files changed, 2 insertions(+), 2 deletions(-)