[v4,0/5] scsi: mpi3mr: fix issues found by KASAN

Message

Shin'ichiro Kawasaki Jan. 27, 2023, 6:34 a.m. UTC

While I downloaded new firmware to eHBA-9600 on KASAN enabled kernel, I observed
three BUGs. The first three patches resolve one of the BUGs and related two more
issues found during the review. The following two patches resolve the two left
BUGs respectively.

Changes from v3:
* Moved 1st patch to 3rd to resolve a compiler warning

Changes from v2:
* Added 1st and 2nd patches to address issues found during review
* 3rd patch: changed fix approach per comment on the list
* Added Acked-by and Reviewed-by tags

Changes from v1:
* 2nd patch: Modified to use bitmap helper functions and number of bits
* 1st/3rd patches: Reflected a comment on the list and added Reviewed-by tags

Shin'ichiro Kawasaki (5):
  scsi: mpi3mr: fix calculation of valid entry length in alltgt_info
  scsi: mpi3mr: fix alltgt_info copy size
  scsi: mpi3mr: remove unnecessary memcpy
  scsi: mpi3mr: use number of bits to manage bitmap sizes
  scsi: mpi3mr: fix missing mrioc->evtack_cmds initialization

 drivers/scsi/mpi3mr/mpi3mr.h     | 10 +----
 drivers/scsi/mpi3mr/mpi3mr_app.c | 18 +++------
 drivers/scsi/mpi3mr/mpi3mr_fw.c  | 68 +++++++++++++-------------------
 drivers/scsi/mpi3mr/mpi3mr_os.c  |  4 ++
 4 files changed, 39 insertions(+), 61 deletions(-)

Comments

Martin K. Petersen Feb. 8, 2023, 11:09 p.m. UTC | #1

> While I downloaded new firmware to eHBA-9600 on KASAN enabled kernel,
> I observed three BUGs. The first three patches resolve one of the BUGs
> and related two more issues found during the review. The following two
> patches resolve the two left BUGs respectively.

Broadcom: Please review and test. Thank you!