From patchwork Mon Aug 28 22:25:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nick Desaulniers X-Patchwork-Id: 13368383 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE0BBC71153 for ; Mon, 28 Aug 2023 22:26:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232908AbjH1W0R (ORCPT ); Mon, 28 Aug 2023 18:26:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230426AbjH1WZy (ORCPT ); Mon, 28 Aug 2023 18:25:54 -0400 Received: from mail-yw1-x114a.google.com (mail-yw1-x114a.google.com [IPv6:2607:f8b0:4864:20::114a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6BDA139 for ; Mon, 28 Aug 2023 15:25:51 -0700 (PDT) Received: by mail-yw1-x114a.google.com with SMTP id 00721157ae682-594e6bee9f8so36181567b3.1 for ; Mon, 28 Aug 2023 15:25:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1693261551; x=1693866351; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=whuv4S/qXJ8VQLIk5LEoFSmpFljXlYmrEoJuQBk2GD4=; b=aEdfAKE2aENnO6tvTzasPUqknc7wJ6diEIJLvmUQxxJpKywDYrFsVaCYoE3h51sd7c H+oNWaX4aq3A9uIj9bL7KrPvklouBN4OyA/O+XRgrZAULDLLXXawVpiMY5oabbtF/wrO T4Y17/d+q5j7Mm+T/22mbRuV9bHjI2eqFaVVdQSE7hMYmEMWSjjjJb5MbTTUnpKCk0Xu 7xk5D3xPPMOUz/9r1kmavYv+JGeABhxJbcya7t+GEsGBOZ0ciJaeoY4ZWJy299oj0ESY qDYS3ugO2ay3oFwjN3PzQ/KJQjiYf+YEkyAwmBnSaJWMkXK+sjdejHWq2+Umb4RQ3ZHZ Q89Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693261551; x=1693866351; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=whuv4S/qXJ8VQLIk5LEoFSmpFljXlYmrEoJuQBk2GD4=; b=EttgmcyGPN8BUCkJ/apGQNIl/cD0+YRGfy2g+R11+bNQOH4/2gXi/kY7oewjVMF/jo AIsgXCdcS8yFn5yASU/iMca1zQJMHi5iB5R+4tqJwCRdpCzahaoHoK4RIqtDCHCyII1f teLGNLVMoEapsWEopS0Ra4ZISJrDc8WH5Dd7qaXZEQcwrZqtjPrZH1NnMnDI/3BhtMCc aGOtJFmRyfZUsHWcOQxc6tuVgSl6deRyIxneTuzrbJ5Iy6TH7efzXnnzbh1OC9n0ZaXr luqulWQAAJCUKNzAzt2CCOIauurqOtnTmHxzfoML12a/Dt2JkmSvME6Mo/6OUG45KyjT BgUQ== X-Gm-Message-State: AOJu0YwesZvroZZX+PMeOo7yI6Wlz+O/Hztnz5RZ4bg5OvDD5swOjQ0g lU/6SS85KLnEl3Fz4oyxIDo+1rqwmNZvCGNP/cs= X-Google-Smtp-Source: AGHT+IE7Nhcb/ZUZVQuQ5+u99sOJ9CdIHBMpQ83N0Fim/iD9z8v4Zjz9mkQBdpgoc9W3GrUHfZjMtDEsE8i0aeHVjQI= X-Received: from ndesaulniers-desktop.svl.corp.google.com ([2620:15c:2d1:203:b64:7817:9989:9eba]) (user=ndesaulniers job=sendgmr) by 2002:a81:7653:0:b0:586:5d03:67c8 with SMTP id j19-20020a817653000000b005865d0367c8mr899523ywk.3.1693261550964; Mon, 28 Aug 2023 15:25:50 -0700 (PDT) Date: Mon, 28 Aug 2023 15:25:46 -0700 Mime-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAOoe7WQC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDI2MDCyML3eLk4sz4tPyiksy0Sl3LNIsUI3PLpDTLxEQloJaCotS0zAqwcdG xtbUAr2FdoF4AAAA= X-Developer-Key: i=ndesaulniers@google.com; a=ed25519; pk=eMOZeIQ4DYNKvsNmDNzVbQZqpdex34Aww3b8Ah957X4= X-Developer-Signature: v=1; a=ed25519-sha256; t=1693261549; l=1211; i=ndesaulniers@google.com; s=20230823; h=from:subject:message-id; bh=TGWROu4XNrgfx+3UVHqDnOnYYRlkH/LvjbNZAKHZcUI=; b=XYoq8WEHFYZk0OilZBxoZZDH9/jZiqs7gMqgs5QyaYYkDOElw0g9B4HqjTu1AEVRVmw6fBvvf Ta1Q02qYmpODS2FmJeLM2eUD1tbl9vpZGTd9Fq02p9gFPekMg5OCxXH X-Mailer: b4 0.12.3 Message-ID: <20230828-scsi_fortify-v1-0-8dde624a3b2c@google.com> Subject: [PATCH 0/2] scsi: fix 2 cases of -Wfortify-source From: Nick Desaulniers To: Hannes Reinecke , "James E.J. Bottomley" , "Martin K. Petersen" , Nathan Chancellor Cc: Tom Rix , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, Nick Desaulniers Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org clang-18 has improved its support for detecting operations that will truncate values at runtime via -wfortify-source resulting in two new warnings (or errors with CONFIG_WERROR=y): drivers/scsi/myrb.c:1906:10: warning: 'snprintf' will always be truncated; specified size is 32, but format string expands to at least 34 [-Wfortify-source] drivers/scsi/myrs.c:1089:10: warning: 'snprintf' will always be truncated; specified size is 32, but format string expands to at least 34 [-Wfortify-source] When we have a string literal that does not contain any format flags, rather than use snprintf (sometimes with a size that's too small), let's use sprintf. This is pattern is cleaned up throughout two files. Signed-off-by: Nick Desaulniers --- Nick Desaulniers (2): scsi: myrb: fix -Wfortify-source scsi: myrs: fix -Wfortify-source drivers/scsi/myrb.c | 8 ++++---- drivers/scsi/myrs.c | 14 +++++++------- 2 files changed, 11 insertions(+), 11 deletions(-) --- base-commit: 2dde18cd1d8fac735875f2e4987f11817cc0bc2c change-id: 20230828-scsi_fortify-9f8d279bf9aa Best regards,