[0/4] simplify ufshcd with the guard() macro

Message

Avri Altman April 16, 2024, 10:23 a.m. UTC

We can simplify the code with the guard() macro and co for  automatic
cleanup of locks. For making changes easier, this series is divided to
per-lock type patches and only address the ufshcd module. There are
still a few remaining explicit lock/unlock calls, and those are for the
places where we do temporary unlock/relock, which doesn't fit well with
the guard(), so far.

Only code refactoring, and no functional changes.


Avri Altman (4):
  scsi: ufs: core: Make use of guard(spinlock_irqsave)
  scsi: ufs: core: Make use of guard(spinlock)
  scsi: ufs: core: Make use of guard(spinlock_irq)
  scsi: ufs: core: Make use of guard(mutex)

 drivers/ufs/core/ufshcd.c | 623 +++++++++++++++++---------------------
 1 file changed, 270 insertions(+), 353 deletions(-)

Comments

Bart Van Assche April 16, 2024, 7:16 p.m. UTC | #1

On 4/16/24 03:23, Avri Altman wrote:
> We can simplify the code with the guard() macro and co for  automatic
> cleanup of locks. For making changes easier, this series is divided to
> per-lock type patches and only address the ufshcd module. There are
> still a few remaining explicit lock/unlock calls, and those are for the
> places where we do temporary unlock/relock, which doesn't fit well with
> the guard(), so far.

Why to use only the existing primitives? Several error paths could be 
eliminated if new macros would be included for e.g. automatically
calling ufshcd_release() at the end of a scope.

Bart.