mbox series

[v2,0/8] Fix cdrom autoclose.

Message ID cover.1571834862.git.msuchanek@suse.de (mailing list archive)
Headers show
Series Fix cdrom autoclose. | expand

Message

Michal Suchanek Oct. 23, 2019, 12:52 p.m. UTC 
Link: https://lore.kernel.org/lkml/cover.1513263482.git.msuchanek@suse.de/

Hello,

there is cdrom autoclose feature that is supposed to close the tray,
wait for the disc to become ready, and then open the device.

This used to work in ancient times. Then in old times there was a hack
in util-linux which worked around the breakage which probably resulted
from switching to scsi emulation.

Currently util-linux maintainer refuses to merge another hack on the
basis that kernel still has the feature so it should be fixed there.
The code needs not be replicated in every userspace utility like mount
or dd which has no business knowing which devices are CD-roms and where
the autoclose setting is in the kernel.

Michal Suchanek (8):
  cdrom: add poll_event_interruptible
  cdrom: factor out common open_for_* code
  cdrom: wait for the tray to close
  cdrom: separate autoclose into an IOCTL
  docs: cdrom: Add autoclose IOCTL
  bdev: add open_finish.
  scsi: sr: workaround VMware ESXi cdrom emulation bug
  scsi: sr: wait for the medium to become ready

 Documentation/filesystems/locking.rst |   2 +
 Documentation/ioctl/cdrom.rst         |  25 ++++
 drivers/cdrom/cdrom.c                 | 188 ++++++++++++++------------
 drivers/scsi/sr.c                     |  60 ++++++--
 fs/block_dev.c                        |  21 ++-
 include/linux/blkdev.h                |   1 +
 include/uapi/linux/cdrom.h            |   1 +
 7 files changed, 198 insertions(+), 100 deletions(-)