mbox series

[00/11] NCR5380: Bug fixes and other improvements

Message ID cover.1723001788.git.fthain@linux-m68k.org (mailing list archive)
Headers show
Series NCR5380: Bug fixes and other improvements | expand

Message

Finn Thain Aug. 7, 2024, 3:36 a.m. UTC
This series begins with some work on the mac_scsi driver to improve
compatibility with SCSI2SD v5 devices. Better error handling is needed
there because the PDMA hardware does not tolerate the write latency spikes
which SD cards can produce.

A bug is fixed in the 5380 core driver so that scatter/gather can be
enabled in mac_scsi.

Several patches at the end of this series improve robustness and correctness
in the core driver.

This series has been tested on a variety of mac_scsi hosts. A variety of
SCSI targets was also tested, including Quantum HDD, Fujitsu HDD, Iomega FDD,
Ricoh CD-RW, Matsushita CD-ROM, SCSI2SD and BlueSCSI.


Finn Thain (11):
  scsi: mac_scsi: Revise printk(KERN_DEBUG ...) messages
  scsi: mac_scsi: Refactor polling loop
  scsi: mac_scsi: Disallow bus errors during PDMA send
  scsi: NCR5380: Check for phase match during PDMA fixup
  scsi: mac_scsi: Enable scatter/gather by default
  scsi: NCR5380: Initialize buffer for MSG IN and STATUS transfers
  scsi: NCR5380: Handle BSY signal loss during information transfer
    phases
  scsi: NCR5380: Drop redundant member from struct NCR5380_cmd
  scsi: NCR5380: Remove redundant result calculation from
    NCR5380_transfer_pio()
  scsi: NCR5380: Remove obsolete comment
  scsi: NCR5380: Clean up indentation

 drivers/scsi/NCR5380.c   | 233 +++++++++++++++++++--------------------
 drivers/scsi/NCR5380.h   |  20 ++--
 drivers/scsi/mac_scsi.c  | 170 ++++++++++++++--------------
 drivers/scsi/sun3_scsi.c |   2 +-
 4 files changed, 215 insertions(+), 210 deletions(-)

Comments

Martin K. Petersen Aug. 13, 2024, 2:07 a.m. UTC | #1
Finn,

> This series begins with some work on the mac_scsi driver to improve
> compatibility with SCSI2SD v5 devices. Better error handling is needed
> there because the PDMA hardware does not tolerate the write latency
> spikes which SD cards can produce.

Applied to 6.12/scsi-staging, thanks!
Martin K. Petersen Aug. 17, 2024, 1:34 a.m. UTC | #2
On Wed, 07 Aug 2024 13:36:28 +1000, Finn Thain wrote:

> This series begins with some work on the mac_scsi driver to improve
> compatibility with SCSI2SD v5 devices. Better error handling is needed
> there because the PDMA hardware does not tolerate the write latency spikes
> which SD cards can produce.
> 
> A bug is fixed in the 5380 core driver so that scatter/gather can be
> enabled in mac_scsi.
> 
> [...]

Applied to 6.12/scsi-queue, thanks!

[01/11] scsi: mac_scsi: Revise printk(KERN_DEBUG ...) messages
        https://git.kernel.org/mkp/scsi/c/5ec4f820cb97
[02/11] scsi: mac_scsi: Refactor polling loop
        https://git.kernel.org/mkp/scsi/c/5545c3165cbc
[03/11] scsi: mac_scsi: Disallow bus errors during PDMA send
        https://git.kernel.org/mkp/scsi/c/5551bc30e4a6
[04/11] scsi: NCR5380: Check for phase match during PDMA fixup
        https://git.kernel.org/mkp/scsi/c/5768718da941
[05/11] scsi: mac_scsi: Enable scatter/gather by default
        https://git.kernel.org/mkp/scsi/c/2ac6d29716cd
[06/11] scsi: NCR5380: Initialize buffer for MSG IN and STATUS transfers
        https://git.kernel.org/mkp/scsi/c/1c71065df2df
[07/11] scsi: NCR5380: Handle BSY signal loss during information transfer phases
        https://git.kernel.org/mkp/scsi/c/086c4802cf99
[08/11] scsi: NCR5380: Drop redundant member from struct NCR5380_cmd
        https://git.kernel.org/mkp/scsi/c/476f8c82e218
[09/11] scsi: NCR5380: Remove redundant result calculation from NCR5380_transfer_pio()
        https://git.kernel.org/mkp/scsi/c/8663cadefd15
[10/11] scsi: NCR5380: Remove obsolete comment
        https://git.kernel.org/mkp/scsi/c/c331df3d4a8d
[11/11] scsi: NCR5380: Clean up indentation
        https://git.kernel.org/mkp/scsi/c/a8ebca904f8e