diff mbox

[07/14] qla2xxx: Add udev notification to save fw dump for ISP27XX

Message ID 1428606008-14976-8-git-send-email-himanshu.madhani@qlogic.com (mailing list archive)
State New, archived
Headers show

Commit Message

Himanshu Madhani April 9, 2015, 7 p.m. UTC 
Signed-off-by: Giridhar Malavali <giridhar.malavali@qlogic.com>
Signed-off-by: Himanshu Madhani <himanshu.madhani@qlogic.com>
---
 drivers/scsi/qla2xxx/qla_tmpl.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

Comments

Hannes Reinecke April 10, 2015, 6:35 a.m. UTC | #1 
On 04/09/2015 09:00 PM, Himanshu Madhani wrote:
> Signed-off-by: Giridhar Malavali <giridhar.malavali@qlogic.com>
> Signed-off-by: Himanshu Madhani <himanshu.madhani@qlogic.com>
> ---
>  drivers/scsi/qla2xxx/qla_tmpl.c |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/qla2xxx/qla_tmpl.c b/drivers/scsi/qla2xxx/qla_tmpl.c
> index 1437fce..7f67fb2 100644
> --- a/drivers/scsi/qla2xxx/qla_tmpl.c
> +++ b/drivers/scsi/qla2xxx/qla_tmpl.c
> @@ -787,11 +787,12 @@ qla27xx_walk_template(struct scsi_qla_host *vha,
>  	ql_dbg(ql_dbg_misc, vha, 0xd01b,
>  	    "%s: len=%lx\n", __func__, *len);
>  
> -	if (buf)
> +	if (buf) {
>  		ql_log(ql_log_warn, vha, 0xd015,
>  		    "Firmware dump saved to temp buffer (%ld/%p)\n",
>  		    vha->host_no, vha->hw->fw_dump);
> -
> +		qla2x00_post_uevent_work(vha, QLA_UEVENT_CODE_FW_DUMP);
> +	}
>  }
>  
>  static void
> 
Hmm? Isn't that the same as in the previous patch?

Cheers,

Hannes
diff mbox

Patch

diff --git a/drivers/scsi/qla2xxx/qla_tmpl.c b/drivers/scsi/qla2xxx/qla_tmpl.c
index 1437fce..7f67fb2 100644
--- a/drivers/scsi/qla2xxx/qla_tmpl.c
+++ b/drivers/scsi/qla2xxx/qla_tmpl.c
@@ -787,11 +787,12 @@  qla27xx_walk_template(struct scsi_qla_host *vha,
 	ql_dbg(ql_dbg_misc, vha, 0xd01b,
 	    "%s: len=%lx\n", __func__, *len);
 
-	if (buf)
+	if (buf) {
 		ql_log(ql_log_warn, vha, 0xd015,
 		    "Firmware dump saved to temp buffer (%ld/%p)\n",
 		    vha->host_no, vha->hw->fw_dump);
-
+		qla2x00_post_uevent_work(vha, QLA_UEVENT_CODE_FW_DUMP);
+	}
 }
 
 static void