| Message ID | 1429864377-67002-20-git-send-email-hare@suse.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Apr 24, 2015 at 10:32:54AM +0200, Hannes Reinecke wrote:
> Ancient, and pretty much obsolete by now.
And still doesn't address the fixme. You probably should remove the
cmd_per_lun setting entirely.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 04/24/2015 11:41 AM, Christoph Hellwig wrote: > On Fri, Apr 24, 2015 at 10:32:54AM +0200, Hannes Reinecke wrote: >> Ancient, and pretty much obsolete by now. > > And still doesn't address the fixme. You probably should remove the > cmd_per_lun setting entirely. > Okay, will do. Cheers, Hannes
diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c index 424a08d..4f9392d 100644 --- a/drivers/scsi/advansys.c +++ b/drivers/scsi/advansys.c @@ -11213,23 +11213,7 @@ static int advansys_board_found(struct Scsi_Host *shost, unsigned int iop, goto err_free_dma; } - /* - * Following v1.3.89, 'cmd_per_lun' is no longer needed - * and should be set to zero. - * - * But because of a bug introduced in v1.3.89 if the driver is - * compiled as a module and 'cmd_per_lun' is zero, the Mid-Level - * SCSI function 'allocate_device' will panic. To allow the driver - * to work as a module in these kernels set 'cmd_per_lun' to 1. - * - * Note: This is wrong. cmd_per_lun should be set to the depth - * you want on untagged devices always. - #ifdef MODULE - */ shost->cmd_per_lun = 1; -/* #else - shost->cmd_per_lun = 0; -#endif */ /* * Set the maximum number of scatter-gather elements the
Ancient, and pretty much obsolete by now. Signed-off-by: Hannes Reinecke <hare@suse.de> --- drivers/scsi/advansys.c | 16 ---------------- 1 file changed, 16 deletions(-)