From patchwork Tue Apr 28 14:15:11 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Valentin Rothberg X-Patchwork-Id: 6289731 Return-Path: X-Original-To: patchwork-linux-scsi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id A13989F373 for ; Tue, 28 Apr 2015 14:15:41 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id B364E20389 for ; Tue, 28 Apr 2015 14:15:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CED2D20383 for ; Tue, 28 Apr 2015 14:15:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030621AbbD1OPV (ORCPT ); Tue, 28 Apr 2015 10:15:21 -0400 Received: from mail-wg0-f53.google.com ([74.125.82.53]:35020 "EHLO mail-wg0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965659AbbD1OPT (ORCPT ); Tue, 28 Apr 2015 10:15:19 -0400 Received: by wgyo15 with SMTP id o15so153107385wgy.2; Tue, 28 Apr 2015 07:15:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=NF9A5O3gCVb4XTE6MnAJxXH21kVxVIQUPEPS3MKKyM0=; b=fbpt33F0RVvWH3sjaD/r0YsRMOzoWO5zlQI5+iTOb8iN0VXtTM/zd1eJKHOslMDQpL GLcqBb9JaygATMK48ZPUMyOjFCz3sMD20Wz4VzYeCeFqM4y28jtoGeIfTEFgvMKlJrnP cRbdf8JoUfq8KA8tvG4fFN61mpYl1w5+nl96U4lUWYlxY4CkN7WTHMbuyU00JmzPNAn9 L3m63uLUHK4hVlshh+LCgJR9HZ7HYQxmhsDceR6TnLpf7YrxmuiON9e/SKiJ9l7BtihR sbF1r1Hq7WaxyiBD2D/38omzttYn3h9ltTMfpVl2yYmZzy6nXxOHe2aTEMpHkkGaah92 dFsA== X-Received: by 10.194.118.135 with SMTP id km7mr32194890wjb.125.1430230517454; Tue, 28 Apr 2015 07:15:17 -0700 (PDT) Received: from dou.rsr.lip6.fr (hp-valentin.rsr.lip6.fr. [132.227.64.74]) by mx.google.com with ESMTPSA id vz8sm13550331wjc.27.2015.04.28.07.15.16 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 28 Apr 2015 07:15:16 -0700 (PDT) From: Valentin Rothberg To: JBottomley@odin.com, linux@arm.linux.org.uk, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Valentin Rothberg Subject: [PATCH] drivers/scsi/arm/acornscsi.c: rename CONFIG_ACORNSCSI_CONSTANTS Date: Tue, 28 Apr 2015 16:15:11 +0200 Message-Id: <1430230511-10869-1-git-send-email-valentinrothberg@gmail.com> X-Mailer: git-send-email 2.1.4 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP CONFIG_ACORNSCSI_CONSTANTS is a file local CPP identifier and thereby violates the naming convention of Kconfig options in Make and CPP syntax; only Kconfig options should carry the 'CONFIG_' prefix. This patch removes the 'CONFIG_' prefix to apply to this convention and to make static analysis tools happy. Signed-off-by: Valentin Rothberg Acked-by: Russell King --- I detected this issue with ./scripts/checkkconfigsymbols.py --- drivers/scsi/arm/acornscsi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/arm/acornscsi.c b/drivers/scsi/arm/acornscsi.c index deaaf84989cd..ce764c3ed99c 100644 --- a/drivers/scsi/arm/acornscsi.c +++ b/drivers/scsi/arm/acornscsi.c @@ -96,7 +96,7 @@ * Define this if you want to have verbose explanation of SCSI * status/messages. */ -#undef CONFIG_ACORNSCSI_CONSTANTS +#undef ACORNSCSI_CONSTANTS /* * Define this if you want to use the on board DMAC [don't remove this option] * If not set, then use PIO mode (not currently supported). @@ -399,7 +399,7 @@ void acornscsi_resetcard(AS_Host *host) /*============================================================================================= * Utility routines (eg. debug) */ -#ifdef CONFIG_ACORNSCSI_CONSTANTS +#ifdef ACORNSCSI_CONSTANTS static char *acornscsi_interrupttype[] = { "rst", "suc", "p/a", "3", "term", "5", "6", "7", @@ -477,7 +477,7 @@ void print_scsi_status(unsigned int ssr) static void print_sbic_status(int asr, int ssr, int cmdphase) { -#ifdef CONFIG_ACORNSCSI_CONSTANTS +#ifdef ACORNSCSI_CONSTANTS printk("sbic: %c%c%c%c%c%c ", asr & ASR_INT ? 'I' : 'i', asr & ASR_LCI ? 'L' : 'l',