diff mbox

scsi: aha152x: Remove residual AHA152X_DEBUG references

Message ID 1430250952-19889-1-git-send-email-emilne@redhat.com (mailing list archive)
State New, archived
Headers show

Commit Message

Ewan Milne April 28, 2015, 7:55 p.m. UTC 
From: "Ewan D. Milne" <emilne@redhat.com>

Commit f75ae8ed.. ("aha152x: debug output update and whitespace cleanup")
removed all AHA152X_DEBUG code from aha152x.c, so the build option no longer
does anything useful.

Signed-off-by: Ewan D. Milne <emilne@redhat.com>
---
 Documentation/scsi/aha152x.txt |  3 ---
 drivers/scsi/aha152x.h         | 22 ----------------------
 2 files changed, 25 deletions(-)

Comments

Christoph Hellwig May 11, 2015, 9:08 a.m. UTC | #1 
On Tue, Apr 28, 2015 at 03:55:52PM -0400, Ewan D. Milne wrote:
> From: "Ewan D. Milne" <emilne@redhat.com>
> 
> Commit f75ae8ed.. ("aha152x: debug output update and whitespace cleanup")
> removed all AHA152X_DEBUG code from aha152x.c, so the build option no longer
> does anything useful.
> 
> Signed-off-by: Ewan D. Milne <emilne@redhat.com>

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/Documentation/scsi/aha152x.txt b/Documentation/scsi/aha152x.txt
index 9484873..248dde1 100644
--- a/Documentation/scsi/aha152x.txt
+++ b/Documentation/scsi/aha152x.txt
@@ -40,9 +40,6 @@  COMPILE TIME CONFIGURATION (go into AHA152X in drivers/scsi/Makefile):
 -DSETUP1="{ IOPORT, IRQ, SCSI_ID, RECONNECT, PARITY, SYNCHRONOUS, DELAY, EXT_TRANS }"
  override for the second controller
 
--DAHA152X_DEBUG
- enable debugging output
-
 -DAHA152X_STAT
  enable some statistics
 
diff --git a/drivers/scsi/aha152x.h b/drivers/scsi/aha152x.h
index ac4bfa438b..1addbe6 100644
--- a/drivers/scsi/aha152x.h
+++ b/drivers/scsi/aha152x.h
@@ -294,25 +294,6 @@  typedef union {
 
 #define SETRATE(RATE)		SETPORT(SCSIRATE,(RATE) & 0x7f)
 
-#if defined(AHA152X_DEBUG)
-enum {
-  debug_procinfo  = 0x0001,
-  debug_queue     = 0x0002,
-  debug_locking   = 0x0004,
-  debug_intr      = 0x0008,
-  debug_selection = 0x0010,
-  debug_msgo      = 0x0020,
-  debug_msgi      = 0x0040,
-  debug_status    = 0x0080,
-  debug_cmd       = 0x0100,
-  debug_datai     = 0x0200,
-  debug_datao     = 0x0400,
-  debug_eh	  = 0x0800,
-  debug_done      = 0x1000,
-  debug_phases    = 0x2000,
-};
-#endif
-
 /* for the pcmcia stub */
 struct aha152x_setup {
 	int io_port;
@@ -324,9 +305,6 @@  struct aha152x_setup {
 	int delay;
 	int ext_trans;
 	int tc1550;
-#if defined(AHA152X_DEBUG)
-	int debug;
-#endif
 	char *conf;
 };