| Message ID | 1434102153-38581-19-git-send-email-Sreekanth.Reddy@avagotech.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Jun 12, 2015 at 03:12:30PM +0530, Sreekanth Reddy wrote: > Added dma_mapping_error() API after mapping an address with dma_map_single() API. > Otherwise when CONFIG_DMA_API_DEBUG is enabled in the kernel, then it complains > about mpt3sas driver not calling dma_mapping_error after mapping an address with > dma_map_single > > Signed-off-by: Sreekanth Reddy <Sreekanth.Reddy@avagotech.com> > --- > drivers/scsi/mpt3sas/mpt3sas_transport.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/mpt3sas/mpt3sas_transport.c b/drivers/scsi/mpt3sas/mpt3sas_transport.c > index 7a7aa68..70fd019 100644 > --- a/drivers/scsi/mpt3sas/mpt3sas_transport.c > +++ b/drivers/scsi/mpt3sas/mpt3sas_transport.c > @@ -1964,7 +1964,7 @@ _transport_smp_handler(struct Scsi_Host *shost, struct sas_rphy *rphy, > } else { > dma_addr_out = pci_map_single(ioc->pdev, bio_data(req->bio), > blk_rq_bytes(req), PCI_DMA_BIDIRECTIONAL); > - if (!dma_addr_out) { > + if (pci_dma_mapping_error(ioc->pdev, dma_addr_out)) { > pr_info(MPT3SAS_FMT "%s(): DMA Addr out = NULL\n", > ioc->name, __func__); > rc = -ENOMEM; > @@ -1986,7 +1986,7 @@ _transport_smp_handler(struct Scsi_Host *shost, struct sas_rphy *rphy, > } else { > dma_addr_in = pci_map_single(ioc->pdev, bio_data(rsp->bio), > blk_rq_bytes(rsp), PCI_DMA_BIDIRECTIONAL); > - if (!dma_addr_in) { > + if (pci_dma_mapping_error(ioc->pdev, dma_addr_in)) { > pr_info(MPT3SAS_FMT "%s(): DMA Addr in = NULL\n", > ioc->name, __func__); > rc = -ENOMEM; > -- > 2.0.2 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
>>>>> Sreekanth Reddy <sreekanth.reddy@avagotech.com> writes: > Added dma_mapping_error() API after mapping an address with > dma_map_single() API. Otherwise when CONFIG_DMA_API_DEBUG is enabled > in the kernel, then it complains about mpt3sas driver not calling > dma_mapping_error after mapping an address with dma_map_single Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
diff --git a/drivers/scsi/mpt3sas/mpt3sas_transport.c b/drivers/scsi/mpt3sas/mpt3sas_transport.c index 7a7aa68..70fd019 100644 --- a/drivers/scsi/mpt3sas/mpt3sas_transport.c +++ b/drivers/scsi/mpt3sas/mpt3sas_transport.c @@ -1964,7 +1964,7 @@ _transport_smp_handler(struct Scsi_Host *shost, struct sas_rphy *rphy, } else { dma_addr_out = pci_map_single(ioc->pdev, bio_data(req->bio), blk_rq_bytes(req), PCI_DMA_BIDIRECTIONAL); - if (!dma_addr_out) { + if (pci_dma_mapping_error(ioc->pdev, dma_addr_out)) { pr_info(MPT3SAS_FMT "%s(): DMA Addr out = NULL\n", ioc->name, __func__); rc = -ENOMEM; @@ -1986,7 +1986,7 @@ _transport_smp_handler(struct Scsi_Host *shost, struct sas_rphy *rphy, } else { dma_addr_in = pci_map_single(ioc->pdev, bio_data(rsp->bio), blk_rq_bytes(rsp), PCI_DMA_BIDIRECTIONAL); - if (!dma_addr_in) { + if (pci_dma_mapping_error(ioc->pdev, dma_addr_in)) { pr_info(MPT3SAS_FMT "%s(): DMA Addr in = NULL\n", ioc->name, __func__); rc = -ENOMEM;
Added dma_mapping_error() API after mapping an address with dma_map_single() API. Otherwise when CONFIG_DMA_API_DEBUG is enabled in the kernel, then it complains about mpt3sas driver not calling dma_mapping_error after mapping an address with dma_map_single Signed-off-by: Sreekanth Reddy <Sreekanth.Reddy@avagotech.com> --- drivers/scsi/mpt3sas/mpt3sas_transport.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)