diff mbox

[1/1] scsi/snic: fixing the error print

Message ID 1435225936-10250-1-git-send-email-maninder1.s@samsung.com (mailing list archive)
State New, archived
Headers show

Commit Message

Maninder Singh June 25, 2015, 9:52 a.m. UTC 
Currently SNIC_HOST_ERR is called in both cases
whether snic_disc_start returns zero or non-zero.

From the code it looks like it has to print only if
snic_disc_start return non-zero value, So calling
SNIC_HOST_ERR only for non-zero return from snic_disc_start.

Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
Reviewed-by: Rohit Thapliyal <r.thapliyal@samsung.com>
---
 drivers/scsi/snic/snic_disc.c |    9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

Comments

Narsimhulu Musini June 25, 2015, 10:23 a.m. UTC | #1 
On 25/06/15 3:22 pm, "Maninder Singh" <maninder1.s@samsung.com> wrote:

>Currently SNIC_HOST_ERR is called in both cases
>whether snic_disc_start returns zero or non-zero.
>
>From the code it looks like it has to print only if
>snic_disc_start return non-zero value, So calling
>SNIC_HOST_ERR only for non-zero return from snic_disc_start.
>
>Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
>Reviewed-by: Rohit Thapliyal <r.thapliyal@samsung.com>

Acked-by: Narsimhulu Musini <nmusini@cisco.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/scsi/snic/snic_disc.c b/drivers/scsi/snic/snic_disc.c
index 5f63217..8c29d5e 100644
--- a/drivers/scsi/snic/snic_disc.c
+++ b/drivers/scsi/snic/snic_disc.c
@@ -514,12 +514,9 @@  snic_handle_disc(struct work_struct *work)
 
 	ret = snic_disc_start(snic);
 	if (ret)
-		goto disc_err;
-
-disc_err:
-	SNIC_HOST_ERR(snic->shost,
-		      "disc_work: Discovery Failed w/ err = %d\n",
-		      ret);
+		SNIC_HOST_ERR(snic->shost,
+			      "disc_work: Discovery Failed w/ err = %d\n",
+			      ret);
 } /* end of snic_disc_work */
 
 /*