From patchwork Thu Jun 25 09:55:05 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maninder Singh X-Patchwork-Id: 6673861 Return-Path: X-Original-To: patchwork-linux-scsi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id BE119C05AC for ; Thu, 25 Jun 2015 10:00:25 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id DAB4C2039D for ; Thu, 25 Jun 2015 10:00:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CE00620386 for ; Thu, 25 Jun 2015 10:00:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750988AbbFYJ5M (ORCPT ); Thu, 25 Jun 2015 05:57:12 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:54829 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752515AbbFYJ5G (ORCPT ); Thu, 25 Jun 2015 05:57:06 -0400 Received: from epcpsbgr1.samsung.com (u141.gpu120.samsung.co.kr [203.254.230.141]) by mailout3.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NQH029OCVN5AJD0@mailout3.samsung.com>; Thu, 25 Jun 2015 18:57:05 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [172.20.52.125]) by epcpsbgr1.samsung.com (EPCPMTA) with SMTP id 55.B1.29324.070DB855; Thu, 25 Jun 2015 18:57:04 +0900 (KST) X-AuditID: cbfee68d-f79106d00000728c-86-558bd070c4a7 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id C5.4A.25346.070DB855; Thu, 25 Jun 2015 18:57:04 +0900 (KST) Received: from localhost.localdomain ([107.108.92.210]) by mmp1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0NQH00N39VM24890@mmp1.samsung.com>; Thu, 25 Jun 2015 18:57:04 +0900 (KST) From: Maninder Singh To: JBottomley@odin.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: pankaj.m@samsung.com, Maninder Singh Subject: [PATCH 1/1] scsi: remove check around pci_dev_put Date: Thu, 25 Jun 2015 15:25:05 +0530 Message-id: <1435226105-39462-1-git-send-email-maninder1.s@samsung.com> X-Mailer: git-send-email 1.7.9.5 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrNLMWRmVeSWpSXmKPExsWyRsSkVrfgQneowaMmG4v/62+zWFzeNYfN ovv6DjaLw/PbWCzuvdnK5MDqcfjHD2aPvi2rGD0+b5ILYI7isklJzcksSy3St0vgypg+cT5b wU+WittfnzM1MLazdDFyckgImEgcvLuRHcIWk7hwbz1bFyMXh5DAUkaJHW+uMHYxcoAVXe7J gIgvYpT42LOJCcL5ySgx+c82NpBuNgE9iVW79rCANIgIBEssnxsOYjILOElM/6oHYgoLWEms uqMFUswioCpx5PthZhCbV8BdonHhQVaITQoScybZgAyXELjPJnH06gcWiHoBiW+TD7FA1MhK bDrADHGxpMTBFTdYJjAKLmBkWMUomlqQXFCclF5kqFecmFtcmpeul5yfu4kRGIan/z3r3cF4 +4D1IUYBDkYlHl6f892hQqyJZcWVuYcYTYE2TGSWEk3OBwZ7Xkm8obGZkYWpiamxkbmlmZI4 r6LUz2AhgfTEktTs1NSC1KL4otKc1OJDjEwcnFINjLI/rnecWCJUZHbssq7DxULR1UdWhKXk RzSwLomTVJqXuyngo1rrirTpt3SlbA/btM75UzPjYvQcycI5avNmhueoBP8Wz8jvXWcjZMXz yND9mE2M2E7FY/HcEv1SO3vWtt8xebYlfOW3o7UcvVOPK/pdFcqT2PE3eYfzCblyT4+ZUUvt LgRfU2Ipzkg01GIuKk4EAJfkDjQ+AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrKLMWRmVeSWpSXmKPExsVy+t9jAd2CC92hBj+2mVj8X3+bxeLyrjls Ft3Xd7BZHJ7fxmJx781WJgdWj8M/fjB79G1ZxejxeZNcAHNUA6NNRmpiSmqRQmpecn5KZl66 rZJ3cLxzvKmZgaGuoaWFuZJCXmJuqq2Si0+ArltmDtBOJYWyxJxSoFBAYnGxkr4dpgmhIW66 FjCNEbq+IUFwPUYGaCBhDWPG9Inz2Qp+slTc/vqcqYGxnaWLkYNDQsBE4nJPRhcjJ5ApJnHh 3nq2LkYuDiGBRYwSH3s2MUE4PxklJv/ZxgZSxSagJ7Fq1x6wZhGBYInlc8NBTGYBJ4npX/VA TGEBK4lVd7RAilkEVCWOfD/MDGLzCrhLNC48yAqxVUFiziSbCYzcCxgZVjGKphYkFxQnpeca 6hUn5haX5qXrJefnbmIEB/kzqR2MKxssDjEKcDAq8fDuPNAdKsSaWFZcmXuIUYKDWUmEt+sg UIg3JbGyKrUoP76oNCe1+BCjKdDyicxSosn5wAjMK4k3NDYxNzU2tTSxMDGzVBLnPZnvEyok kJ5YkpqdmlqQWgTTx8TBKdXAOGFBd9tZzf2dAlMcfazTbXZMU/A+ynBylVp6+WthR73bheJi csuLGPwDN5TF1wZm8XPXvf2f33mbmc9enfWmadnzlYL2f72+vVX1UmPNaQieuNO9Z8Ea96DH chlbD9me4t6rM+uv//n8lc5Nf/sPWBb6LNYLulV3ydo96f2e/Wc68tku5DoqsRRnJBpqMRcV JwIAaV8/nIgCAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP pci_dev_put checks for NULL Pointer itself. Signed-off-by: Maninder Singh --- drivers/scsi/eata_pio.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/scsi/eata_pio.c b/drivers/scsi/eata_pio.c index ca8003f..481ecac 100644 --- a/drivers/scsi/eata_pio.c +++ b/drivers/scsi/eata_pio.c @@ -122,8 +122,7 @@ static int eata_pio_release(struct Scsi_Host *sh) release_region(sh->io_port, sh->n_io_port); } /* At this point the PCI reference can go */ - if (hd->pdev) - pci_dev_put(hd->pdev); + pci_dev_put(hd->pdev); return 1; }