| Message ID | 1435910355-30070-1-git-send-email-maninder1.s@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
diff --git a/drivers/scsi/bnx2i/bnx2i_iscsi.c b/drivers/scsi/bnx2i/bnx2i_iscsi.c index 7289437..cbec2ea 100644 --- a/drivers/scsi/bnx2i/bnx2i_iscsi.c +++ b/drivers/scsi/bnx2i/bnx2i_iscsi.c @@ -239,7 +239,7 @@ static int bnx2i_bind_conn_to_iscsi_cid(struct bnx2i_hba *hba, struct bnx2i_conn *bnx2i_conn, u32 iscsi_cid) { - if (hba && hba->cid_que.conn_cid_tbl[iscsi_cid]) { + if (hba->cid_que.conn_cid_tbl[iscsi_cid]) { iscsi_conn_printk(KERN_ALERT, bnx2i_conn->cls_conn->dd_data, "conn bind - entry #%d not free\n", iscsi_cid); return -EBUSY;
Removing static analysis error:- (error) Possible null pointer dereference: hba hba->cid_que.conn_cid_tbl[iscsi_cid] = bnx2i_conn; ^^^^ Validation of hba is not required in if check, because validation is done before entrying to this function and error comes because after this check hba is dereferenced without validation. Signed-off-by: Maninder Singh <maninder1.s@samsung.com> --- drivers/scsi/bnx2i/bnx2i_iscsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)