| Message ID | 1436797653-9822-1-git-send-email-jordan_hargrave@dell.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 07/13/2015 04:27 PM, Jordan Hargrave wrote: > Dell Server backplanes can report bay/enclosure IDs without an > expander present. This patch allows the bay/enclosure IDs to be > propagaged to sysfs.we > > Signed-off-by: Jordan Hargrave <jordan_hargrave@dell.com> > --- > drivers/scsi/scsi_transport_sas.c | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/drivers/scsi/scsi_transport_sas.c b/drivers/scsi/scsi_transport_sas.c > index 9a05819..30d26e3 100644 > --- a/drivers/scsi/scsi_transport_sas.c > +++ b/drivers/scsi/scsi_transport_sas.c > @@ -1222,13 +1222,6 @@ show_sas_rphy_enclosure_identifier(struct device *dev, > u64 identifier; > int error; > > - /* > - * Only devices behind an expander are supported, because the > - * enclosure identifier is a SMP feature. > - */ > - if (scsi_is_sas_phy_local(phy)) > - return -EINVAL; > - > error = i->f->get_enclosure_identifier(rphy, &identifier); > if (error) > return error; > @@ -1248,9 +1241,6 @@ show_sas_rphy_bay_identifier(struct device *dev, > struct sas_internal *i = to_sas_internal(shost->transportt); > int val; > > - if (scsi_is_sas_phy_local(phy)) > - return -EINVAL; > - > val = i->f->get_bay_identifier(rphy); > if (val < 0) > return val; > Reviewed-by: Hannes Reinecke <hare@suse.com> Cheers, Hannes
On Tue, Jul 14, 2015 at 6:23 AM, Hannes Reinecke <hare@suse.de> wrote: > On 07/13/2015 04:27 PM, Jordan Hargrave wrote: >> Dell Server backplanes can report bay/enclosure IDs without an >> expander present. This patch allows the bay/enclosure IDs to be >> propagaged to sysfs.we >> >> Signed-off-by: Jordan Hargrave <jordan_hargrave@dell.com> >> --- >> drivers/scsi/scsi_transport_sas.c | 10 ---------- >> 1 file changed, 10 deletions(-) >> >> diff --git a/drivers/scsi/scsi_transport_sas.c b/drivers/scsi/scsi_transport_sas.c >> index 9a05819..30d26e3 100644 >> --- a/drivers/scsi/scsi_transport_sas.c >> +++ b/drivers/scsi/scsi_transport_sas.c >> @@ -1222,13 +1222,6 @@ show_sas_rphy_enclosure_identifier(struct device *dev, >> u64 identifier; >> int error; >> >> - /* >> - * Only devices behind an expander are supported, because the >> - * enclosure identifier is a SMP feature. >> - */ >> - if (scsi_is_sas_phy_local(phy)) >> - return -EINVAL; >> - >> error = i->f->get_enclosure_identifier(rphy, &identifier); >> if (error) >> return error; >> @@ -1248,9 +1241,6 @@ show_sas_rphy_bay_identifier(struct device *dev, >> struct sas_internal *i = to_sas_internal(shost->transportt); >> int val; >> >> - if (scsi_is_sas_phy_local(phy)) >> - return -EINVAL; >> - >> val = i->f->get_bay_identifier(rphy); >> if (val < 0) >> return val; >> > Reviewed-by: Hannes Reinecke <hare@suse.com> > > Cheers, > > Hannes > -- > Dr. Hannes Reinecke zSeries & Storage > hare@suse.de +49 911 74053 688 > SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg > GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton > HRB 21284 (AG Nürnberg) Any updates on getting this included? -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/scsi/scsi_transport_sas.c b/drivers/scsi/scsi_transport_sas.c index 9a05819..30d26e3 100644 --- a/drivers/scsi/scsi_transport_sas.c +++ b/drivers/scsi/scsi_transport_sas.c @@ -1222,13 +1222,6 @@ show_sas_rphy_enclosure_identifier(struct device *dev, u64 identifier; int error; - /* - * Only devices behind an expander are supported, because the - * enclosure identifier is a SMP feature. - */ - if (scsi_is_sas_phy_local(phy)) - return -EINVAL; - error = i->f->get_enclosure_identifier(rphy, &identifier); if (error) return error; @@ -1248,9 +1241,6 @@ show_sas_rphy_bay_identifier(struct device *dev, struct sas_internal *i = to_sas_internal(shost->transportt); int val; - if (scsi_is_sas_phy_local(phy)) - return -EINVAL; - val = i->f->get_bay_identifier(rphy); if (val < 0) return val;
Dell Server backplanes can report bay/enclosure IDs without an expander present. This patch allows the bay/enclosure IDs to be propagaged to sysfs.we Signed-off-by: Jordan Hargrave <jordan_hargrave@dell.com> --- drivers/scsi/scsi_transport_sas.c | 10 ---------- 1 file changed, 10 deletions(-)