From patchwork Mon Aug 3 22:35:57 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomer Barletz X-Patchwork-Id: 6933401 Return-Path: X-Original-To: patchwork-linux-scsi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 57B8D9F373 for ; Mon, 3 Aug 2015 22:36:39 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 7B85C2063A for ; Mon, 3 Aug 2015 22:36:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A5CF520638 for ; Mon, 3 Aug 2015 22:36:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754581AbbHCWgX (ORCPT ); Mon, 3 Aug 2015 18:36:23 -0400 Received: from mail-qg0-f51.google.com ([209.85.192.51]:33335 "EHLO mail-qg0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751538AbbHCWgW (ORCPT ); Mon, 3 Aug 2015 18:36:22 -0400 Received: by qged69 with SMTP id d69so99556201qge.0; Mon, 03 Aug 2015 15:36:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=WYRdmHWvhmwt+LeLaEv2hWcHZaYGqnivLvjhir5zM0k=; b=HnhR8D6i+uVabJI8PkLhOXjNo7PboP1Xs+egUk/JvIqVoYhoDsokgZRp1PygIripLg i+SLt+ZJ7mX8lrPhIbTchyf9Fzq4EF9zt69wGEG6jv8hsGLBJvbNTGN9ozXd+QN+CDuk frWjvTvMOeiPfl1LF5ZoNV6p7rmuU1pT/fZiqzmbAZ0xAmM1xDv66zzNqhm5pHRVuyDP SdCE9xlhmy9K10t291qJZXvAg8Q1X5VVMw3VXtZ+DlXmShgqWo7NIuxR+fRlX75nEeHw 0wqUTIxAYXsjxc3PkPv3/dZPNd4nCdeYT5Fg2Gh+EygSCjKdMoa01ClspjLIORdN6PPG ibZQ== X-Received: by 10.140.150.143 with SMTP id 137mr1116681qhw.73.1438641381945; Mon, 03 Aug 2015 15:36:21 -0700 (PDT) Received: from tbarletz-t440.arrs.arrisi.com (kirkland-vpn.arrisi.com. [134.242.100.5]) by smtp.gmail.com with ESMTPSA id 184sm7558690qhb.20.2015.08.03.15.36.20 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Aug 2015 15:36:21 -0700 (PDT) From: Tomer Barletz To: jayamohan.kallickal@avagotech.com, minh.tran@avagotech.com, sony.john-n@avagotech.com, JBottomley@odin.com Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Tomer Barletz Subject: [PATCH] scsi/be2iscsi: Fix logical-not-parentheses compilation warning Date: Mon, 3 Aug 2015 15:35:57 -0700 Message-Id: <1438641357-25588-1-git-send-email-barletz@gmail.com> X-Mailer: git-send-email 2.4.3 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This fixes the following warning seen with GCC v5.1: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]. Signed-off-by: Tomer Barletz Reviewed-by: Johannes Thumshirn --- drivers/scsi/be2iscsi/be_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c index 7a6dbfb..ff8d40e 100644 --- a/drivers/scsi/be2iscsi/be_main.c +++ b/drivers/scsi/be2iscsi/be_main.c @@ -3184,7 +3184,7 @@ be_sgl_create_contiguous(void *virtual_address, { WARN_ON(!virtual_address); WARN_ON(!physical_address); - WARN_ON(!length > 0); + WARN_ON(0 == length); WARN_ON(!sgl); sgl->va = virtual_address;