| Message ID | 1445287000-1370-1-git-send-email-luisbg@osg.samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, 2015-10-19 at 21:36 +0100, Luis de Bethencourt wrote: > Fix a smatch warning: > drivers/scsi/mvsas/mv_sas.c:740 mvs_task_prep() warn: curly braces > intended? > > The code is correct, the indention is misleading. When the device is > not > ready we want to return SAS_PHY_DOWN. But current indentation makes > it > look like we only do so in the else branch of if (mvi_dev). > > Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com> > --- > > Hi, > > The aim of this patch is to improve code readability, and at the same > time > silence the smatch warning. > > Thanks for the review, > Luis > > drivers/scsi/mvsas/mv_sas.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/mvsas/mv_sas.c > b/drivers/scsi/mvsas/mv_sas.c > index 454536c..b1c5dec 100644 > --- a/drivers/scsi/mvsas/mv_sas.c > +++ b/drivers/scsi/mvsas/mv_sas.c > @@ -737,8 +737,8 @@ static int mvs_task_prep(struct sas_task *task, > struct mvs_info *mvi, int is_tmf > mv_dprintk("device %016llx not ready.\n", > SAS_ADDR(dev->sas_addr)); > > - rc = SAS_PHY_DOWN; > - return rc; > + rc = SAS_PHY_DOWN; > + return rc; > } > tei.port = dev->port->lldd_port; > if (tei.port && !tei.port->port_attached && !tmf) { Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/scsi/mvsas/mv_sas.c b/drivers/scsi/mvsas/mv_sas.c index 454536c..b1c5dec 100644 --- a/drivers/scsi/mvsas/mv_sas.c +++ b/drivers/scsi/mvsas/mv_sas.c @@ -737,8 +737,8 @@ static int mvs_task_prep(struct sas_task *task, struct mvs_info *mvi, int is_tmf mv_dprintk("device %016llx not ready.\n", SAS_ADDR(dev->sas_addr)); - rc = SAS_PHY_DOWN; - return rc; + rc = SAS_PHY_DOWN; + return rc; } tei.port = dev->port->lldd_port; if (tei.port && !tei.port->port_attached && !tmf) {
Fix a smatch warning: drivers/scsi/mvsas/mv_sas.c:740 mvs_task_prep() warn: curly braces intended? The code is correct, the indention is misleading. When the device is not ready we want to return SAS_PHY_DOWN. But current indentation makes it look like we only do so in the else branch of if (mvi_dev). Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com> --- Hi, The aim of this patch is to improve code readability, and at the same time silence the smatch warning. Thanks for the review, Luis drivers/scsi/mvsas/mv_sas.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)