[scsi:fixes,16/18] warning: (SCSI_MPT2SAS) selects SCSI_MPT3SAS which has unmet direct dependencies (SCSI_LOWLEVEL && ..)

Commit Message

James Bottomley Dec. 2, 2015, 9:36 p.m. UTC

On Thu, 2015-12-03 at 05:02 +0800, kbuild test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git fixes
> head:   136dc13bf2988d987682e60558bb9b9873215f29
> commit: b840c3627b6f4f856b333a14a72f8ed86da2f86c [16/18] mpt3sas: Add dummy Kconfig option for backwards compatibility
> config: mips-allyesconfig (attached as .config)
> reproduce:
>         wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git checkout b840c3627b6f4f856b333a14a72f8ed86da2f86c
>         # save the attached .config to linux build tree
>         make.cross ARCH=mips 
> 
> All warnings (new ones prefixed by >>):
> 
> warning: (SCSI_MPT2SAS) selects SCSI_MPT3SAS which has unmet direct
> dependencies (SCSI_LOWLEVEL && PCI && SCSI)

That's unfortunate.  The problem is that select and depend don't
interact because Kconfig doesn't have a SAT solver, so depend picks up
dependencies and select does onward selects, but select doesn't pick up
dependencies.  To fix this, we need to add the correct dependencies to
the MPT2SAS option like this.

James

---



--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Martin K. Petersen Dec. 2, 2015, 9:56 p.m. UTC | #1

>>>>> "James" == James Bottomley <[e-mail]> writes:

>> warning: (SCSI_MPT2SAS) selects SCSI_MPT3SAS which has unmet direct
>> dependencies (SCSI_LOWLEVEL && PCI && SCSI)

James> That's unfortunate.  The problem is that select and depend don't
James> interact because Kconfig doesn't have a SAT solver, so depend
James> picks up dependencies and select does onward selects, but select
James> doesn't pick up dependencies.  To fix this, we need to add the
James> correct dependencies to the MPT2SAS option like this.

Yeah, I was wondering about whether it would make sense to add the
dependency when I did the patch. I did test after unselecting SCSI but
didn't get any warnings. In retrospect I probably had something else
configured that pulled it back in.

In any case: Patch looks good to me.

I also asked Fengguang to add scsi.git to the kbuild test robot. It
looks like it's only been testing the SCSI branches I kept in my regular
git tree and they were a bit behind scsi.git.

Patch

diff --git a/drivers/scsi/mpt3sas/Kconfig b/drivers/scsi/mpt3sas/Kconfig
index 25dc38f..b736dbc 100644
--- a/drivers/scsi/mpt3sas/Kconfig
+++ b/drivers/scsi/mpt3sas/Kconfig
@@ -76,6 +76,7 @@  config SCSI_MPT2SAS
 	tristate "Legacy MPT2SAS config option"
 	default n
 	select SCSI_MPT3SAS
+	depends on PCI && SCSI
 	---help---
 	Dummy config option for backwards compatiblity: configure the MPT3SAS
 	driver instead.