| Message ID | 1449792860-15447-1-git-send-email-kys@microsoft.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Dec 10, 2015 at 04:14:17PM -0800, K. Y. Srinivasan wrote: > The hv_fc_wwn_packet is exchanged over vmbus. Make the definition in Linux match > the Window's definition. > > Signed-off-by: K. Y. Srinivasan <kys@microsoft.com> > Reviewed-by: Long Li <longli@microsoft.com> > Tested-by: Alex Ng <alexng@microsoft.com> > --- > drivers/scsi/storvsc_drv.c | 5 ++--- > 1 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c > index c41f674..00bb4bd 100644 > --- a/drivers/scsi/storvsc_drv.c > +++ b/drivers/scsi/storvsc_drv.c > @@ -92,9 +92,8 @@ enum vstor_packet_operation { > */ > > struct hv_fc_wwn_packet { > - bool primary_active; > - u8 reserved1; > - u8 reserved2; > + u8 primary_active; > + u8 reserved1[3]; > u8 primary_port_wwn[8]; > u8 primary_node_wwn[8]; > u8 secondary_port_wwn[8]; > -- > 1.7.4.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html Should this go through stable as well? If yes: Fixes: 8b612fa23 '[SCSI] storvsc: Update the storage protocol to win8 level' Cc: stable@vger.kernel.org # v3.11+ Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
> -----Original Message----- > From: Johannes Thumshirn [mailto:jthumshirn@suse.de] > Sent: Friday, December 11, 2015 12:48 AM > To: KY Srinivasan <kys@microsoft.com> > Cc: gregkh@linuxfoundation.org; linux-kernel@vger.kernel.org; > devel@linuxdriverproject.org; ohering@suse.com; > jbottomley@parallels.com; hch@infradead.org; linux-scsi@vger.kernel.org; > apw@canonical.com; vkuznets@redhat.com; jasowang@redhat.com; > martin.petersen@oracle.com > Subject: Re: [PATCH 1/4] scsi: storvsc: Fix a bug in the layout of the > hv_fc_wwn_packet > > On Thu, Dec 10, 2015 at 04:14:17PM -0800, K. Y. Srinivasan wrote: > > The hv_fc_wwn_packet is exchanged over vmbus. Make the definition in > Linux match > > the Window's definition. > > > > Signed-off-by: K. Y. Srinivasan <kys@microsoft.com> > > Reviewed-by: Long Li <longli@microsoft.com> > > Tested-by: Alex Ng <alexng@microsoft.com> > > --- > > drivers/scsi/storvsc_drv.c | 5 ++--- > > 1 files changed, 2 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c > > index c41f674..00bb4bd 100644 > > --- a/drivers/scsi/storvsc_drv.c > > +++ b/drivers/scsi/storvsc_drv.c > > @@ -92,9 +92,8 @@ enum vstor_packet_operation { > > */ > > > > struct hv_fc_wwn_packet { > > - bool primary_active; > > - u8 reserved1; > > - u8 reserved2; > > + u8 primary_active; > > + u8 reserved1[3]; > > u8 primary_port_wwn[8]; > > u8 primary_node_wwn[8]; > > u8 secondary_port_wwn[8]; > > -- > > 1.7.4.1 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at > https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fvger.ker > nel.org%2fmajordomo- > info.html&data=01%7c01%7ckys%40microsoft.com%7cb6c3be0d1b474ac1374 > 908d30207c170%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=7hfMcn > qW32KiJgr7JkXsC4P0CnnQvAearwu7LzyWaqM%3d > > Should this go through stable as well? > If yes: > Fixes: 8b612fa23 '[SCSI] storvsc: Update the storage protocol to win8 level' > Cc: stable@vger.kernel.org # v3.11+ This is the first time we are using this data structure and so I don't think we need to port it back to stable. Regards, K. Y > Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de> > > -- > Johannes Thumshirn Storage > jthumshirn@suse.de +49 911 74053 689 > SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg > GF: Felix Imendörffer, Jane Smithard, Graham Norton > HRB 21284 (AG Nürnberg) > Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850 -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c index c41f674..00bb4bd 100644 --- a/drivers/scsi/storvsc_drv.c +++ b/drivers/scsi/storvsc_drv.c @@ -92,9 +92,8 @@ enum vstor_packet_operation { */ struct hv_fc_wwn_packet { - bool primary_active; - u8 reserved1; - u8 reserved2; + u8 primary_active; + u8 reserved1[3]; u8 primary_port_wwn[8]; u8 primary_node_wwn[8]; u8 secondary_port_wwn[8];