| Message ID | 1459516223-32106-4-git-send-email-chad.dupuis@qlogic.com (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
On 2016-04-01 15:10, Chad Dupuis wrote: > Signed-off-by: Chad Dupuis <chad.dupuis@qlogic.com> > --- > drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c > b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c > index d95eee6..60423cf 100644 > --- a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c > +++ b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c > @@ -2044,6 +2044,8 @@ static void bnx2fc_ulp_init(struct cnic_dev *dev) > return; > } > > + pr_err(PFX "FCoE initialized for %s.\n", dev->netdev->name); > + > /* Add HBA to the adapter list */ > mutex_lock(&bnx2fc_dev_lock); > list_add_tail(&hba->list, &adapter_list); I don't think KERN_ERR is the appropriate log level for this, can you change it to pr_info()? -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, 1 Apr 2016, Johannes Thumshirn wrote: > On 2016-04-01 15:10, Chad Dupuis wrote: >> Signed-off-by: Chad Dupuis <chad.dupuis@qlogic.com> >> --- >> drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c >> b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c >> index d95eee6..60423cf 100644 >> --- a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c >> +++ b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c >> @@ -2044,6 +2044,8 @@ static void bnx2fc_ulp_init(struct cnic_dev *dev) >> return; >> } >> >> + pr_err(PFX "FCoE initialized for %s.\n", dev->netdev->name); >> + >> /* Add HBA to the adapter list */ >> mutex_lock(&bnx2fc_dev_lock); >> list_add_tail(&hba->list, &adapter_list); > > I don't think KERN_ERR is the appropriate log level for this, can you change > it to pr_info()? > Yes, I'll change it to a pr_info in a V2 set. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c index d95eee6..60423cf 100644 --- a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c +++ b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c @@ -2044,6 +2044,8 @@ static void bnx2fc_ulp_init(struct cnic_dev *dev) return; } + pr_err(PFX "FCoE initialized for %s.\n", dev->netdev->name); + /* Add HBA to the adapter list */ mutex_lock(&bnx2fc_dev_lock); list_add_tail(&hba->list, &adapter_list);
Signed-off-by: Chad Dupuis <chad.dupuis@qlogic.com> --- drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 2 ++ 1 file changed, 2 insertions(+)