From patchwork Tue Jun 7 06:36:53 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Nicholas A. Bellinger" X-Patchwork-Id: 9159905 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7D2A06086C for ; Tue, 7 Jun 2016 06:37:59 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6E94B27B13 for ; Tue, 7 Jun 2016 06:37:59 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6380028350; Tue, 7 Jun 2016 06:37:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, URIBL_BLACK autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E606D28326 for ; Tue, 7 Jun 2016 06:37:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753634AbcFGGh4 (ORCPT ); Tue, 7 Jun 2016 02:37:56 -0400 Received: from mail.linux-iscsi.org ([67.23.28.174]:47905 "EHLO linux-iscsi.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753607AbcFGGhx (ORCPT ); Tue, 7 Jun 2016 02:37:53 -0400 Received: from linux-iscsi.org (localhost [127.0.0.1]) by linux-iscsi.org (Postfix) with ESMTP id 4A03122D9D7; Tue, 7 Jun 2016 06:37:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=linux-iscsi.org; s=default.private; t=1465281426; bh=5LwcXaXj3QKVb1Tt5gQjv0UKBW8l70V UdQKNTPG4G+w=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To: References; b=SCz8y5AOHlib+Lgdbn3qj8rvxgCOw2oEBEGeEPcXHBMFaHqq4xE3 o+rMSmek/a/u4K8A82l4A61Xov0z6rikFIIFQAg1eXwjGUDrzwmGNHwijDFCQzGfCOO jGLp3+Xt9Q4l18Rx/rgAT2bhkVDYFf4B1PkPZdDvZId8cMpWDD5Q= From: "Nicholas A. Bellinger" To: target-devel Cc: linux-nvme , linux-scsi , Jens Axboe , Christoph Hellwig , Martin Petersen , Sagi Grimberg , Hannes Reinecke , Mike Christie , Dave B Minturn , Nicholas Bellinger Subject: [RFC 5/8] nvmet/io-cmd: Hookup sbc_ops->execute_sync_cache backend ops Date: Tue, 7 Jun 2016 06:36:53 +0000 Message-Id: <1465281416-28355-6-git-send-email-nab@linux-iscsi.org> X-Mailer: git-send-email 1.7.2.5 In-Reply-To: <1465281416-28355-1-git-send-email-nab@linux-iscsi.org> References: <1465281416-28355-1-git-send-email-nab@linux-iscsi.org> Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Nicholas Bellinger This patch converts nvmet_execute_flush() to utilize sbc_ops->execute_sync_cache() for target_iostate submission into existing backends drivers via configfs in /sys/kernel/config/target/core/. Cc: Jens Axboe Cc: Christoph Hellwig Cc: Martin Petersen Cc: Sagi Grimberg Cc: Hannes Reinecke Cc: Mike Christie Signed-off-by: Nicholas Bellinger --- drivers/nvme/target/io-cmd.c | 21 ++++++++++++--------- 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/drivers/nvme/target/io-cmd.c b/drivers/nvme/target/io-cmd.c index 133a14a..23905a8 100644 --- a/drivers/nvme/target/io-cmd.c +++ b/drivers/nvme/target/io-cmd.c @@ -109,18 +109,21 @@ static void nvmet_execute_rw(struct nvmet_req *req) static void nvmet_execute_flush(struct nvmet_req *req) { -#if 0 - struct bio *bio; + struct target_iostate *ios = &req->t_iostate; + struct se_device *dev = rcu_dereference_raw(req->ns->dev); + struct sbc_ops *sbc_ops = dev->transport->sbc_ops; + sense_reason_t rc; - nvmet_inline_bio_init(req); - bio = &req->inline_bio; + if (!sbc_ops || !sbc_ops->execute_sync_cache) { + nvmet_req_complete(req, NVME_SC_INTERNAL | NVME_SC_DNR); + return; + } - bio->bi_bdev = req->ns->bdev; - bio->bi_private = req; - bio->bi_end_io = nvmet_bio_done; + ios->se_dev = dev; + ios->iomem = NULL; + ios->t_comp_func = &nvmet_complete_ios; - submit_bio(WRITE_FLUSH, bio); -#endif + rc = sbc_ops->execute_sync_cache(ios, false); } #if 0