diff mbox

[2/7] megaraid_sas: Send correct PhysArm to FW for R1 VD downgrade

Message ID 1476699850-25083-3-git-send-email-sumit.saxena@broadcom.com (mailing list archive)
State Changes Requested, archived
Headers show

Commit Message

Sumit Saxena Oct. 17, 2016, 10:24 a.m. UTC 
This patch fixes the issue of wrong PhysArm was sent to firmware for R1
VD downgrade.

Signed-off-by: Kiran Kumar Kasturi <kiran-kumar.kasturi@broadcom.com>
Signed-off-by: Sumit Saxena <sumit.saxena@broadcom.com>
---
 drivers/scsi/megaraid/megaraid_sas_fp.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Hannes Reinecke Oct. 17, 2016, 11:29 a.m. UTC | #1 
On 10/17/2016 12:24 PM, Sumit Saxena wrote:
> This patch fixes the issue of wrong PhysArm was sent to firmware for R1
> VD downgrade.
> 
> Signed-off-by: Kiran Kumar Kasturi <kiran-kumar.kasturi@broadcom.com>
> Signed-off-by: Sumit Saxena <sumit.saxena@broadcom.com>
> ---
>  drivers/scsi/megaraid/megaraid_sas_fp.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/megaraid/megaraid_sas_fp.c b/drivers/scsi/megaraid/megaraid_sas_fp.c
> index e413113..f237d00 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_fp.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_fp.c
> @@ -782,7 +782,8 @@ static u8 mr_spanset_get_phy_params(struct megasas_instance *instance, u32 ld,
>  			(raid->regTypeReqOnRead != REGION_TYPE_UNUSED))))
>  			pRAID_Context->regLockFlags = REGION_TYPE_EXCLUSIVE;
>  		else if (raid->level == 1) {
> -			pd = MR_ArPdGet(arRef, physArm + 1, map);
> +			physArm = physArm + 1;
> +			pd = MR_ArPdGet(arRef, physArm, map);
>  			if (pd != MR_PD_INVALID)
>  				*pDevHandle = MR_PdDevHandleGet(pd, map);
>  		}
> @@ -879,7 +880,8 @@ u8 MR_GetPhyParams(struct megasas_instance *instance, u32 ld, u64 stripRow,
>  			pRAID_Context->regLockFlags = REGION_TYPE_EXCLUSIVE;
>  		else if (raid->level == 1) {
>  			/* Get alternate Pd. */
> -			pd = MR_ArPdGet(arRef, physArm + 1, map);
> +			physArm = physArm + 1;
> +			pd = MR_ArPdGet(arRef, physArm, map);
>  			if (pd != MR_PD_INVALID)
>  				/* Get dev handle from Pd */
>  				*pDevHandle = MR_PdDevHandleGet(pd, map);
> 
Reviewed-by: Hannes Reinecke <hare@suse.com>

Cheers,

Hannes
Tomas Henzl Oct. 17, 2016, 12:50 p.m. UTC | #2 
On 17.10.2016 12:24, Sumit Saxena wrote:
> This patch fixes the issue of wrong PhysArm was sent to firmware for R1
> VD downgrade.
>
> Signed-off-by: Kiran Kumar Kasturi <kiran-kumar.kasturi@broadcom.com>
> Signed-off-by: Sumit Saxena <sumit.saxena@broadcom.com>

Reviewed-by: Tomas Henzl <thenzl@redhat.com>

Tomas

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/scsi/megaraid/megaraid_sas_fp.c b/drivers/scsi/megaraid/megaraid_sas_fp.c
index e413113..f237d00 100644
--- a/drivers/scsi/megaraid/megaraid_sas_fp.c
+++ b/drivers/scsi/megaraid/megaraid_sas_fp.c
@@ -782,7 +782,8 @@  static u8 mr_spanset_get_phy_params(struct megasas_instance *instance, u32 ld,
 			(raid->regTypeReqOnRead != REGION_TYPE_UNUSED))))
 			pRAID_Context->regLockFlags = REGION_TYPE_EXCLUSIVE;
 		else if (raid->level == 1) {
-			pd = MR_ArPdGet(arRef, physArm + 1, map);
+			physArm = physArm + 1;
+			pd = MR_ArPdGet(arRef, physArm, map);
 			if (pd != MR_PD_INVALID)
 				*pDevHandle = MR_PdDevHandleGet(pd, map);
 		}
@@ -879,7 +880,8 @@  u8 MR_GetPhyParams(struct megasas_instance *instance, u32 ld, u64 stripRow,
 			pRAID_Context->regLockFlags = REGION_TYPE_EXCLUSIVE;
 		else if (raid->level == 1) {
 			/* Get alternate Pd. */
-			pd = MR_ArPdGet(arRef, physArm + 1, map);
+			physArm = physArm + 1;
+			pd = MR_ArPdGet(arRef, physArm, map);
 			if (pd != MR_PD_INVALID)
 				/* Get dev handle from Pd */
 				*pDevHandle = MR_PdDevHandleGet(pd, map);