From patchwork Mon Oct 17 10:24:05 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sumit Saxena X-Patchwork-Id: 9378893 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 6C50B60780 for ; Mon, 17 Oct 2016 10:24:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5F2772912D for ; Mon, 17 Oct 2016 10:24:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 53F0729132; Mon, 17 Oct 2016 10:24:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 264612912D for ; Mon, 17 Oct 2016 10:24:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934287AbcJQKY2 (ORCPT ); Mon, 17 Oct 2016 06:24:28 -0400 Received: from mail-pa0-f54.google.com ([209.85.220.54]:33894 "EHLO mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933510AbcJQKY1 (ORCPT ); Mon, 17 Oct 2016 06:24:27 -0400 Received: by mail-pa0-f54.google.com with SMTP id rz1so62500706pab.1 for ; Mon, 17 Oct 2016 03:24:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=3+D3Qu3FySLV96pporxoj4cHhdITGMIjC2qt+eCJhEc=; b=fXn5t5tY72KKT+cN55oC4V/QIgdUW5zsfpiZJaW88X3f5vi/3K7bYeyouiSvNV1wor onh4yYr7X2pPw9F8enIz8QhqgvJIBvRYj6ftfQED2Rr0XBHUNssbYH80VvBXjj1Ro3l/ +VictlYyjR7AWoh8xyK5eI8Axf3qbwZQGErfw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=3+D3Qu3FySLV96pporxoj4cHhdITGMIjC2qt+eCJhEc=; b=VTLGzJ0uqur0VG8JHW+mcX6rR9mjvXFoLgtSPgOb56Jvy0RS0I/VXI5SubDq83Jch6 O/H0iKMwYWorCsSVK7hTXnYOqoxPi9JjEIY75RlaGF2agzpkqGe5212P2J6/YOA1IA0e VoqbP/PUaneMCgXsIfHY16LzABbcdyBdrsH4rogHQxc4y7RxG5kUbhjaG5f9VuakEgMZ BupRobcD7B4s2B/Cy3MsrihDOZg2QoxwlyQ1ekwaWSO4S2/bYHtWGlCFpMKkg+nb9etR 0dVVaCP4UX3KevleZofrr93Z/nGOTxNlevAVxgcrqZx69NK8SfjUMTtjC4hUOMrIDlwG yt4Q== X-Gm-Message-State: AA6/9Rl4JcPrP8Kc1fvReLndGL3ARIHNx+YBS4ogACUre6exaLGzJKZb7YYmZkH7QUpIfdCQ X-Received: by 10.66.189.194 with SMTP id gk2mr30567500pac.211.1476699867053; Mon, 17 Oct 2016 03:24:27 -0700 (PDT) Received: from dhcp-135-24-192-142.localdomain ([192.19.239.250]) by smtp.gmail.com with ESMTPSA id dj3sm36203777pad.1.2016.10.17.03.24.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 17 Oct 2016 03:24:26 -0700 (PDT) From: Sumit Saxena To: linux-scsi@vger.kernel.org Cc: martin.petersen@oracle.com, thenzl@redhat.com, jejb@linux.vnet.ibm.com, kashyap.desai@broadcom.com, Sumit Saxena , Kiran Kumar Kasturi Subject: [PATCH 2/7] megaraid_sas: Send correct PhysArm to FW for R1 VD downgrade Date: Mon, 17 Oct 2016 03:24:05 -0700 Message-Id: <1476699850-25083-3-git-send-email-sumit.saxena@broadcom.com> X-Mailer: git-send-email 2.4.3 In-Reply-To: <1476699850-25083-1-git-send-email-sumit.saxena@broadcom.com> References: <1476699850-25083-1-git-send-email-sumit.saxena@broadcom.com> Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch fixes the issue of wrong PhysArm was sent to firmware for R1 VD downgrade. Signed-off-by: Kiran Kumar Kasturi Signed-off-by: Sumit Saxena Reviewed-by: Hannes Reinecke Reviewed-by: Tomas Henzl --- drivers/scsi/megaraid/megaraid_sas_fp.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_sas_fp.c b/drivers/scsi/megaraid/megaraid_sas_fp.c index e413113..f237d00 100644 --- a/drivers/scsi/megaraid/megaraid_sas_fp.c +++ b/drivers/scsi/megaraid/megaraid_sas_fp.c @@ -782,7 +782,8 @@ static u8 mr_spanset_get_phy_params(struct megasas_instance *instance, u32 ld, (raid->regTypeReqOnRead != REGION_TYPE_UNUSED)))) pRAID_Context->regLockFlags = REGION_TYPE_EXCLUSIVE; else if (raid->level == 1) { - pd = MR_ArPdGet(arRef, physArm + 1, map); + physArm = physArm + 1; + pd = MR_ArPdGet(arRef, physArm, map); if (pd != MR_PD_INVALID) *pDevHandle = MR_PdDevHandleGet(pd, map); } @@ -879,7 +880,8 @@ u8 MR_GetPhyParams(struct megasas_instance *instance, u32 ld, u64 stripRow, pRAID_Context->regLockFlags = REGION_TYPE_EXCLUSIVE; else if (raid->level == 1) { /* Get alternate Pd. */ - pd = MR_ArPdGet(arRef, physArm + 1, map); + physArm = physArm + 1; + pd = MR_ArPdGet(arRef, physArm, map); if (pd != MR_PD_INVALID) /* Get dev handle from Pd */ *pDevHandle = MR_PdDevHandleGet(pd, map);