From patchwork Thu Oct 20 09:04:59 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sumit Saxena X-Patchwork-Id: 9386353 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D7B76607F0 for ; Thu, 20 Oct 2016 09:05:24 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C725029B11 for ; Thu, 20 Oct 2016 09:05:24 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BC2B629B5C; Thu, 20 Oct 2016 09:05:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 39B1F29B11 for ; Thu, 20 Oct 2016 09:05:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753253AbcJTJFU (ORCPT ); Thu, 20 Oct 2016 05:05:20 -0400 Received: from mail-pf0-f181.google.com ([209.85.192.181]:33799 "EHLO mail-pf0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752711AbcJTJFS (ORCPT ); Thu, 20 Oct 2016 05:05:18 -0400 Received: by mail-pf0-f181.google.com with SMTP id r16so32855886pfg.1 for ; Thu, 20 Oct 2016 02:05:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=X3gYaMv9hC97esbNiNWckOk5csMAvzJm6YgX7/Xx+qE=; b=AduxKYb/mI+sq9xE8VGyO5flVRLaAoEB9iz9kVgidF774LmWjPlFB8aKOS9iTqDTOM TLpEpTo7CRt+l17Ot7WGiORORXMJH0FC73ffiM+hWTV3uqf3fCvx6d9mRRoIMSYPQvt+ 3VJohqd04y3ztbK6EImMzSInV7j1v2bSxC+co= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=X3gYaMv9hC97esbNiNWckOk5csMAvzJm6YgX7/Xx+qE=; b=GrdcOi3fL7osduD9Riak5APzM2Vlit3rFxVtCZSQ5DgF+GiwotONd7mpeqbadUMZ38 yGfxMyQ6OFeHHCYUh6cs79grVjrdCOEIiXdTbS9dT2Iz4rvRJV1tuHVYByL3P/FxHQW3 3j2Tv/ngoZY6BiRNm3ITDj5fwgkf/G5p/e4bL7ATBC7hUQ9sgof9mczraPvPjdAWLWN+ T9p5IppvD6OUZw+AZQZ2e8lncV5nNLDv/KHTV3CMTFAo00UH0MT2/3xHyQuaFjf4nAar +dBkuz7D3LZxLk0QxODuloyPj2msmAg+gnTT583y8sn0uHbSI5BR82N25ZhnY0g6NGN4 QXPw== X-Gm-Message-State: AA6/9Rl7wlTKyENOfL18IsGgxlUb3cGi/MgXGT/hEXBrF2gKYTRNK8VfDWYroAdddCFv8JPS X-Received: by 10.98.90.130 with SMTP id o124mr19418079pfb.53.1476954317625; Thu, 20 Oct 2016 02:05:17 -0700 (PDT) Received: from dhcp-135-24-192-142.localdomain ([192.19.239.250]) by smtp.gmail.com with ESMTPSA id 136sm69738199pfu.87.2016.10.20.02.05.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 20 Oct 2016 02:05:17 -0700 (PDT) From: Sumit Saxena To: linux-scsi@vger.kernel.org Cc: martin.petersen@oracle.com, thenzl@redhat.com, jejb@linux.vnet.ibm.com, kashyap.desai@broadcom.com, Sumit Saxena , stable@vger.kernel.org, Kiran Kumar Kasturi Subject: [PATCH v2 1/7] megaraid_sas: For SRIOV enabled firmware, ensure VF driver waits for 30secs before reset Date: Thu, 20 Oct 2016 02:04:59 -0700 Message-Id: <1476954305-576-2-git-send-email-sumit.saxena@broadcom.com> X-Mailer: git-send-email 2.4.3 In-Reply-To: <1476954305-576-1-git-send-email-sumit.saxena@broadcom.com> References: <1476954305-576-1-git-send-email-sumit.saxena@broadcom.com> Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP For SRIOV enabled firmware, if there is a OCR(online controller reset) possibility driver set the convert flag to 1, which is not happening if there are outstanding commands even after 180 seconds. As driver does not set convert flag to 1 and still making the OCR to run, VF(Virtual function) driver is directly writing on to the register instead of waiting for 30 seconds. Setting convert flag to 1 will cause VF driver will wait for 30 secs before going for reset. CC: stable@vger.kernel.org Signed-off-by: Kiran Kumar Kasturi Signed-off-by: Sumit Saxena Reviewed-by: Hannes Reinecke Reviewed-by: Tomas Henzl --- drivers/scsi/megaraid/megaraid_sas_fusion.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c index 52d8bbf..61be7ed 100644 --- a/drivers/scsi/megaraid/megaraid_sas_fusion.c +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c @@ -2823,6 +2823,7 @@ int megasas_wait_for_outstanding_fusion(struct megasas_instance *instance, dev_err(&instance->pdev->dev, "pending commands remain after waiting, " "will reset adapter scsi%d.\n", instance->host->host_no); + *convert = 1; retval = 1; } out: