From patchwork Wed Nov 9 10:59:42 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sumit Saxena X-Patchwork-Id: 9418767 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 029A6601C0 for ; Wed, 9 Nov 2016 11:00:05 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E824A286FC for ; Wed, 9 Nov 2016 11:00:04 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DAB2D28802; Wed, 9 Nov 2016 11:00:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C9F4B29174 for ; Wed, 9 Nov 2016 11:00:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752964AbcKILAD (ORCPT ); Wed, 9 Nov 2016 06:00:03 -0500 Received: from mail-pf0-f171.google.com ([209.85.192.171]:33726 "EHLO mail-pf0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752227AbcKILAC (ORCPT ); Wed, 9 Nov 2016 06:00:02 -0500 Received: by mail-pf0-f171.google.com with SMTP id d2so125839791pfd.0 for ; Wed, 09 Nov 2016 03:00:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id; bh=dE1ahyy0onWcUScosIvU7ItMVJm7Qs0qihtXUi2GKm4=; b=LNBIlESMj/TuleBV3h5h7irO0injtV5E3j/nNaRZf1wyJc6Em9EIHN05USsbwd1YAQ 2kenPA6WaM1YpQj1h/eS/gVoE+MGDL9TyUt2d9UjNIoEYTxhTppWEkOp+SrIObzRqmcl Bnom92SCDPsGUfmJZypviF/sFkYsfXsTdblyQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=dE1ahyy0onWcUScosIvU7ItMVJm7Qs0qihtXUi2GKm4=; b=U977WoUPe93CK4RYqN4HhmzMeOERCtDdGQOtPqwR+aX4G0PL/mltXbt86deUaTGRxV 3n8WgZtI9UJLOc6NsMJqG4cvCf2CMCgirHcxOPLlO0RrW+embu3plNH+qXfG2LgbDEvp b4WHsg+5z8Oos018TXj+/vqZTNin9r/qanKOnbfaDGUiTDGe/PALQvaRO8BATTPPWxqv nSFHemODwy1hi5uid3KJS2GWYjPlMdrECZ6xVJ4+S3kX7DZr/9vxsKAPQmVJG8lPrM7S 4UmGfo+yggOy7MUpxOCEaXDu8u2RjeCSSpzelLL4D78ugOmwjjCHMFBKoy997+o3P9EF mb2Q== X-Gm-Message-State: ABUngvc6MzMswG+pPA9VwaVRJeUBz7i8JWOnzlxj6Vr2Gft3kJMm5HKaCR1+Mtkxf61OjdSl X-Received: by 10.98.196.89 with SMTP id y86mr32013664pff.172.1478689201296; Wed, 09 Nov 2016 03:00:01 -0800 (PST) Received: from dhcp-135-24-192-142.localdomain ([192.19.239.250]) by smtp.gmail.com with ESMTPSA id w65sm21460159pfa.88.2016.11.09.02.59.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 09 Nov 2016 03:00:00 -0800 (PST) From: Sumit Saxena To: linux-scsi@vger.kernel.org Cc: martin.petersen@oracle.com, thenzl@redhat.com, jejb@linux.vnet.ibm.com, kashyap.desai@broadcom.com, shivasharan.srikanteshwara@broadcom.com, axboe@kernel.dk, stable@vger.kernel.org, Sumit Saxena Subject: [PATCH] megaraid_sas: fix macro MEGASAS_IS_LOGICAL to avoid regression caused by commit 1e793f6fc0db920400574211c48f9157a37e3945 Date: Wed, 9 Nov 2016 02:59:42 -0800 Message-Id: <1478689182-10854-1-git-send-email-sumit.saxena@broadcom.com> X-Mailer: git-send-email 2.4.3 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch will fix regression caused by below commit- 1e793f6 scsi: megaraid_sas: Fix data integrity failure for JBOD (passthrough) devices The problem was MEGASAS_IS_LOGICAL macro does not have braces and because of above commit using this macro was exposing lot of non-existing SCSI devices(all SCSI commands to channels-1,2,3 was returned as SUCCESS-DID_OK by driver). Fixes: 1e793f6fc0db920400574211c48f9157a37e3945 Reported-by: Jens Axboe CC: stable@vger.kernel.org Signed-off-by: Kashyap Desai Signed-off-by: Sumit Saxena Tested-by: Sumit Saxena Reviewed-by: Tomas Henzl Tested-by: Jens Axboe --- drivers/scsi/megaraid/megaraid_sas.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/megaraid/megaraid_sas.h b/drivers/scsi/megaraid/megaraid_sas.h index ca86c88..3aaea71 100644 --- a/drivers/scsi/megaraid/megaraid_sas.h +++ b/drivers/scsi/megaraid/megaraid_sas.h @@ -2233,7 +2233,7 @@ struct megasas_instance_template { }; #define MEGASAS_IS_LOGICAL(scp) \ - (scp->device->channel < MEGASAS_MAX_PD_CHANNELS) ? 0 : 1 + ((scp->device->channel < MEGASAS_MAX_PD_CHANNELS) ? 0 : 1) #define MEGASAS_DEV_INDEX(scp) \ (((scp->device->channel % 2) * MEGASAS_MAX_DEV_PER_CHANNEL) + \