diff mbox

[1/2] hpsa: update pci ids

Message ID 149073721384.23669.10598426212290266393.stgit@brunhilda (mailing list archive)
State Accepted
Headers show

Commit Message

Don Brace March 28, 2017, 9:40 p.m. UTC 
Reviewed-by: Gerry Morong <gerry.morong@microsemi.com>
Reviewed-by: Scott Teel <scott.teel@microsemi.com>
Signed-off-by: Don Brace <don.brace@microsemi.com>
---
 drivers/scsi/hpsa.c |    4 ++++
 1 file changed, 4 insertions(+)

Comments

Tomas Henzl March 29, 2017, 3:43 p.m. UTC | #1 
On 28.3.2017 23:40, Don Brace wrote:
> Reviewed-by: Gerry Morong <gerry.morong@microsemi.com>
> Reviewed-by: Scott Teel <scott.teel@microsemi.com>
> Signed-off-by: Don Brace <don.brace@microsemi.com>

Hi Don

has a gen9 device with id=0x334D ever been released?
https://lkml.org/lkml/2013/9/4/499
seems to be still missing in the current table.

tomash

> ---
>  drivers/scsi/hpsa.c |    4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
> index 0d0be77..668cf47 100644
> --- a/drivers/scsi/hpsa.c
> +++ b/drivers/scsi/hpsa.c
> @@ -108,10 +108,12 @@ static const struct pci_device_id hpsa_pci_device_id[] = {
>  	{PCI_VENDOR_ID_HP,     PCI_DEVICE_ID_HP_CISSF,     0x103C, 0x3354},
>  	{PCI_VENDOR_ID_HP,     PCI_DEVICE_ID_HP_CISSF,     0x103C, 0x3355},
>  	{PCI_VENDOR_ID_HP,     PCI_DEVICE_ID_HP_CISSF,     0x103C, 0x3356},
> +	{PCI_VENDOR_ID_HP,     PCI_DEVICE_ID_HP_CISSH,     0x103c, 0x1920},
>  	{PCI_VENDOR_ID_HP,     PCI_DEVICE_ID_HP_CISSH,     0x103C, 0x1921},
>  	{PCI_VENDOR_ID_HP,     PCI_DEVICE_ID_HP_CISSH,     0x103C, 0x1922},
>  	{PCI_VENDOR_ID_HP,     PCI_DEVICE_ID_HP_CISSH,     0x103C, 0x1923},
>  	{PCI_VENDOR_ID_HP,     PCI_DEVICE_ID_HP_CISSH,     0x103C, 0x1924},
> +	{PCI_VENDOR_ID_HP,     PCI_DEVICE_ID_HP_CISSH,     0x103c, 0x1925},
>  	{PCI_VENDOR_ID_HP,     PCI_DEVICE_ID_HP_CISSH,     0x103C, 0x1926},
>  	{PCI_VENDOR_ID_HP,     PCI_DEVICE_ID_HP_CISSH,     0x103C, 0x1928},
>  	{PCI_VENDOR_ID_HP,     PCI_DEVICE_ID_HP_CISSH,     0x103C, 0x1929},
> @@ -171,10 +173,12 @@ static struct board_type products[] = {
>  	{0x3354103C, "Smart Array P420i", &SA5_access},
>  	{0x3355103C, "Smart Array P220i", &SA5_access},
>  	{0x3356103C, "Smart Array P721m", &SA5_access},
> +	{0x1920103C, "Smart Array P430i", &SA5_access},
>  	{0x1921103C, "Smart Array P830i", &SA5_access},
>  	{0x1922103C, "Smart Array P430", &SA5_access},
>  	{0x1923103C, "Smart Array P431", &SA5_access},
>  	{0x1924103C, "Smart Array P830", &SA5_access},
> +	{0x1925103C, "Smart Array P831", &SA5_access},
>  	{0x1926103C, "Smart Array P731m", &SA5_access},
>  	{0x1928103C, "Smart Array P230i", &SA5_access},
>  	{0x1929103C, "Smart Array P530", &SA5_access},
>
Don Brace March 29, 2017, 4 p.m. UTC | #2 
> -----Original Message-----

> From: Tomas Henzl [mailto:thenzl@redhat.com]

> Sent: Wednesday, March 29, 2017 10:44 AM

> To: Don Brace <don.brace@microsemi.com>; joseph.szczypek@hpe.com;

> Gerry Morong <gerry.morong@microsemi.com>; John Hall

> <John.Hall@microsemi.com>; jejb@linux.vnet.ibm.com; Kevin Barnett

> <kevin.barnett@microsemi.com>; Mahesh Rajashekhara

> <mahesh.rajashekhara@microsemi.com>; Bader Ali - Saleh

> <bader.alisaleh@microsemi.com>; hch@infradead.org; Scott Teel

> <scott.teel@microsemi.com>; Viswas G <viswas.g@microsemi.com>; Justin

> Lindley <justin.lindley@microsemi.com>; Scott Benesh

> <scott.benesh@microsemi.com>; POSWALD@suse.com

> Cc: linux-scsi@vger.kernel.org

> Subject: Re: [PATCH 1/2] hpsa: update pci ids

> 

> EXTERNAL EMAIL

> 

> 

> On 28.3.2017 23:40, Don Brace wrote:

> > Reviewed-by: Gerry Morong <gerry.morong@microsemi.com>

> > Reviewed-by: Scott Teel <scott.teel@microsemi.com>

> > Signed-off-by: Don Brace <don.brace@microsemi.com>

> 

> Hi Don

> 

> has a gen9 device with id=0x334D ever been released?

> https://lkml.org/lkml/2013/9/4/499

> seems to be still missing in the current table.

> 

> tomash


No, this device was never sold. So I did not add this to my patch.
Thanks,
Don Brace
ESC - Smart Storage
Microsemi Corporation


> 

> > ---

> >  drivers/scsi/hpsa.c |    4 ++++

> >  1 file changed, 4 insertions(+)

> >

> > diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c

> > index 0d0be77..668cf47 100644

> > --- a/drivers/scsi/hpsa.c

> > +++ b/drivers/scsi/hpsa.c

> > @@ -108,10 +108,12 @@ static const struct pci_device_id

> hpsa_pci_device_id[] = {

> >       {PCI_VENDOR_ID_HP,     PCI_DEVICE_ID_HP_CISSF,     0x103C, 0x3354},

> >       {PCI_VENDOR_ID_HP,     PCI_DEVICE_ID_HP_CISSF,     0x103C, 0x3355},

> >       {PCI_VENDOR_ID_HP,     PCI_DEVICE_ID_HP_CISSF,     0x103C, 0x3356},

> > +     {PCI_VENDOR_ID_HP,     PCI_DEVICE_ID_HP_CISSH,     0x103c, 0x1920},

> >       {PCI_VENDOR_ID_HP,     PCI_DEVICE_ID_HP_CISSH,     0x103C, 0x1921},

> >       {PCI_VENDOR_ID_HP,     PCI_DEVICE_ID_HP_CISSH,     0x103C, 0x1922},

> >       {PCI_VENDOR_ID_HP,     PCI_DEVICE_ID_HP_CISSH,     0x103C, 0x1923},

> >       {PCI_VENDOR_ID_HP,     PCI_DEVICE_ID_HP_CISSH,     0x103C, 0x1924},

> > +     {PCI_VENDOR_ID_HP,     PCI_DEVICE_ID_HP_CISSH,     0x103c, 0x1925},

> >       {PCI_VENDOR_ID_HP,     PCI_DEVICE_ID_HP_CISSH,     0x103C, 0x1926},

> >       {PCI_VENDOR_ID_HP,     PCI_DEVICE_ID_HP_CISSH,     0x103C, 0x1928},

> >       {PCI_VENDOR_ID_HP,     PCI_DEVICE_ID_HP_CISSH,     0x103C, 0x1929},

> > @@ -171,10 +173,12 @@ static struct board_type products[] = {

> >       {0x3354103C, "Smart Array P420i", &SA5_access},

> >       {0x3355103C, "Smart Array P220i", &SA5_access},

> >       {0x3356103C, "Smart Array P721m", &SA5_access},

> > +     {0x1920103C, "Smart Array P430i", &SA5_access},

> >       {0x1921103C, "Smart Array P830i", &SA5_access},

> >       {0x1922103C, "Smart Array P430", &SA5_access},

> >       {0x1923103C, "Smart Array P431", &SA5_access},

> >       {0x1924103C, "Smart Array P830", &SA5_access},

> > +     {0x1925103C, "Smart Array P831", &SA5_access},

> >       {0x1926103C, "Smart Array P731m", &SA5_access},

> >       {0x1928103C, "Smart Array P230i", &SA5_access},

> >       {0x1929103C, "Smart Array P530", &SA5_access},

> >
Don Brace March 29, 2017, 4:15 p.m. UTC | #3 
> >

> >

> > On 28.3.2017 23:40, Don Brace wrote:

> > > Reviewed-by: Gerry Morong <gerry.morong@microsemi.com>

> > > Reviewed-by: Scott Teel <scott.teel@microsemi.com>

> > > Signed-off-by: Don Brace <don.brace@microsemi.com>

> >

> > Hi Don

> >

> > has a gen9 device with id=0x334D ever been released?

> > https://lkml.org/lkml/2013/9/4/499

> > seems to be still missing in the current table.

> >

> > tomash

> 

> No, this device was never sold. So I did not add this to my patch.


To be more specific, this patch added the device:
163dbcd89c5acc5502636963023b9b42ca08c00f
Subject: [PATCH 185/478] [SCSI] hpsa: housekeeping patch for device_id and
 product arrays

This patch does a bit of housekeeping for hpsa. Change lowercase alpha hex
digits to uppercase for consistency within the driver. Also moves the P822se
in the tables to keep controllers of each family grouped together.

and this patch removed the device:
d5747e0aa0e52fc07ac4b4cae40c70ac9697f2fc
Subject: [PATCH 199/478] [SCSI] hpsa: remove P822se PCI ID

Remove PCI ID for the never shipped P822se.

Thanks,
Don Brace
ESC - Smart Storage
Microsemi Corporation
> 

> 

> >

> > > ---

> > >  drivers/scsi/hpsa.c |    4 ++++

> > >  1 file changed, 4 insertions(+)

> > >

> > > diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c

> > > index 0d0be77..668cf47 100644

> > > --- a/drivers/scsi/hpsa.c

> > > +++ b/drivers/scsi/hpsa.c

> > > @@ -108,10 +108,12 @@ static const struct pci_device_id

> > hpsa_pci_device_id[] = {

> > >       {PCI_VENDOR_ID_HP,     PCI_DEVICE_ID_HP_CISSF,     0x103C, 0x3354},

> > >       {PCI_VENDOR_ID_HP,     PCI_DEVICE_ID_HP_CISSF,     0x103C, 0x3355},

> > >       {PCI_VENDOR_ID_HP,     PCI_DEVICE_ID_HP_CISSF,     0x103C, 0x3356},

> > > +     {PCI_VENDOR_ID_HP,     PCI_DEVICE_ID_HP_CISSH,     0x103c,

> 0x1920},

> > >       {PCI_VENDOR_ID_HP,     PCI_DEVICE_ID_HP_CISSH,     0x103C,

> 0x1921},

> > >       {PCI_VENDOR_ID_HP,     PCI_DEVICE_ID_HP_CISSH,     0x103C,

> 0x1922},

> > >       {PCI_VENDOR_ID_HP,     PCI_DEVICE_ID_HP_CISSH,     0x103C,

> 0x1923},

> > >       {PCI_VENDOR_ID_HP,     PCI_DEVICE_ID_HP_CISSH,     0x103C,

> 0x1924},

> > > +     {PCI_VENDOR_ID_HP,     PCI_DEVICE_ID_HP_CISSH,     0x103c,

> 0x1925},

> > >       {PCI_VENDOR_ID_HP,     PCI_DEVICE_ID_HP_CISSH,     0x103C,

> 0x1926},

> > >       {PCI_VENDOR_ID_HP,     PCI_DEVICE_ID_HP_CISSH,     0x103C,

> 0x1928},

> > >       {PCI_VENDOR_ID_HP,     PCI_DEVICE_ID_HP_CISSH,     0x103C,

> 0x1929},

> > > @@ -171,10 +173,12 @@ static struct board_type products[] = {

> > >       {0x3354103C, "Smart Array P420i", &SA5_access},

> > >       {0x3355103C, "Smart Array P220i", &SA5_access},

> > >       {0x3356103C, "Smart Array P721m", &SA5_access},

> > > +     {0x1920103C, "Smart Array P430i", &SA5_access},

> > >       {0x1921103C, "Smart Array P830i", &SA5_access},

> > >       {0x1922103C, "Smart Array P430", &SA5_access},

> > >       {0x1923103C, "Smart Array P431", &SA5_access},

> > >       {0x1924103C, "Smart Array P830", &SA5_access},

> > > +     {0x1925103C, "Smart Array P831", &SA5_access},

> > >       {0x1926103C, "Smart Array P731m", &SA5_access},

> > >       {0x1928103C, "Smart Array P230i", &SA5_access},

> > >       {0x1929103C, "Smart Array P530", &SA5_access},

> > >
diff mbox

Patch

diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 0d0be77..668cf47 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -108,10 +108,12 @@  static const struct pci_device_id hpsa_pci_device_id[] = {
 	{PCI_VENDOR_ID_HP,     PCI_DEVICE_ID_HP_CISSF,     0x103C, 0x3354},
 	{PCI_VENDOR_ID_HP,     PCI_DEVICE_ID_HP_CISSF,     0x103C, 0x3355},
 	{PCI_VENDOR_ID_HP,     PCI_DEVICE_ID_HP_CISSF,     0x103C, 0x3356},
+	{PCI_VENDOR_ID_HP,     PCI_DEVICE_ID_HP_CISSH,     0x103c, 0x1920},
 	{PCI_VENDOR_ID_HP,     PCI_DEVICE_ID_HP_CISSH,     0x103C, 0x1921},
 	{PCI_VENDOR_ID_HP,     PCI_DEVICE_ID_HP_CISSH,     0x103C, 0x1922},
 	{PCI_VENDOR_ID_HP,     PCI_DEVICE_ID_HP_CISSH,     0x103C, 0x1923},
 	{PCI_VENDOR_ID_HP,     PCI_DEVICE_ID_HP_CISSH,     0x103C, 0x1924},
+	{PCI_VENDOR_ID_HP,     PCI_DEVICE_ID_HP_CISSH,     0x103c, 0x1925},
 	{PCI_VENDOR_ID_HP,     PCI_DEVICE_ID_HP_CISSH,     0x103C, 0x1926},
 	{PCI_VENDOR_ID_HP,     PCI_DEVICE_ID_HP_CISSH,     0x103C, 0x1928},
 	{PCI_VENDOR_ID_HP,     PCI_DEVICE_ID_HP_CISSH,     0x103C, 0x1929},
@@ -171,10 +173,12 @@  static struct board_type products[] = {
 	{0x3354103C, "Smart Array P420i", &SA5_access},
 	{0x3355103C, "Smart Array P220i", &SA5_access},
 	{0x3356103C, "Smart Array P721m", &SA5_access},
+	{0x1920103C, "Smart Array P430i", &SA5_access},
 	{0x1921103C, "Smart Array P830i", &SA5_access},
 	{0x1922103C, "Smart Array P430", &SA5_access},
 	{0x1923103C, "Smart Array P431", &SA5_access},
 	{0x1924103C, "Smart Array P830", &SA5_access},
+	{0x1925103C, "Smart Array P831", &SA5_access},
 	{0x1926103C, "Smart Array P731m", &SA5_access},
 	{0x1928103C, "Smart Array P230i", &SA5_access},
 	{0x1929103C, "Smart Array P530", &SA5_access},