| Message ID | 1501404235-9105-1-git-send-email-arvind.yadav.cs@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
2017-07-30 17:43 GMT+09:00 Arvind Yadav <arvind.yadav.cs@gmail.com>: > > pci_device_id are not supposed to change at runtime. All functions > working with pci_device_id provided by <linux/pci.h> work with > const pci_device_id. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> Thank you! (resending it twice due to an error) Acked-by: Masanori Goto <gotom@debian.or.jp> > --- > drivers/scsi/nsp32.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/nsp32.c b/drivers/scsi/nsp32.c > index 53c8477..1430b3c 100644 > --- a/drivers/scsi/nsp32.c > +++ b/drivers/scsi/nsp32.c > @@ -76,7 +76,7 @@ static const char *nsp32_release_version = "1.2"; > /**************************************************************************** > * Supported hardware > */ > -static struct pci_device_id nsp32_pci_table[] = { > +static const struct pci_device_id nsp32_pci_table[] = { > { > .vendor = PCI_VENDOR_ID_IODATA, > .device = PCI_DEVICE_ID_NINJASCSI_32BI_CBSC_II, > -- > 2.7.4
diff --git a/drivers/scsi/nsp32.c b/drivers/scsi/nsp32.c index 53c8477..1430b3c 100644 --- a/drivers/scsi/nsp32.c +++ b/drivers/scsi/nsp32.c @@ -76,7 +76,7 @@ static const char *nsp32_release_version = "1.2"; /**************************************************************************** * Supported hardware */ -static struct pci_device_id nsp32_pci_table[] = { +static const struct pci_device_id nsp32_pci_table[] = { { .vendor = PCI_VENDOR_ID_IODATA, .device = PCI_DEVICE_ID_NINJASCSI_32BI_CBSC_II,
pci_device_id are not supposed to change at runtime. All functions working with pci_device_id provided by <linux/pci.h> work with const pci_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> --- drivers/scsi/nsp32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)