diff mbox

scsi: Add TRY_VPD_PAGES to HITACHI OPEN-V blacklist entry

Message ID 1508224233-129972-1-git-send-email-hare@suse.de (mailing list archive)
State Accepted
Headers show

Commit Message

Hannes Reinecke Oct. 17, 2017, 7:10 a.m. UTC 
HITACHI is always supporting VPD pages, even though it's claiming
to support SCSI Revision 3 only.

Signed-off-by: Hannes Reinecke <hare@suse.com>
---
 drivers/scsi/scsi_devinfo.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Xose Vazquez Perez Oct. 17, 2017, 3:02 p.m. UTC | #1 
On 10/17/2017 09:10 AM, Hannes Reinecke wrote:

> HITACHI is always supporting VPD pages, even though it's claiming
> to support SCSI Revision 3 only.


"HP/OPEN-" is also affected. HP XP is a rebrand of HITACHI VSP.

{"HP", "OPEN-", "*", BLIST_REPORTLUN2}, /* HP XP Arrays */


> Signed-off-by: Hannes Reinecke <hare@suse.com>
> ---
>  drivers/scsi/scsi_devinfo.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c
> index ae2ad84..a998585 100644
> --- a/drivers/scsi/scsi_devinfo.c
> +++ b/drivers/scsi/scsi_devinfo.c
> @@ -174,7 +174,7 @@ struct scsi_dev_info_list_table {
>  	{"HITACHI", "DF500", "*", BLIST_REPORTLUN2},
>  	{"HITACHI", "DISK-SUBSYSTEM", "*", BLIST_REPORTLUN2},
>  	{"HITACHI", "HUS1530", "*", BLIST_NO_DIF},
> -	{"HITACHI", "OPEN-", "*", BLIST_REPORTLUN2},
> +	{"HITACHI", "OPEN-", "*", BLIST_REPORTLUN2 | BLIST_TRY_VPD_PAGES},
>  	{"HITACHI", "OP-C-", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
>  	{"HITACHI", "3380-", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
>  	{"HITACHI", "3390-", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
>
Martin K. Petersen Oct. 18, 2017, 2:47 a.m. UTC | #2 
Hannes,

> HITACHI is always supporting VPD pages, even though it's claiming to
> support SCSI Revision 3 only.

Applied to 4.15/scsi-queue.
diff mbox

Patch

diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c
index ae2ad84..a998585 100644
--- a/drivers/scsi/scsi_devinfo.c
+++ b/drivers/scsi/scsi_devinfo.c
@@ -174,7 +174,7 @@  struct scsi_dev_info_list_table {
 	{"HITACHI", "DF500", "*", BLIST_REPORTLUN2},
 	{"HITACHI", "DISK-SUBSYSTEM", "*", BLIST_REPORTLUN2},
 	{"HITACHI", "HUS1530", "*", BLIST_NO_DIF},
-	{"HITACHI", "OPEN-", "*", BLIST_REPORTLUN2},
+	{"HITACHI", "OPEN-", "*", BLIST_REPORTLUN2 | BLIST_TRY_VPD_PAGES},
 	{"HITACHI", "OP-C-", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
 	{"HITACHI", "3380-", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
 	{"HITACHI", "3390-", "*", BLIST_SPARSELUN | BLIST_LARGELUN},