| Message ID | 1509620467-6679-1-git-send-email-rsahu@apm.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
On Thu, Nov 02, 2017 at 04:31:07PM +0530, Rameshwar Prasad Sahu wrote: > When tracing ata link error event, the kernel crashes when the disk is > removed due to NULL pointer access by trace_ata_eh_link_autopsy API. > This occurs as the dev is NULL when the disk disappeared. This patch > fixes this crash by calling trace_ata_eh_link_autopsy only if "dev" > is not NULL. > > v2 changes: > Removed direct passing "link" pointer instead of "dev" in trace API. > > Signed-off-by: Rameshwar Prasad Sahu <rsahu@apm.com> Applied to libata/for-4.15. Thanks.
diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c index e4effef..ea20e0e 100644 --- a/drivers/ata/libata-eh.c +++ b/drivers/ata/libata-eh.c @@ -2264,8 +2264,8 @@ static void ata_eh_link_autopsy(struct ata_link *link) if (dev->flags & ATA_DFLAG_DUBIOUS_XFER) eflags |= ATA_EFLAG_DUBIOUS_XFER; ehc->i.action |= ata_eh_speed_down(dev, eflags, all_err_mask); + trace_ata_eh_link_autopsy(dev, ehc->i.action, all_err_mask); } - trace_ata_eh_link_autopsy(dev, ehc->i.action, all_err_mask); DPRINTK("EXIT\n"); }
When tracing ata link error event, the kernel crashes when the disk is removed due to NULL pointer access by trace_ata_eh_link_autopsy API. This occurs as the dev is NULL when the disk disappeared. This patch fixes this crash by calling trace_ata_eh_link_autopsy only if "dev" is not NULL. v2 changes: Removed direct passing "link" pointer instead of "dev" in trace API. Signed-off-by: Rameshwar Prasad Sahu <rsahu@apm.com> --- drivers/ata/libata-eh.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- 1.7.1