From patchwork Thu Nov 2 14:59:42 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 10038855 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7017D60291 for ; Thu, 2 Nov 2017 15:00:01 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 62EEC29120 for ; Thu, 2 Nov 2017 15:00:01 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 575D029123; Thu, 2 Nov 2017 15:00:01 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2182D29121 for ; Thu, 2 Nov 2017 15:00:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933723AbdKBO7s (ORCPT ); Thu, 2 Nov 2017 10:59:48 -0400 Received: from esa4.hgst.iphmx.com ([216.71.154.42]:58532 "EHLO esa4.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933448AbdKBO7q (ORCPT ); Thu, 2 Nov 2017 10:59:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1509634787; x=1541170787; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=+64h09gq3DSIjJCoBr9UoQpY7O3mCcuHsxFB5Yv88z4=; b=SfBsWoNg/FCKhvGKEYRxBttHqeemeTI4oJTf8B3yKVKeI7qKAfLdFN/o BW5eFMDTMPl7UPQbtlgycNyxAX94mOhwYosj6kshRUVLjqjqpwu8n0IEI 1vd+uh8lpdF+W9vLoyUqm/rkpWlxcIHuY/2rHK2M0IaVNY+Ho2dewtRdj mLE7qn2C59c3ibwQDN0EJepeYYBSdR80qI8h4sJLT4395XJonbFlZYAX9 wJOpbH33VF4teMDLH9fNW/XjW+zQ4O1CL2zcPXCKxESZGNNHD1Uv3NVRL VKzsjazOXYCPIi2jDDLOt3bggpdg6syZV4sKwTVq3f9l/Ehjd7j5siTST Q==; X-IronPort-AV: E=Sophos;i="5.44,334,1505750400"; d="scan'208";a="60667900" Received: from mail-cys01nam02lp0049.outbound.protection.outlook.com (HELO NAM02-CY1-obe.outbound.protection.outlook.com) ([207.46.163.49]) by ob1.hgst.iphmx.com with ESMTP; 02 Nov 2017 22:59:46 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector1-wdc-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=+64h09gq3DSIjJCoBr9UoQpY7O3mCcuHsxFB5Yv88z4=; b=CWLZnHMQSZLzDyRZOMlnPpsRaD7sNGn7Gta30yaZY6iPnMI3mZgmCCSQ5SdWDNYVZ9u5kcOk0va2TazOl+jirMbLkpAvVWV6h6ZvV2yVKQ0L0NRwgbp2kdz56X/iaPEt+1GpIq8nIxZchMcV2W0uHvj/gKbCeLwbZQog+INtTao= Received: from CY1PR0401MB1536.namprd04.prod.outlook.com (10.163.19.154) by CY1PR0401MB1536.namprd04.prod.outlook.com (10.163.19.154) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.197.13; Thu, 2 Nov 2017 14:59:43 +0000 Received: from CY1PR0401MB1536.namprd04.prod.outlook.com ([10.163.19.154]) by CY1PR0401MB1536.namprd04.prod.outlook.com ([10.163.19.154]) with mapi id 15.20.0197.013; Thu, 2 Nov 2017 14:59:43 +0000 From: Bart Van Assche To: "arnd@arndb.de" , "axboe@kernel.dk" CC: "jejb@linux.vnet.ibm.com" , "davem@davemloft.net" , "linux-kernel@vger.kernel.org" , "hare@suse.com" , "martin.petersen@oracle.com" , "linux-ide@vger.kernel.org" , "linux-scsi@vger.kernel.org" Subject: Re: [PATCH] block: fix CDROM dependency on BLK_DEV Thread-Topic: [PATCH] block: fix CDROM dependency on BLK_DEV Thread-Index: AQHTU8yQxM4G3H/tFUuyVfbrUMblWaMBLtKA Date: Thu, 2 Nov 2017 14:59:42 +0000 Message-ID: <1509634781.2484.3.camel@wdc.com> References: <20171102111952.4021454-1-arnd@arndb.de> In-Reply-To: <20171102111952.4021454-1-arnd@arndb.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Bart.VanAssche@wdc.com; x-originating-ip: [63.163.107.100] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; CY1PR0401MB1536; 20:5JrkkicHqA7muz265ZziFK78zt2ntx/+CsFrdnhwMSr9MHYdqGIThW/YvJh/67I/ejrUf6A39oqjTmZoYmobv8efSemf4qjyYeTvJQ6sx8D9gIAA2/52DMK4CLJ4CyrbF/J4QF5DVFJ0NRPOwoJl2zcwuL/jdqaUNuozAQjqLYQ= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 1c619cf3-6bd3-4491-e80a-08d5220259a9 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(2017052603199); SRVR:CY1PR0401MB1536; x-ms-traffictypediagnostic: CY1PR0401MB1536: wdcipoutbound: EOP-TRUE x-exchange-antispam-report-test: UriScan:; x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(3231020)(100000703101)(100105400095)(10201501046)(93006095)(93001095)(3002001)(6055026)(6041248)(20161123555025)(20161123558100)(20161123564025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CY1PR0401MB1536; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CY1PR0401MB1536; x-forefront-prvs: 047999FF16 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(6009001)(346002)(39860400002)(376002)(189002)(24454002)(199003)(52314003)(377424004)(53936002)(68736007)(36756003)(305945005)(2501003)(478600001)(6246003)(6512007)(189998001)(97736004)(86362001)(101416001)(72206003)(8676002)(110136005)(102836003)(3846002)(7736002)(6116002)(316002)(2900100001)(54906003)(106356001)(8936002)(2906002)(3280700002)(3660700001)(103116003)(6506006)(76176999)(14454004)(81156014)(66066001)(81166006)(4326008)(229853002)(5660300001)(25786009)(105586002)(33646002)(50986999)(54356999)(6436002)(77096006)(6486002)(99286004)(2950100002); DIR:OUT; SFP:1102; SCL:1; SRVR:CY1PR0401MB1536; H:CY1PR0401MB1536.namprd04.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-ID: <6B475AAD9AC35344BB140CB22E9C96AA@namprd04.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1c619cf3-6bd3-4491-e80a-08d5220259a9 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Nov 2017 14:59:43.0816 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0401MB1536 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Thu, 2017-11-02 at 12:19 +0100, Arnd Bergmann wrote: > After the cdrom cleanup, I get randconfig warnings for some configurations: > > warning: (BLK_DEV_IDECD && BLK_DEV_SR) selects CDROM which has unmet direct dependencies (BLK_DEV) Hello Arnd, Since Jens has already queued your patch it's too late to consider alternatives. Anyway, since the cdrom driver calls block layer functions directly, have you considered the following alternative? diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig index 0dad1d2536f7..e7044c893817 100644 --- a/drivers/block/Kconfig +++ b/drivers/block/Kconfig @@ -69,6 +69,7 @@ config AMIGA_Z2RAM config CDROM tristate "CD-ROM driver" + depends on BLK_DEV help A CD-ROM is a pre-pressed optical compact disc which contains data. The name is an acronym which stands for "Compact Disc