From patchwork Sat Dec 2 10:19:26 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suganath Prabu S X-Patchwork-Id: 10088569 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 28CE860595 for ; Sat, 2 Dec 2017 10:19:54 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 10EAD29E52 for ; Sat, 2 Dec 2017 10:19:54 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0324E29E54; Sat, 2 Dec 2017 10:19:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9B21729E52 for ; Sat, 2 Dec 2017 10:19:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751649AbdLBKTx (ORCPT ); Sat, 2 Dec 2017 05:19:53 -0500 Received: from mail-qk0-f195.google.com ([209.85.220.195]:34790 "EHLO mail-qk0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751611AbdLBKTw (ORCPT ); Sat, 2 Dec 2017 05:19:52 -0500 Received: by mail-qk0-f195.google.com with SMTP id d66so16205109qkg.1 for ; Sat, 02 Dec 2017 02:19:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id; bh=yvNxeasrqTAWpR4qq/1aZVyi4Ejf7M93gB4Mr3mOYP0=; b=UuLsPZS7aFlq4PwXerCZuGYjobPtBKzyRG+A+2JKdA5kb7eVgbyDrd2BCvRyIKeyn1 FXwVZ1gyXYZvHKQafoLW0XxPYNKMvkxrMgrXoagqzet12ji/qYJAJZd1I+lvwIZkpkfR ht5L3L4POW9pN1Fc+1q1VpOLOo+hB9mRE6i4M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=yvNxeasrqTAWpR4qq/1aZVyi4Ejf7M93gB4Mr3mOYP0=; b=jL2aZt9zLOJyQb09ePsaNSKbQMviIiccIkBAwVgpeHovIol8XTdnwLPc9rFn9yeVJ1 zm8Wzw37V4K4ozuS/Xh63N9h6tmqMIBVKkLreTGy8Pon4pji7MjQCx3pCG+c/nYfjI5H kGSzz/CU+ECGrf+rcZHNFN5deN50owQqN9pGg11rEqIiPLmdXOFTyDY81+cStPxoKwuy r1Lm+W7eW7xKrgw1Hm2QSs1dnewhsky7AiItkke27qR5K+dkRlUuSIKJc8MO3YdRicgE mJckExEm6ZgEgVHw4UW3wOr5J0PphSg4RHEdQNvoD8B4iMDB3Mf9fPM/YJsNSQ+KIiab 0y1g== X-Gm-Message-State: AKGB3mJK7m6CzCTS4XXXjWFjvxWEGyjCV1ZQS4VLMNUyaWe/yDT7QVt3 4ZIZNJXMNnhIfIseEFAJeXOEuJu+ X-Google-Smtp-Source: AGs4zMbunmjB9iWL2fBbZMF2cLQbPUqo38Fneuq48EEQC/X5iDeor4ibzfUDePrU61PWokVtdR1zDA== X-Received: by 10.233.230.1 with SMTP id z1mr12305611qkf.325.1512209991240; Sat, 02 Dec 2017 02:19:51 -0800 (PST) Received: from dhcp-135-24-192-103.dhcp.broadcom.net ([192.19.239.250]) by smtp.googlemail.com with ESMTPSA id z22sm6263632qta.81.2017.12.02.02.19.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 02 Dec 2017 02:19:50 -0800 (PST) From: Suganath Prabu S To: linux-scsi@vger.kernel.org, linux-nvme@lists.infradead.org Cc: Sathya.Prakash@broadcom.com, sreekanth.reddy@broadcom.com, suganath-prabu.subramani@broadcom.com, chaitra.basappa@broadcom.com Subject: [PATCH] mpt3sas: Remove unused variable requeue_event Date: Sat, 2 Dec 2017 02:19:26 -0800 Message-Id: <1512209966-27239-1-git-send-email-suganath-prabu.subramani@broadcom.com> X-Mailer: git-send-email 2.5.5 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP No Functional change just cleanup, Removed variable requeue_event and made function as void. Signed-off-by: Suganath Prabu S --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/mpt3sas/mpt3sas_scsih.c index 362f406..c71f964 100644 --- a/drivers/scsi/mpt3sas/mpt3sas_scsih.c +++ b/drivers/scsi/mpt3sas/mpt3sas_scsih.c @@ -7211,7 +7211,7 @@ _scsih_pcie_topology_change_event_debug(struct MPT3SAS_ADAPTER *ioc, * Context: user. * */ -static int +static void _scsih_pcie_topology_change_event(struct MPT3SAS_ADAPTER *ioc, struct fw_event_work *fw_event) { @@ -7221,7 +7221,6 @@ _scsih_pcie_topology_change_event(struct MPT3SAS_ADAPTER *ioc, u8 link_rate, prev_link_rate; unsigned long flags; int rc; - int requeue_event; Mpi26EventDataPCIeTopologyChangeList_t *event_data = (Mpi26EventDataPCIeTopologyChangeList_t *) fw_event->event_data; struct _pcie_device *pcie_device; @@ -7231,12 +7230,12 @@ _scsih_pcie_topology_change_event(struct MPT3SAS_ADAPTER *ioc, if (ioc->shost_recovery || ioc->remove_host || ioc->pci_error_recovery) - return 0; + return; if (fw_event->ignore) { dewtprintk(ioc, pr_info(MPT3SAS_FMT "ignoring switch event\n", ioc->name)); - return 0; + return; } /* handle siblings events */ @@ -7244,10 +7243,10 @@ _scsih_pcie_topology_change_event(struct MPT3SAS_ADAPTER *ioc, if (fw_event->ignore) { dewtprintk(ioc, pr_info(MPT3SAS_FMT "ignoring switch event\n", ioc->name)); - return 0; + return; } if (ioc->remove_host || ioc->pci_error_recovery) - return 0; + return; reason_code = event_data->PortEntry[i].PortStatus; handle = le16_to_cpu(event_data->PortEntry[i].AttachedDevHandle); @@ -7316,7 +7315,6 @@ _scsih_pcie_topology_change_event(struct MPT3SAS_ADAPTER *ioc, break; } } - return requeue_event; } /**