From patchwork Sat Dec 30 15:28:27 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Himanshu Jha X-Patchwork-Id: 10137793 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2F55C60233 for ; Sat, 30 Dec 2017 15:31:31 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 22BC1287A1 for ; Sat, 30 Dec 2017 15:31:31 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 17C85287A3; Sat, 30 Dec 2017 15:31:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SBL_CSS autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C23CD287A1 for ; Sat, 30 Dec 2017 15:31:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751278AbdL3PaI (ORCPT ); Sat, 30 Dec 2017 10:30:08 -0500 Received: from mail-pl0-f67.google.com ([209.85.160.67]:33830 "EHLO mail-pl0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751185AbdL3PaF (ORCPT ); Sat, 30 Dec 2017 10:30:05 -0500 Received: by mail-pl0-f67.google.com with SMTP id d21so24594330pll.1; Sat, 30 Dec 2017 07:30:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=+BQbGYsZhAftZnjvyujuHsh87UY6OsIO4oMC/9+0BOc=; b=LzxCsXY1bJm2GYBBfUzTdJ2hFcyW98XwWQf2TbqLA+12D3O12Nll4xai4THX4WbP+n n4fszjD733rZC1Y/7GpQHQ85ikTTXbv97Ks422tb74wgrAgCxTt2iOyJcLbBzFy/EBRp UBhwTu7dqnZRyvc6PAcvkxA67IMUg7FKiEY+Ml/cdoCjuhaH/ptAbdRdGYABuuFCXFxp MV0QfeLPWKSWA2+A2hxw/p3ejE42S56pcFH3hkPaFiyKTJJnkzNM0Wo+MfcAg1bIqxdc bU9Jq3wIWRxtB/QzUDbtsgDsjcodjYaWs9oDPRX7ooy901/GKTknPcR3anzGQzbTyhV1 /Amg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=+BQbGYsZhAftZnjvyujuHsh87UY6OsIO4oMC/9+0BOc=; b=TL1xN1G0GHqb3cIUctWLj6FEDKwYpFXT76QRJO8nH9VVmCPYtjHHkiqikSQUG1Fu/4 XWw/fP2BMaLBkpyjTVMe6KsDjExDm6CQr8wF76l2s2ohf3yvaMYUqLxtg2a9yHLQUh3J SftDDIO9PtBSWP0SQaGGNsTKnZ9zvaX17U3y0kdeTWkEYKpjd+8cCbMej0AADfTKFzUM rj8hdi41SmXshiY0ZPQC2tYGZ6kadKf8Xy+DsPmocNbN1bYSr6/37uE0+/PJC7qiL7ME MLIv246z3+tdjnzVNE/xuaPqL8eq5jk1w+NHezy2v4YpjWgyo/qtaHAqnEvlzG8WDJnY LRWA== X-Gm-Message-State: AKGB3mJFYkmTp0nWd1kV0+on91EUxn6d6/x8uScXuylDNJaW79y5cjO4 nuq04zimC0giTe2i+ZCRpIA= X-Google-Smtp-Source: ACJfBote6PE7tEVUy5/viNCyKnt5wvgZSU5HenHJl9ipc5JQTjmPvJplMh8ULvXfk5QxqSgMc+VJNA== X-Received: by 10.84.244.138 with SMTP id h10mr36618199pll.289.1514647804957; Sat, 30 Dec 2017 07:30:04 -0800 (PST) Received: from localhost.localdomain ([103.46.193.14]) by smtp.gmail.com with ESMTPSA id f79sm81933715pfd.45.2017.12.30.07.29.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 30 Dec 2017 07:30:03 -0800 (PST) From: Himanshu Jha To: jejb@linux.vnet.ibm.com, martin.petersen@oracle.com, aacraid@adaptec.com Cc: anil.gurumurthy@qlogic.com, sudarsana.kalluru@qlogic.com, QLogic-Storage-Upstream@qlogic.com, satishkh@cisco.com, sebaddel@cisco.com, kartilak@cisco.com, QLogic-Storage-Upstream@cavium.com, qla2xxx-upstream@qlogic.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Himanshu Jha Subject: [PATCH 4/9] scsi: mvsas: Use zeroing allocator rather than allocator/memset Date: Sat, 30 Dec 2017 20:58:27 +0530 Message-Id: <1514647712-6332-5-git-send-email-himanshujha199640@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1514647712-6332-1-git-send-email-himanshujha199640@gmail.com> References: <1514647712-6332-1-git-send-email-himanshujha199640@gmail.com> Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Use dma_zalloc_coherent instead of dma_alloc_coherent followed by memset 0. Generated-by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci Suggested-by: Luis R. Rodriguez Signed-off-by: Himanshu Jha --- drivers/scsi/mvsas/mv_init.c | 27 +++++++++++---------------- 1 file changed, 11 insertions(+), 16 deletions(-) diff --git a/drivers/scsi/mvsas/mv_init.c b/drivers/scsi/mvsas/mv_init.c index 8c91637..6748394 100644 --- a/drivers/scsi/mvsas/mv_init.c +++ b/drivers/scsi/mvsas/mv_init.c @@ -253,33 +253,28 @@ static int mvs_alloc(struct mvs_info *mvi, struct Scsi_Host *shost) /* * alloc and init our DMA areas */ - mvi->tx = dma_alloc_coherent(mvi->dev, - sizeof(*mvi->tx) * MVS_CHIP_SLOT_SZ, - &mvi->tx_dma, GFP_KERNEL); + mvi->tx = dma_zalloc_coherent(mvi->dev, + sizeof(*mvi->tx) * MVS_CHIP_SLOT_SZ, + &mvi->tx_dma, GFP_KERNEL); if (!mvi->tx) goto err_out; - memset(mvi->tx, 0, sizeof(*mvi->tx) * MVS_CHIP_SLOT_SZ); - mvi->rx_fis = dma_alloc_coherent(mvi->dev, MVS_RX_FISL_SZ, - &mvi->rx_fis_dma, GFP_KERNEL); + mvi->rx_fis = dma_zalloc_coherent(mvi->dev, MVS_RX_FISL_SZ, + &mvi->rx_fis_dma, GFP_KERNEL); if (!mvi->rx_fis) goto err_out; - memset(mvi->rx_fis, 0, MVS_RX_FISL_SZ); - - mvi->rx = dma_alloc_coherent(mvi->dev, - sizeof(*mvi->rx) * (MVS_RX_RING_SZ + 1), - &mvi->rx_dma, GFP_KERNEL); + mvi->rx = dma_zalloc_coherent(mvi->dev, + sizeof(*mvi->rx) * (MVS_RX_RING_SZ + 1), + &mvi->rx_dma, GFP_KERNEL); if (!mvi->rx) goto err_out; - memset(mvi->rx, 0, sizeof(*mvi->rx) * (MVS_RX_RING_SZ + 1)); mvi->rx[0] = cpu_to_le32(0xfff); mvi->rx_cons = 0xfff; - mvi->slot = dma_alloc_coherent(mvi->dev, - sizeof(*mvi->slot) * slot_nr, - &mvi->slot_dma, GFP_KERNEL); + mvi->slot = dma_zalloc_coherent(mvi->dev, + sizeof(*mvi->slot) * slot_nr, + &mvi->slot_dma, GFP_KERNEL); if (!mvi->slot) goto err_out; - memset(mvi->slot, 0, sizeof(*mvi->slot) * slot_nr); mvi->bulk_buffer = dma_alloc_coherent(mvi->dev, TRASH_BUCKET_SIZE,