From patchwork Fri Apr 8 19:08:46 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurence Oberman X-Patchwork-Id: 8785391 Return-Path: X-Original-To: patchwork-linux-scsi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id EEF169F659 for ; Fri, 8 Apr 2016 19:09:38 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E31AD20204 for ; Fri, 8 Apr 2016 19:09:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 65C9F202DD for ; Fri, 8 Apr 2016 19:09:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758837AbcDHTIv (ORCPT ); Fri, 8 Apr 2016 15:08:51 -0400 Received: from mx4-phx2.redhat.com ([209.132.183.25]:49485 "EHLO mx4-phx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752365AbcDHTIt (ORCPT ); Fri, 8 Apr 2016 15:08:49 -0400 Received: from zmail22.collab.prod.int.phx2.redhat.com (zmail22.collab.prod.int.phx2.redhat.com [10.5.83.26]) by mx4-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id u38J8kxA006778; Fri, 8 Apr 2016 15:08:46 -0400 Date: Fri, 8 Apr 2016 15:08:46 -0400 (EDT) From: Laurence Oberman To: Denys Vlasenko Cc: James Bottomley , Hiral Patel , Suma Ramars , Brian Uchino , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <1514889616.28091362.1460142525998.JavaMail.zimbra@redhat.com> In-Reply-To: <1460141926-13069-2-git-send-email-dvlasenk@redhat.com> References: <1460141926-13069-1-git-send-email-dvlasenk@redhat.com> <1460141926-13069-2-git-send-email-dvlasenk@redhat.com> Subject: Re: [PATCH] drivers/scsi/fnic/fnic_scsi.c: Deinline fnic_queue_abort_io_req, save 1792 bytes MIME-Version: 1.0 X-Originating-IP: [10.36.7.193] X-Mailer: Zimbra 8.0.6_GA_5922 (ZimbraWebClient - FF38 (Linux)/8.0.6_GA_5922) Thread-Topic: drivers/scsi/fnic/fnic_scsi.c: Deinline fnic_queue_abort_io_req, save 1792 bytes Thread-Index: KtkKtfTO27XDIAFTYdVRN1c3CXx/uQ== Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Spam-Status: No, score=-7.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Simple change, looks fine to me. Reviewed-by: Laurence Oberman Laurence Oberman Principal Software Maintenance Engineer Red Hat Global Support Services ----- Original Message ----- From: "Denys Vlasenko" To: "James Bottomley" Cc: "Denys Vlasenko" , "Hiral Patel" , "Suma Ramars" , "Brian Uchino" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Sent: Friday, April 8, 2016 2:58:43 PM Subject: [PATCH] drivers/scsi/fnic/fnic_scsi.c: Deinline fnic_queue_abort_io_req, save 1792 bytes This function compiles to 511 bytes of machine code. Abort commands are not time-critical at all. Signed-off-by: Denys Vlasenko CC: James Bottomley CC: Hiral Patel CC: Suma Ramars CC: Brian Uchino CC: linux-scsi@vger.kernel.org CC: linux-kernel@vger.kernel.org --- drivers/scsi/fnic/fnic_scsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/fnic/fnic_scsi.c b/drivers/scsi/fnic/fnic_scsi.c index 266b909..0a3edee 100644 --- a/drivers/scsi/fnic/fnic_scsi.c +++ b/drivers/scsi/fnic/fnic_scsi.c @@ -1435,7 +1435,7 @@ wq_copy_cleanup_scsi_cmd: } } -static inline int fnic_queue_abort_io_req(struct fnic *fnic, int tag, +static int fnic_queue_abort_io_req(struct fnic *fnic, int tag, u32 task_req, u8 *fc_lun, struct fnic_io_req *io_req) {