| Message ID | 1517287281-8622-1-git-send-email-asutoshd@codeaurora.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
Hi Asutosh, On 1/30/2018 10:11 AM, Asutosh Das wrote: > From: Subhash Jadavani <subhashj@codeaurora.org> > > UFSHCD_QUIRK_BROKEN_UFS_HCI_VERSION is only applicable for QCOM UFS host > controller version 2.x.y and this has been fixed from version 3.x.y > onwards, hence this change removes this quirk for version 3.x.y onwards. > > Signed-off-by: Subhash Jadavani <subhashj@codeaurora.org> > Signed-off-by: Asutosh Das <asutoshd@codeaurora.org> > --- This patch and all other ufs patches that you have posted recently, do they all fall under one 'ufs-qcom fixes' patch series for fixes that we would want to do? If it is so, then please club them together in a series, so that it's easy for reviewers and maintainers to review, and keep track of all the patches that can get-in after the reviews. If they belong to two or more separate patch-series then please create such patch series. It's difficult to read through a lot of [PATCH 1/1] ... patch. Regards Vivek > drivers/scsi/ufs/ufs-qcom.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c > index 2b38db2..221820a 100644 > --- a/drivers/scsi/ufs/ufs-qcom.c > +++ b/drivers/scsi/ufs/ufs-qcom.c > @@ -1098,7 +1098,7 @@ static void ufs_qcom_advertise_quirks(struct ufs_hba *hba) > hba->quirks |= UFSHCD_QUIRK_BROKEN_LCC; > } > > - if (host->hw_ver.major >= 0x2) { > + if (host->hw_ver.major == 0x2) { > hba->quirks |= UFSHCD_QUIRK_BROKEN_UFS_HCI_VERSION; > > if (!ufs_qcom_cap_qunipro(host))
On 1/30/2018 11:33 AM, Vivek Gautam wrote: > Hi Asutosh, > > > On 1/30/2018 10:11 AM, Asutosh Das wrote: >> From: Subhash Jadavani <subhashj@codeaurora.org> >> >> UFSHCD_QUIRK_BROKEN_UFS_HCI_VERSION is only applicable for QCOM UFS host >> controller version 2.x.y and this has been fixed from version 3.x.y >> onwards, hence this change removes this quirk for version 3.x.y onwards. >> >> Signed-off-by: Subhash Jadavani <subhashj@codeaurora.org> >> Signed-off-by: Asutosh Das <asutoshd@codeaurora.org> >> --- > > This patch and all other ufs patches that you have posted recently, > do they all fall under one 'ufs-qcom fixes' patch series for fixes that > we would want to do? > If it is so, then please club them together in a series, so that > it's easy for reviewers and maintainers to review, and keep track > of all the patches that can get-in after the reviews. > If they belong to two or more separate patch-series then please > create such patch series. > It's difficult to read through a lot of [PATCH 1/1] ... patch. Sure Vivek - Makes sense. Will resend it. > > Regards > Vivek > >> drivers/scsi/ufs/ufs-qcom.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c >> index 2b38db2..221820a 100644 >> --- a/drivers/scsi/ufs/ufs-qcom.c >> +++ b/drivers/scsi/ufs/ufs-qcom.c >> @@ -1098,7 +1098,7 @@ static void ufs_qcom_advertise_quirks(struct >> ufs_hba *hba) >> hba->quirks |= UFSHCD_QUIRK_BROKEN_LCC; >> } >> - if (host->hw_ver.major >= 0x2) { >> + if (host->hw_ver.major == 0x2) { >> hba->quirks |= UFSHCD_QUIRK_BROKEN_UFS_HCI_VERSION; >> if (!ufs_qcom_cap_qunipro(host)) >
diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c index 2b38db2..221820a 100644 --- a/drivers/scsi/ufs/ufs-qcom.c +++ b/drivers/scsi/ufs/ufs-qcom.c @@ -1098,7 +1098,7 @@ static void ufs_qcom_advertise_quirks(struct ufs_hba *hba) hba->quirks |= UFSHCD_QUIRK_BROKEN_LCC; } - if (host->hw_ver.major >= 0x2) { + if (host->hw_ver.major == 0x2) { hba->quirks |= UFSHCD_QUIRK_BROKEN_UFS_HCI_VERSION; if (!ufs_qcom_cap_qunipro(host))